From 301c1d21fea4fc06ac70fd4727a5cadb9a8751da Mon Sep 17 00:00:00 2001 From: Dominik Schmidt Date: Wed, 28 Mar 2012 15:34:51 +0200 Subject: [PATCH] Make publishing the user tune optional --- src/accounts/xmpp/XmppInfoPlugin.cpp | 8 +++++++- src/accounts/xmpp/xmppconfigwidget.cpp | 2 ++ src/accounts/xmpp/xmppconfigwidget.ui | 12 +++++++++++- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/accounts/xmpp/XmppInfoPlugin.cpp b/src/accounts/xmpp/XmppInfoPlugin.cpp index 6cfd7cc0f..27166c829 100644 --- a/src/accounts/xmpp/XmppInfoPlugin.cpp +++ b/src/accounts/xmpp/XmppInfoPlugin.cpp @@ -59,7 +59,13 @@ Tomahawk::InfoSystem::XmppInfoPlugin::~XmppInfoPlugin() void Tomahawk::InfoSystem::XmppInfoPlugin::pushInfo(QString caller, Tomahawk::InfoSystem::InfoType type, QVariant input) { - tDebug() << Q_FUNC_INFO; + tDebug() << Q_FUNC_INFO << m_sipPlugin->m_client->jid().full(); + + if( m_sipPlugin->m_account->configuration().value("publishtracks").toBool() == false ) + { + tDebug() << Q_FUNC_INFO << m_sipPlugin->m_client->jid().full() << "Not publishing now playing info (disabled in account config)"; + return; + } switch ( type ) { diff --git a/src/accounts/xmpp/xmppconfigwidget.cpp b/src/accounts/xmpp/xmppconfigwidget.cpp index 70e58d01d..b93559d61 100644 --- a/src/accounts/xmpp/xmppconfigwidget.cpp +++ b/src/accounts/xmpp/xmppconfigwidget.cpp @@ -43,6 +43,7 @@ XmppConfigWidget::XmppConfigWidget( XmppAccount* account, QWidget *parent ) : m_ui->xmppPassword->setText( account->credentials().contains( "password" ) ? account->credentials()[ "password" ].toString() : QString() ); m_ui->xmppServer->setText( account->configuration().contains( "server" ) ? account->configuration()[ "server" ].toString() : QString() ); m_ui->xmppPort->setValue( account->configuration().contains( "port" ) ? account->configuration()[ "port" ].toInt() : 5222 ); + m_ui->xmppPublishTracksCheckbox->setChecked( account->configuration().contains( "publishtracks" ) ? account->configuration()[ "publishtracks" ].toBool() : true); m_ui->jidExistsLabel->hide(); connect( m_ui->xmppUsername, SIGNAL( textChanged( QString ) ), SLOT( onCheckJidExists( QString ) ) ); @@ -64,6 +65,7 @@ XmppConfigWidget::saveConfig() QVariantHash configuration = m_account->configuration(); configuration[ "server" ] = m_ui->xmppServer->text().trimmed(); configuration[ "port" ] = m_ui->xmppPort->text().trimmed(); + configuration[ "publishtracks"] = m_ui->xmppPublishTracksCheckbox->checkState() == Qt::Checked ? true : false; m_account->setAccountFriendlyName( m_ui->xmppUsername->text() ); m_account->setCredentials( credentials ); diff --git a/src/accounts/xmpp/xmppconfigwidget.ui b/src/accounts/xmpp/xmppconfigwidget.ui index 99876aa6a..07a585604 100644 --- a/src/accounts/xmpp/xmppconfigwidget.ui +++ b/src/accounts/xmpp/xmppconfigwidget.ui @@ -209,7 +209,7 @@ Advanced Xmpp Settings - + @@ -293,6 +293,16 @@ + + + + Lots of servers don't support this (e.g. GTalk, jabber.org) + + + Publish currently playing track + + +