From 9c6e09884154b55992cb0d6c0effb84961ad44ee Mon Sep 17 00:00:00 2001
From: Christian Muehlhaeuser <muesli@gmail.com>
Date: Fri, 14 Jan 2011 17:07:30 +0100
Subject: [PATCH 1/2] * Safely handle unknown DB commands.

---
 src/libtomahawk/database/databaseworker.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libtomahawk/database/databaseworker.cpp b/src/libtomahawk/database/databaseworker.cpp
index 60bbc2135..1aa6cd283 100644
--- a/src/libtomahawk/database/databaseworker.cpp
+++ b/src/libtomahawk/database/databaseworker.cpp
@@ -64,7 +64,7 @@ DatabaseWorker::doWork( QSharedPointer<DatabaseCommand> cmd )
     if( cmd->doesMutates() )
     {
         bool transok = m_dbimpl->database().transaction();
-        Q_ASSERT( transok );
+//        Q_ASSERT( transok );
         Q_UNUSED( transok );
     }
     try
@@ -141,7 +141,7 @@ DatabaseWorker::doWork( QSharedPointer<DatabaseCommand> cmd )
         if( cmd->doesMutates() )
             m_dbimpl->database().rollback();
 
-        Q_ASSERT( false );
+//        Q_ASSERT( false );
     }
     catch(...)
     {

From d4c82bf4f71a0225460d56b3312e494256cbad9d Mon Sep 17 00:00:00 2001
From: Christian Muehlhaeuser <muesli@gmail.com>
Date: Fri, 14 Jan 2011 17:44:29 +0100
Subject: [PATCH 2/2] * CMakeLists.* cleanup.

---
 src/CMakeLists.osx.txt         |  12 +-
 src/CMakeLists.txt             |  36 +++---
 src/CMakeLists.unix.txt        |  15 ++-
 src/CMakeLists.win32.txt       |  56 ++++----
 src/libtomahawk/CMakeLists.txt | 225 ++++++++++++++++-----------------
 5 files changed, 170 insertions(+), 174 deletions(-)

diff --git a/src/CMakeLists.osx.txt b/src/CMakeLists.osx.txt
index 0b2753ed7..34a67dc3e 100644
--- a/src/CMakeLists.osx.txt
+++ b/src/CMakeLists.osx.txt
@@ -5,10 +5,10 @@ FIND_LIBRARY( COREAUDIO_LIBRARY CoreAudio )
 FIND_LIBRARY( COREFOUNDATION_LIBRARY CoreFoundation )
 MARK_AS_ADVANCED( COREAUDIO_LIBRARY COREFOUNDATION_LIBRARY )
 
-SET( OS_SPECIFIC_LINK_LIBRARIES 
-	${OS_SPECIFIC_LINK_LIBRARIES}
-	${COREAUDIO_LIBRARY} 
-	${COREFOUNDATION_LIBRARY}
-	rtaudio 
-	tomahawklib
+SET( OS_SPECIFIC_LINK_LIBRARIES
+    ${OS_SPECIFIC_LINK_LIBRARIES}
+    ${COREAUDIO_LIBRARY}
+    ${COREFOUNDATION_LIBRARY}
+    rtaudio
+    tomahawklib
 )
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 667488832..0a5c7e248 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -7,8 +7,8 @@ ENDIF()
 SET( QT_USE_QTSQL TRUE )
 SET( QT_USE_QTNETWORK TRUE )
 SET( QT_USE_QTXML TRUE )
-INCLUDE( ${QT_USE_FILE} )
 
+INCLUDE( ${QT_USE_FILE} )
 INCLUDE( ${CMAKE_MODULE_PATH}/AddAppIconMacro.cmake )
 
 #SET( CMAKE_BUILD_TYPE "Release" )
@@ -40,20 +40,18 @@ SET( tomahawkSources ${tomahawkSources}
      infosystem/infoplugins/echonestplugin.cpp
      infosystem/infoplugins/musixmatchplugin.cpp
 
-     musicscanner.cpp
-     scriptresolver.cpp
-
-     scrobbler.cpp
      xmppbot/xmppbot.cpp
      web/api_v1.cpp
 
+     musicscanner.cpp
+     scriptresolver.cpp
+     scrobbler.cpp
+
      tomahawkapp.cpp
      main.cpp
 )
 
 SET( tomahawkSourcesGui ${tomahawkSourcesGui}
-     xspfloader.cpp
-
      utils/querylabel.cpp
      utils/elidedlabel.cpp
      utils/imagebutton.cpp
@@ -100,16 +98,16 @@ SET( tomahawkSourcesGui ${tomahawkSourcesGui}
      widgets/newplaylistwidget.cpp
      widgets/welcomewidget.cpp
 
+     xspfloader.cpp
      transferview.cpp
-     tomahawkwindow.cpp
      tomahawktrayicon.cpp
      audiocontrols.cpp
      settingsdialog.cpp
+     tomahawkwindow.cpp
 )
 
 SET( tomahawkHeaders ${tomahawkHeaders}
      "${TOMAHAWK_INC_DIR}/tomahawk/tomahawkapp.h"
-
      "${TOMAHAWK_INC_DIR}/tomahawk/infosystem.h"
 
      audio/transcodeinterface.h
@@ -123,17 +121,15 @@ SET( tomahawkHeaders ${tomahawkHeaders}
      infosystem/infoplugins/echonestplugin.h
      infosystem/infoplugins/musixmatchplugin.h
 
-     musicscanner.h
-     scriptresolver.h
-
-     scrobbler.h
      xmppbot/xmppbot.h
      web/api_v1.h
+
+     musicscanner.h
+     scriptresolver.h
+     scrobbler.h
 )
 
 SET( tomahawkHeadersGui ${tomahawkHeadersGui}
-     xspfloader.h
-
      utils/querylabel.h
      utils/elidedlabel.h
      utils/animatedcounterlabel.h
@@ -181,11 +177,12 @@ SET( tomahawkHeadersGui ${tomahawkHeadersGui}
      widgets/newplaylistwidget.h
      widgets/welcomewidget.h
 
+     xspfloader.h
      transferview.h
-     tomahawkwindow.h
      tomahawktrayicon.h
      audiocontrols.h
      settingsdialog.h
+     tomahawkwindow.h
 )
 
 SET( tomahawkUI ${tomahawkUI}
@@ -196,6 +193,7 @@ SET( tomahawkUI ${tomahawkUI}
      audiocontrols.ui
      sourcetree/sourcetreeitemwidget.ui
      topbar/topbar.ui
+
      infowidgets/sourceinfowidget.ui
      widgets/newplaylistwidget.ui
      widgets/welcomewidget.ui
@@ -247,9 +245,9 @@ SET( final_src ${final_src} ${tomahawkMoc} ${tomahawkSources} ${tomahawkHeaders}
 
 IF( "${gui}" STREQUAL "no" )
 ELSE()
-	qt4_wrap_ui( tomahawkUI_H ${tomahawkUI} )
-	qt4_wrap_cpp( tomahawkMocGui ${tomahawkHeadersGui} )
-	SET( final_src ${final_src} ${tomahawkUI_H} ${tomahawkMocGui} ${tomahawkSourcesGui} ${RC_SRCS} )
+    qt4_wrap_ui( tomahawkUI_H ${tomahawkUI} )
+    qt4_wrap_cpp( tomahawkMocGui ${tomahawkHeadersGui} )
+    SET( final_src ${final_src} ${tomahawkUI_H} ${tomahawkMocGui} ${tomahawkSourcesGui} ${RC_SRCS} )
 ENDIF()
 
 IF( UNIX AND NOT APPLE )
diff --git a/src/CMakeLists.unix.txt b/src/CMakeLists.unix.txt
index 3998468e5..9cbded495 100644
--- a/src/CMakeLists.unix.txt
+++ b/src/CMakeLists.unix.txt
@@ -13,16 +13,17 @@ SET( OS_SPECIFIC_LINK_LIBRARIES
 )
 
 SET( OS_SPECIFIC_LINK_LIBRARIES 
-	 ${OS_SPECIFIC_LINK_LIBRARIES}
-	 mad 
-	 vorbisfile 
-	 ogg
-	 FLAC++
+    ${OS_SPECIFIC_LINK_LIBRARIES}
+    mad 
+    vorbisfile 
+    ogg
+    FLAC++
 )
 
 IF( APPLE )
-  INCLUDE( "CMakeLists.osx.txt" )
+    INCLUDE( "CMakeLists.osx.txt" )
 ENDIF( APPLE )
+
 IF( UNIX AND NOT APPLE )
-  INCLUDE( "CMakeLists.linux.txt" )
+    INCLUDE( "CMakeLists.linux.txt" )
 ENDIF( UNIX AND NOT APPLE )
diff --git a/src/CMakeLists.win32.txt b/src/CMakeLists.win32.txt
index 2777a8338..7ac8be8b0 100644
--- a/src/CMakeLists.win32.txt
+++ b/src/CMakeLists.win32.txt
@@ -9,47 +9,47 @@ ADD_DEFINITIONS( -static-libgcc )
 
 # Add manual locations to stuff:
 INCLUDE_DIRECTORIES(
-	../../libmad-0.15.1b
-	../../boost_1_43_0
-	../../gloox-1.0
-	../../qjson
-	../../liblastfm/_include
-	../../taglib-1.6.3/
-	../../taglib-1.6.3/build
-	../../taglib-1.6.3/taglib
-	../../taglib-1.6.3/taglib/toolkit
+    ../../libmad-0.15.1b
+    ../../boost_1_43_0
+    ../../gloox-1.0
+    ../../qjson
+    ../../liblastfm/_include
+    ../../taglib-1.6.3/
+    ../../taglib-1.6.3/build
+    ../../taglib-1.6.3/taglib
+    ../../taglib-1.6.3/taglib/toolkit
 )
 
 
 SET( GLOOX_LIBS
-	${GLOOX_LIBS}
-	gloox
+    ${GLOOX_LIBS}
+    gloox
 )
 
 SET( OS_SPECIFIC_LINK_LIBRARIES 
-        ${LIBLASTFM_LIBRARY}
-	${GLOOX_LIBS}
+    ${LIBLASTFM_LIBRARY}
+    ${GLOOX_LIBS}
 )
 
 SET( OS_SPECIFIC_LINK_LIBRARIES 
-	${OS_SPECIFIC_LINK_LIBRARIES}
-	"secur32.dll"
-	"crypt32.dll"
-	"${CMAKE_CURRENT_SOURCE_DIR}/../qxt/qxtweb-standalone/libqxtweb-standalone.dll"
-        "${CMAKE_CURRENT_SOURCE_DIR}/../build/src/libtomahawk/libtomahawklib.dll"
+    ${OS_SPECIFIC_LINK_LIBRARIES}
+    "secur32.dll"
+    "crypt32.dll"
+    "${CMAKE_CURRENT_SOURCE_DIR}/../qxt/qxtweb-standalone/libqxtweb-standalone.dll"
+    "${CMAKE_CURRENT_SOURCE_DIR}/../build/src/libtomahawk/libtomahawklib.dll"
 )
 
 SET( tomahawkSourcesGui ${tomahawkSourcesGui} audio/rtaudiooutput.cpp )
 SET( tomahawkHeadersGui ${tomahawkHeadersGui} audio/rtaudiooutput.h )
-	
+
 SET( OS_SPECIFIC_LINK_LIBRARIES 
-	${OS_SPECIFIC_LINK_LIBRARIES} 
-	"dsound.dll" 
-	"winmm.dll"
-        "iphlpapi.a"
-        "mad"
-	"vorbisfile"
-	"ogg"
-        "FLAC++"
-	"${CMAKE_CURRENT_SOURCE_DIR}/../rtaudio/librtaudio.dll"
+    ${OS_SPECIFIC_LINK_LIBRARIES} 
+    "dsound.dll" 
+    "winmm.dll"
+    "iphlpapi.a"
+    "mad"
+    "vorbisfile"
+    "ogg"
+    "FLAC++"
+    "${CMAKE_CURRENT_SOURCE_DIR}/../rtaudio/librtaudio.dll"
 )
diff --git a/src/libtomahawk/CMakeLists.txt b/src/libtomahawk/CMakeLists.txt
index 7a75ab38d..f5dae399a 100644
--- a/src/libtomahawk/CMakeLists.txt
+++ b/src/libtomahawk/CMakeLists.txt
@@ -3,127 +3,124 @@ project( tomahawklib )
 SET( QT_USE_QTSQL TRUE )
 SET( QT_USE_QTNETWORK TRUE )
 SET( QT_USE_QTXML TRUE )
+
 include( ${QT_USE_FILE} )
+
 add_definitions( ${QT_DEFINITIONS} )
 add_definitions( -DQT_SHARED )
 add_definitions( -DDLLEXPORT_PRO )
 
 set( libSources
-        tomahawksettings.cpp
-	sourcelist.cpp
-	pipeline.cpp
+    tomahawksettings.cpp
+    sourcelist.cpp
+    pipeline.cpp
+    artist.cpp
+    album.cpp
+    collection.cpp
+    playlist.cpp
+    pluginapi.cpp
+    query.cpp
+    result.cpp
+    source.cpp
 
-     artist.cpp
-     album.cpp
-     collection.cpp
-     playlist.cpp
-     pluginapi.cpp
-     query.cpp
-     result.cpp
-     source.cpp
+    sip/SipPlugin.cpp
 
-     sip/SipPlugin.cpp
+    database/database.cpp
+    database/databasecollection.cpp
+    database/databaseworker.cpp
+    database/databaseimpl.cpp
+    database/databaseresolver.cpp
+    database/databasecommand.cpp
+    database/databasecommandloggable.cpp
+    database/databasecommand_resolve.cpp
+    database/databasecommand_allalbums.cpp
+    database/databasecommand_alltracks.cpp
+    database/databasecommand_addfiles.cpp
+    database/databasecommand_dirmtimes.cpp
+    database/databasecommand_loadfile.cpp
+    database/databasecommand_logplayback.cpp
+    database/databasecommand_addsource.cpp
+    database/databasecommand_sourceoffline.cpp
+    database/databasecommand_collectionstats.cpp
+    database/databasecommand_loadplaylistentries.cpp
+    database/databasecommand_modifyplaylist.cpp
+    database/databasecommand_playbackhistory.cpp
+    database/databasecommand_setplaylistrevision.cpp
+    database/databasecommand_loadallplaylists.cpp
+    database/databasecommand_createplaylist.cpp
+    database/databasecommand_deleteplaylist.cpp
+    database/databasecommand_renameplaylist.cpp
+    database/databasecommand_loadops.cpp
+    database/databasecommand_updatesearchindex.cpp
+    database/fuzzyindex.cpp
 
-     network/bufferiodevice.cpp
-     network/msgprocessor.cpp
-     network/filetransferconnection.cpp
-     network/dbsyncconnection.cpp
-     network/remotecollection.cpp
-     network/portfwdthread.cpp
-
-     database/fuzzyindex.cpp
-     database/databaseworker.cpp
-     database/databaseimpl.cpp
-     database/databaseresolver.cpp
-     database/databasecommand.cpp
-     database/databasecommandloggable.cpp
-     database/databasecommand_resolve.cpp
-     database/databasecommand_allalbums.cpp
-     database/databasecommand_alltracks.cpp
-     database/databasecommand_addfiles.cpp
-     database/databasecommand_dirmtimes.cpp
-     database/databasecommand_loadfile.cpp
-     database/databasecommand_logplayback.cpp
-     database/databasecommand_addsource.cpp
-     database/databasecommand_sourceoffline.cpp
-     database/databasecommand_collectionstats.cpp
-     database/databasecommand_loadplaylistentries.cpp
-     database/databasecommand_modifyplaylist.cpp
-     database/databasecommand_playbackhistory.cpp
-     database/databasecommand_setplaylistrevision.cpp
-     database/databasecommand_loadallplaylists.cpp
-     database/databasecommand_createplaylist.cpp
-     database/databasecommand_deleteplaylist.cpp
-     database/databasecommand_renameplaylist.cpp
-     database/databasecommand_loadops.cpp
-     database/databasecommand_updatesearchindex.cpp
-     database/databasecollection.cpp
-
-	database/database.cpp
-
-        network/servent.cpp
-        network/connection.cpp
-        network/controlconnection.cpp
+    network/bufferiodevice.cpp
+    network/msgprocessor.cpp
+    network/filetransferconnection.cpp
+    network/dbsyncconnection.cpp
+    network/remotecollection.cpp
+    network/portfwdthread.cpp
+    network/servent.cpp
+    network/connection.cpp
+    network/controlconnection.cpp
 )
 
 set( libHeaders
-        tomahawksettings.h
-	sourcelist.h
-	pipeline.h
-	functimeout.h
+    tomahawksettings.h
+    sourcelist.h
+    pipeline.h
+    functimeout.h
+    collection.h
+    pluginapi.h
+    query.h
+    resolver.h
+    result.h
+    source.h
+    artist.h
+    album.h
+    track.h
+    playlist.h
 
-     collection.h
-     pluginapi.h
-     query.h
-     resolver.h
-     result.h
-     source.h
+    sip/SipPlugin.h
 
-     artist.h
-     album.h
-     track.h
-     playlist.h
+    database/database.h
+    database/databasecollection.h
+    database/databaseworker.h
+    database/databaseimpl.h
+    database/databaseresolver.h
+    database/databasecommand.h
+    database/databasecommandloggable.h
+    database/databasecommand_resolve.h
+    database/databasecommand_allalbums.h
+    database/databasecommand_alltracks.h
+    database/databasecommand_addfiles.h
+    database/databasecommand_dirmtimes.h
+    database/databasecommand_loadfile.h
+    database/databasecommand_logplayback.h
+    database/databasecommand_addsource.h
+    database/databasecommand_sourceoffline.h
+    database/databasecommand_collectionstats.h
+    database/databasecommand_loadplaylistentries.h
+    database/databasecommand_modifyplaylist.h
+    database/databasecommand_playbackhistory.h
+    database/databasecommand_setplaylistrevision.h
+    database/databasecommand_loadallplaylists.h
+    database/databasecommand_createplaylist.h
+    database/databasecommand_deleteplaylist.h
+    database/databasecommand_renameplaylist.h
+    database/databasecommand_loadops.h
+    database/databasecommand_updatesearchindex.h
+    database/fuzzyindex.h
 
-     sip/SipPlugin.h
-
-	database/database.h
-     database/fuzzyindex.h
-     database/databaseworker.h
-     database/databaseimpl.h
-     database/databaseresolver.h
-     database/databasecommand.h
-     database/databasecommandloggable.h
-     database/databasecommand_resolve.h
-     database/databasecommand_allalbums.h
-     database/databasecommand_alltracks.h
-     database/databasecommand_addfiles.h
-     database/databasecommand_dirmtimes.h
-     database/databasecommand_loadfile.h
-     database/databasecommand_logplayback.h
-     database/databasecommand_addsource.h
-     database/databasecommand_sourceoffline.h
-     database/databasecommand_collectionstats.h
-     database/databasecommand_loadplaylistentries.h
-     database/databasecommand_modifyplaylist.h
-     database/databasecommand_playbackhistory.h
-     database/databasecommand_setplaylistrevision.h
-     database/databasecommand_loadallplaylists.h
-     database/databasecommand_createplaylist.h
-     database/databasecommand_deleteplaylist.h
-     database/databasecommand_renameplaylist.h
-     database/databasecommand_loadops.h
-     database/databasecommand_updatesearchindex.h
-     database/databasecollection.h
-
-     network/bufferiodevice.h
-     network/msgprocessor.h
-     network/remotecollection.h
-     network/filetransferconnection.h
-     network/dbsyncconnection.h
-        network/servent.h
-        network/connection.h
-        network/controlconnection.h
-     network/portfwdthread.h
+    network/bufferiodevice.h
+    network/msgprocessor.h
+    network/remotecollection.h
+    network/filetransferconnection.h
+    network/dbsyncconnection.h
+    network/servent.h
+    network/connection.h
+    network/controlconnection.h
+    network/portfwdthread.h
 )
 
 include_directories( . ${CMAKE_CURRENT_BINARY_DIR} .. 
@@ -139,18 +136,18 @@ add_library( tomahawklib SHARED ${libSources} ${libMoc} )
 
 IF( WIN32 )
 SET( OS_SPECIFIC_LINK_LIBRARIES
-	${OS_SPECIFIC_LINK_LIBRARIES}
-        "iphlpapi.a"
-	"ws2_32.dll"
-	"dnsapi.dll"
+    ${OS_SPECIFIC_LINK_LIBRARIES}
+    "iphlpapi.a"
+    "ws2_32.dll"
+    "dnsapi.dll"
 )
 ENDIF( WIN32 )
 
 target_link_libraries( tomahawklib
-	${QT_LIBRARIES}
-	${OS_SPECIFIC_LINK_LIBRARIES}
-	portfwd
-	qjson
+    ${QT_LIBRARIES}
+    ${OS_SPECIFIC_LINK_LIBRARIES}
+    portfwd
+    qjson
 )
 
 install( TARGETS tomahawklib DESTINATION lib )