From 3a8d23c5b1efa6949056590e3589dacc031c4606 Mon Sep 17 00:00:00 2001 From: "Uwe L. Korn" Date: Wed, 22 Oct 2014 09:42:54 +0200 Subject: [PATCH] Style fixes --- src/libtomahawk/audio/AudioOutput.h | 15 +++++++-------- src/libtomahawk/utils/MediaStream.cpp | 13 ++++--------- src/libtomahawk/utils/MediaStream.h | 9 +++------ 3 files changed, 14 insertions(+), 23 deletions(-) diff --git a/src/libtomahawk/audio/AudioOutput.h b/src/libtomahawk/audio/AudioOutput.h index 2c3d7ce24..3fbb70742 100644 --- a/src/libtomahawk/audio/AudioOutput.h +++ b/src/libtomahawk/audio/AudioOutput.h @@ -22,9 +22,8 @@ #ifndef AUDIOOUTPUT_H #define AUDIOOUTPUT_H -#include "../Typedefs.h" - #include "DllMacro.h" +#include "Typedefs.h" #include "utils/MediaStream.h" #include @@ -41,24 +40,24 @@ Q_OBJECT public: enum AudioState { Stopped = 0, Playing = 1, Paused = 2, Error = 3, Loading = 4, Buffering = 5 }; - explicit AudioOutput(QObject* parent = 0); + explicit AudioOutput( QObject* parent = nullptr ); ~AudioOutput(); AudioState state(); - void setCurrentSource( const QUrl& stream); - void setCurrentSource( QIODevice* stream); + void setCurrentSource( const QUrl& stream ); + void setCurrentSource( QIODevice* stream ); void setCurrentSource( MediaStream* stream ); void play(); void pause(); void stop(); - void seek(qint64 milliseconds); + void seek( qint64 milliseconds ); bool isSeekable(); bool isMuted(); - void setMuted(bool m); - void setVolume(qreal vol); + void setMuted( bool m ); + void setVolume( qreal vol ); qreal volume(); qint64 currentTime(); qint64 totalTime(); diff --git a/src/libtomahawk/utils/MediaStream.cpp b/src/libtomahawk/utils/MediaStream.cpp index 9d71d61c4..3827656b9 100644 --- a/src/libtomahawk/utils/MediaStream.cpp +++ b/src/libtomahawk/utils/MediaStream.cpp @@ -30,8 +30,7 @@ static QString s_aeInfoIdentifier = QString( "MEDIASTREAM" ); MediaStream::MediaStream( QObject* parent ) : QObject( parent ) , m_type( Unknown ) - , m_url( QUrl() ) - , m_ioDevice ( 0 ) + , m_ioDevice ( nullptr ) , m_started( false ) , m_bufferingFinished( false ) , m_eos( false ) @@ -39,14 +38,14 @@ MediaStream::MediaStream( QObject* parent ) , m_streamSize( 0 ) { tDebug() << Q_FUNC_INFO; - } MediaStream::MediaStream( const QUrl &url ) : QObject( 0 ) , m_type( Url ) - , m_ioDevice ( 0 ) + , m_url( url ) + , m_ioDevice ( nullptr ) , m_started( false ) , m_bufferingFinished( false ) , m_eos( false ) @@ -54,16 +53,13 @@ MediaStream::MediaStream( const QUrl &url ) , m_streamSize( 0 ) { tDebug() << Q_FUNC_INFO; - - m_url = url; } MediaStream::MediaStream( QIODevice* device ) : QObject( 0 ) , m_type( IODevice ) - , m_url( QUrl() ) - , m_ioDevice ( 0 ) + , m_ioDevice ( device ) , m_started( false ) , m_bufferingFinished( false ) , m_eos( false ) @@ -72,7 +68,6 @@ MediaStream::MediaStream( QIODevice* device ) { tDebug() << Q_FUNC_INFO; - m_ioDevice = device; QObject::connect( m_ioDevice, SIGNAL( readChannelFinished() ), this, SLOT( bufferingFinished() ) ); } diff --git a/src/libtomahawk/utils/MediaStream.h b/src/libtomahawk/utils/MediaStream.h index c35a74eaf..a893e6cb9 100644 --- a/src/libtomahawk/utils/MediaStream.h +++ b/src/libtomahawk/utils/MediaStream.h @@ -21,13 +21,10 @@ #ifndef MEDIASTREAM_H #define MEDIASTREAM_H -#include "../Typedefs.h" - #include "DllMacro.h" +#include "Typedefs.h" #include "utils/Logger.h" -#include -#include #include #include @@ -38,7 +35,7 @@ class DLLEXPORT MediaStream : public QObject public: enum MediaType { Unknown = -1, Empty = 0, Url = 1, Stream = 2, IODevice = 3 }; - MediaStream( QObject* parent = 0 ); + MediaStream( QObject* parent = nullptr ); explicit MediaStream( const QUrl &url ); explicit MediaStream( QIODevice* device ); virtual ~MediaStream(); @@ -74,7 +71,7 @@ protected: char m_buffer[1048576]; private: - Q_DISABLE_COPY( MediaStream ); + Q_DISABLE_COPY( MediaStream ) }; #endif // MEDIASTREAM_H