mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-06 22:26:32 +02:00
Code Issues Releases Wiki Activity

Better function naming in shortenedlinkparser

Browse Source
This commit is contained in:
Stefan Derkits
2012-01-04 17:03:48 +01:00
parent 3655a2b537
commit 4f3ae14dbf
2 changed files with 5 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/libtomahawk/utils/shortenedlinkparser.cpp
View File

@@ -35,7 +35,8 @@ ShortenedLinkParser::ShortenedLinkParser ( const QStringList& urls, QObject* par
: QObject( parent ) : QObject( parent )
{ {
foreach ( const QString& url, urls ) foreach ( const QString& url, urls )
lengthenUrl( url ); if ( handlesUrl( url ) )
lookupUrl( url ) ;
} }
@@ -60,19 +61,8 @@ ShortenedLinkParser::handlesUrl( const QString& url )
url.contains( "rd.io" ) ); url.contains( "rd.io" ) );
} }
void void
ShortenedLinkParser::lengthenUrl( const QString& url ) ShortenedLinkParser::lookupUrl ( const QString& url )
{
if ( !handlesUrl( url ) )
return;
lengthenShortUrl( url );
}
void
ShortenedLinkParser::lengthenShortUrl ( const QString& url )
{ {
tDebug() << "Looking up..." << url; tDebug() << "Looking up..." << url;
@@ -94,7 +84,7 @@ ShortenedLinkParser::lookupFinished()
tDebug() << "RedirectionTargetAttribute set on " << redir; tDebug() << "RedirectionTargetAttribute set on " << redir;
m_queries.remove( r ); m_queries.remove( r );
r->deleteLater(); r->deleteLater();
lengthenShortUrl( redir.toUrl().toString() ); lookupUrl( redir.toUrl().toString() );
} }
else else
{ {

3
src/libtomahawk/utils/shortenedlinkparser.h
View File

@@ -55,8 +55,7 @@ signals:
void urls( const QStringList& urls ); void urls( const QStringList& urls );
private: private:
void lengthenUrl( const QString& url ); void lookupUrl( const QString& url );
void lengthenShortUrl( const QString& url );
void checkFinished(); void checkFinished();
QStringList m_links; QStringList m_links;