mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-05 13:47:26 +02:00
Code Issues Releases Wiki Activity

Only lock once while accessing member objects.

Browse Source 
Previously we locked/unlocked the internal mutex twice to get
d->results. Also we created an unecessary copy of the list.
This commit is contained in:
Uwe L. Korn
2014-09-18 23:35:45 +01:00
parent 477a8b048e
commit 5400ff10ba
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libtomahawk/Query.cpp
View File

@@ -166,8 +166,12 @@ track_ptr
Query::track() const Query::track() const
{ {
Q_D( const Query ); Q_D( const Query );
if ( !results().isEmpty() )
return results().first()->track(); {
QMutexLocker lock( &d->mutex );
if ( !d->results.isEmpty() )
return d->results.first()->track();
}
return d->queryTrack; return d->queryTrack;
} }