mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-07-31 11:20:22 +02:00
Code Issues Releases Wiki Activity

Cache Source objects locally

Browse Source
This commit is contained in:
Uwe L. Korn
2014-07-16 07:39:59 +01:00
parent a5d52405ab
commit 61381647df
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/libtomahawk/database/DatabaseCommand_AllTracks.cpp
View File

@@ -99,6 +99,10 @@ DatabaseCommand_AllTracks::exec( DatabaseImpl* dbi )
query.prepare( sql ); query.prepare( sql );
query.exec(); query.exec();
// Small cache to keep already created source objects.
// This saves some mutex locking.
std::map<uint, Tomahawk::source_ptr> sourceCache;
while( query.next() ) while( query.next() )
{ {
QString artist = query.value( 1 ).toString(); QString artist = query.value( 1 ).toString();
@@ -115,7 +119,17 @@ DatabaseCommand_AllTracks::exec( DatabaseImpl* dbi )
uint albumpos = query.value( 13 ).toUInt(); uint albumpos = query.value( 13 ).toUInt();
uint trackId = query.value( 16 ).toUInt(); uint trackId = query.value( 16 ).toUInt();
Tomahawk::source_ptr s = SourceList::instance()->get( sourceId ); std::map<uint, Tomahawk::source_ptr>::const_iterator _s = sourceCache.find( sourceId );
Tomahawk::source_ptr s;
if ( _s == sourceCache.end() )
{
s = SourceList::instance()->get( sourceId );
sourceCache[sourceId] = s;
}
else
{
s = _s->second;
}
if ( !s ) if ( !s )
{ {
Q_ASSERT( false ); Q_ASSERT( false );