From 645f09d51438ac61cc1d1c22027aab608fec0941 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lorenz=20H=C3=BCbschle-Schneider?= Date: Tue, 21 Oct 2014 14:46:55 +0200 Subject: [PATCH] Avoid copying of constructor results --- src/libtomahawk/UrlHandler.cpp | 2 +- src/libtomahawk/resolvers/JSResolverHelper.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libtomahawk/UrlHandler.cpp b/src/libtomahawk/UrlHandler.cpp index 85957c8a7..487bb49f6 100644 --- a/src/libtomahawk/UrlHandler.cpp +++ b/src/libtomahawk/UrlHandler.cpp @@ -95,7 +95,7 @@ localFileIODeviceFactory( const Tomahawk::result_ptr&, const QString& url, io->open( QIODevice::ReadOnly ); // std::functions cannot accept temporaries as parameters - QSharedPointer< QIODevice > sp = QSharedPointer( io ); + QSharedPointer< QIODevice > sp( io ); callback( url, sp ); } diff --git a/src/libtomahawk/resolvers/JSResolverHelper.cpp b/src/libtomahawk/resolvers/JSResolverHelper.cpp index 9a26719e7..4fc85fe69 100644 --- a/src/libtomahawk/resolvers/JSResolverHelper.cpp +++ b/src/libtomahawk/resolvers/JSResolverHelper.cpp @@ -903,7 +903,7 @@ void JSResolverHelper::gotStreamUrl( std::function< void( const QString&, QSharedPointer< QIODevice >& ) > callback, NetworkReply* reply ) { // std::functions cannot accept temporaries as parameters - QSharedPointer< QIODevice > sp = QSharedPointer< QIODevice >( reply->reply(), &QObject::deleteLater ); + QSharedPointer< QIODevice > sp ( reply->reply(), &QObject::deleteLater ); QString url = reply->reply()->url().toString(); reply->disconnectFromReply(); reply->deleteLater();