From 6748d37a8b20347c16cabf2345bb0c1319e72e38 Mon Sep 17 00:00:00 2001 From: Christian Muehlhaeuser Date: Wed, 5 Jun 2013 09:34:41 +0200 Subject: [PATCH] * The mutex isn't needed. --- src/libtomahawk/widgets/NetworkActivityWidget.cpp | 11 ++++------- src/libtomahawk/widgets/NetworkActivityWidget.h | 4 +--- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/libtomahawk/widgets/NetworkActivityWidget.cpp b/src/libtomahawk/widgets/NetworkActivityWidget.cpp index 85285a026..41265a5a6 100644 --- a/src/libtomahawk/widgets/NetworkActivityWidget.cpp +++ b/src/libtomahawk/widgets/NetworkActivityWidget.cpp @@ -116,42 +116,39 @@ NetworkActivityWidget::fetchData() void NetworkActivityWidget::weeklyCharts( const QList& tracks ) { - QSharedPointer locker = QSharedPointer( new QMutexLocker( &m_retrieveMutex ) ); m_weeklyChartsModel = new PlaylistModel( ui->tracksViewLeft ); m_weeklyChartsModel->startLoading(); // Pipeline::instance()->resolve( tracks ); m_weeklyChartsModel->appendTracks( tracks ); m_weeklyChartsModel->finishLoading(); - checkDone( locker ); + checkDone(); } void NetworkActivityWidget::monthlyCharts( const QList& tracks ) { - QSharedPointer locker = QSharedPointer( new QMutexLocker( &m_retrieveMutex ) ); m_monthlyChartsModel = new PlaylistModel( ui->tracksViewLeft ); m_monthlyChartsModel->startLoading(); // Pipeline::instance()->resolve( tracks ); m_monthlyChartsModel->appendTracks( tracks ); m_monthlyChartsModel->finishLoading(); - checkDone( locker ); + checkDone(); } void NetworkActivityWidget::yearlyCharts( const QList& tracks ) { - QSharedPointer locker = QSharedPointer( new QMutexLocker( &m_retrieveMutex ) ); m_yearlyChartsModel = new PlaylistModel( ui->tracksViewLeft ); m_yearlyChartsModel->startLoading(); // Pipeline::instance()->resolve( tracks ); m_yearlyChartsModel->appendTracks( tracks ); m_yearlyChartsModel->finishLoading(); - checkDone( locker ); + checkDone(); } @@ -215,7 +212,7 @@ NetworkActivityWidget::actualFetchData() void -NetworkActivityWidget::checkDone( QSharedPointer ) +NetworkActivityWidget::checkDone() { if ( !m_weeklyChartsModel.isNull() && !m_yearlyChartsModel.isNull() && !m_monthlyChartsModel.isNull() ) { diff --git a/src/libtomahawk/widgets/NetworkActivityWidget.h b/src/libtomahawk/widgets/NetworkActivityWidget.h index 0bf85bc62..b4b55e7e3 100644 --- a/src/libtomahawk/widgets/NetworkActivityWidget.h +++ b/src/libtomahawk/widgets/NetworkActivityWidget.h @@ -61,9 +61,7 @@ private slots: private: void actualFetchData(); - void checkDone( QSharedPointer ); - - QMutex m_retrieveMutex; + void checkDone(); QSharedPointer ui; Tomahawk::playlistinterface_ptr m_playlistInterface;