From 9236da101e4917b04ae5b3b291684334961a959b Mon Sep 17 00:00:00 2001 From: Leo Franchi Date: Mon, 30 May 2011 13:42:11 -0400 Subject: [PATCH 1/3] Expire logplayback commands in the UI after 10minites, they are stale Fixes TWK-39 --- .../database/databasecommand_logplayback.cpp | 2 +- src/libtomahawk/source.cpp | 15 ++++++++++++++- src/libtomahawk/source.h | 2 ++ 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/libtomahawk/database/databasecommand_logplayback.cpp b/src/libtomahawk/database/databasecommand_logplayback.cpp index 3bdc40ef5..12ffa5c5e 100644 --- a/src/libtomahawk/database/databasecommand_logplayback.cpp +++ b/src/libtomahawk/database/databasecommand_logplayback.cpp @@ -45,7 +45,7 @@ DatabaseCommand_LogPlayback::postCommitHook() { emit trackPlayed( q ); } - else if ( m_action == Started ) + else if ( m_action == Started && QDateTime::fromTime_t( playtime() ).secsTo( QDateTime::currentDateTime() ) < 600 ) // if the play time is more than 10 minutes in the past, ignore { emit trackPlaying( q ); } diff --git a/src/libtomahawk/source.cpp b/src/libtomahawk/source.cpp index d601fcf8f..e852e0c83 100644 --- a/src/libtomahawk/source.cpp +++ b/src/libtomahawk/source.cpp @@ -24,7 +24,6 @@ #include "network/controlconnection.h" #include "database/databasecommand_addsource.h" #include "database/databasecommand_sourceoffline.h" -#include "database/databasecommand_logplayback.h" #include "database/database.h" #include @@ -50,6 +49,10 @@ Source::Source( int id, const QString& username ) m_isLocal = true; m_online = true; } + + m_currentTrackTimer.setInterval( 600000 ); // 10 minutes + m_currentTrackTimer.setSingleShot( true ); + connect( &m_currentTrackTimer, SIGNAL( timeout() ), this, SLOT( trackTimerFired() ) ); } @@ -278,4 +281,14 @@ Source::onPlaybackFinished( const Tomahawk::query_ptr& query ) { qDebug() << Q_FUNC_INFO << query->toString(); emit playbackFinished( query ); + + m_currentTrackTimer.start(); +} + +void +Source::trackTimerFired() +{ + m_currentTrack.clear(); + + emit stateChanged(); } diff --git a/src/libtomahawk/source.h b/src/libtomahawk/source.h index b1d9cc6f1..1179fd267 100644 --- a/src/libtomahawk/source.h +++ b/src/libtomahawk/source.h @@ -105,6 +105,7 @@ private slots: void onStateChanged( DBSyncConnection::State newstate, DBSyncConnection::State oldstate, const QString& info ); void onPlaybackStarted( const Tomahawk::query_ptr& query ); void onPlaybackFinished( const Tomahawk::query_ptr& query ); + void trackTimerFired(); private: bool m_isLocal; @@ -118,6 +119,7 @@ private: Tomahawk::query_ptr m_currentTrack; QString m_textStatus; + QTimer m_currentTrackTimer; ControlConnection* m_cc; From 2aab17ba8ed2615ea6869ebf5754728e85902fb0 Mon Sep 17 00:00:00 2001 From: Christian Muehlhaeuser Date: Mon, 30 May 2011 21:19:15 +0000 Subject: [PATCH 2/3] * Updated tomahawk.nsi, now depends on the vlc stuff being extracted to ../vlc/ --- admin/win/nsi/tomahawk.nsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/admin/win/nsi/tomahawk.nsi b/admin/win/nsi/tomahawk.nsi index dbed64660..a135b08d8 100644 --- a/admin/win/nsi/tomahawk.nsi +++ b/admin/win/nsi/tomahawk.nsi @@ -25,8 +25,8 @@ !define QT_DLL_PATH "${MING_BIN}" !define SQLITE_DLL_PATH "${MING_LIB}/qt4/plugins/sqldrivers" !define IMAGEFORMATS_DLL_PATH "${MING_LIB}/qt4/plugins/imageformats" -!define VLC_PATH "${MING_BIN}" -!define VLC_PLUGIN_PATH "${MING_LIB}\vlc\plugins" +!define VLC_PATH "${ROOT_PATH}\..\vlc" +!define VLC_PLUGIN_PATH "${VLC_PATH}\plugins" ;----------------------------------------------------------------------------- ; Increment installer revision number as part of this script. From 30323c2d8a2229920b574c0b6d0eec8b1fb55d6e Mon Sep 17 00:00:00 2001 From: Christopher Reichert Date: Sun, 29 May 2011 00:26:20 -0500 Subject: [PATCH 3/3] Shuffle Mode and Repeat mode are now stored on a playlist by playlist basis in Tomahawk.conf --- src/libtomahawk/playlist.cpp | 4 +++ src/libtomahawk/tomahawksettings.cpp | 32 +++++++++++++++++++++- src/libtomahawk/tomahawksettings.h | 8 ++++++ src/libtomahawk/viewmanager.cpp | 40 ++++++++++++++++++++++++++++ src/libtomahawk/viewmanager.h | 4 ++- src/tomahawkwindow.cpp | 1 - 6 files changed, 86 insertions(+), 3 deletions(-) diff --git a/src/libtomahawk/playlist.cpp b/src/libtomahawk/playlist.cpp index 8d12dd00e..d3e88a764 100644 --- a/src/libtomahawk/playlist.cpp +++ b/src/libtomahawk/playlist.cpp @@ -28,6 +28,7 @@ #include "database/databasecommand_deleteplaylist.h" #include "database/databasecommand_renameplaylist.h" +#include "tomahawksettings.h" #include "pipeline.h" #include "source.h" #include "sourcelist.h" @@ -219,6 +220,9 @@ Playlist::load( const QString& guid ) bool Playlist::remove( const playlist_ptr& playlist ) { + TomahawkSettings *s = TomahawkSettings::instance(); + s->removePlaylistSettings( playlist->guid() ); + DatabaseCommand_DeletePlaylist* cmd = new DatabaseCommand_DeletePlaylist( playlist->author(), playlist->guid() ); Database::instance()->enqueue( QSharedPointer(cmd) ); diff --git a/src/libtomahawk/tomahawksettings.cpp b/src/libtomahawk/tomahawksettings.cpp index a2751484a..0333eeb4f 100644 --- a/src/libtomahawk/tomahawksettings.cpp +++ b/src/libtomahawk/tomahawksettings.cpp @@ -26,6 +26,7 @@ #include #include #include "sip/SipHandler.h" +#include "playlistinterface.h" #define VERSION 3 @@ -187,7 +188,6 @@ TomahawkSettings::setWatchForChanges( bool watch ) setValue( "watchForChanges", watch ); } - void TomahawkSettings::setAcceptedLegalWarning( bool accept ) { @@ -381,6 +381,36 @@ TomahawkSettings::setPlaylistColumnSizes( const QString& playlistid, const QByte setValue( QString( "ui/playlist/%1/columnSizes" ).arg( playlistid ), state ); } +bool +TomahawkSettings::shuffleState( const QString& playlistid ) const +{ + return value( QString( "ui/playlist/%1/shuffleState" ).arg( playlistid )).toBool(); +} + +void +TomahawkSettings::setShuffleState( const QString& playlistid, bool state) +{ + setValue( QString( "ui/playlist/%1/shuffleState" ).arg( playlistid ), state ); +} + +void +TomahawkSettings::removePlaylistSettings( const QString& playlistid ) +{ + remove( QString( "ui/playlist/%1/shuffleState" ).arg( playlistid ) ); + remove( QString( "ui/playlist/%1/repeatMode" ).arg( playlistid ) ); +} + +void +TomahawkSettings::setRepeatMode( const QString& playlistid, PlaylistInterface::RepeatMode mode ) +{ + setValue( QString( "ui/playlist/%1/repeatMode" ).arg( playlistid ), (int)mode ); +} + +PlaylistInterface::RepeatMode +TomahawkSettings::repeatMode( const QString& playlistid ) +{ + return (PlaylistInterface::RepeatMode)value( QString( "ui/playlist/%1/repeatMode" ).arg( playlistid )).toInt(); +} QList TomahawkSettings::recentlyPlayedPlaylists() const diff --git a/src/libtomahawk/tomahawksettings.h b/src/libtomahawk/tomahawksettings.h index 90ce075c0..a127b8d05 100644 --- a/src/libtomahawk/tomahawksettings.h +++ b/src/libtomahawk/tomahawksettings.h @@ -68,6 +68,14 @@ public: QList recentlyPlayedPlaylists() const; QStringList recentlyPlayedPlaylistGuids( unsigned int amount = 0 ) const; void appendRecentlyPlayedPlaylist( const Tomahawk::playlist_ptr& playlist ); + + bool shuffleState( const QString& playlistid ) const; + void setShuffleState( const QString& playlistid, bool state ); + PlaylistInterface::RepeatMode repeatMode( const QString& playlistid ); + void setRepeatMode( const QString& playlistid, PlaylistInterface::RepeatMode mode); + + // remove shuffle state and repeat state + void removePlaylistSettings( const QString& playlistid ); /// SIP plugins // all plugins we know about. loaded, unloaded, enabled, disabled. diff --git a/src/libtomahawk/viewmanager.cpp b/src/libtomahawk/viewmanager.cpp index 6b9380aef..1fbd10fb9 100644 --- a/src/libtomahawk/viewmanager.cpp +++ b/src/libtomahawk/viewmanager.cpp @@ -142,6 +142,7 @@ ViewManager::ViewManager( QObject* parent ) ViewManager::~ViewManager() { + saveCurrentPlaylistSettings(); delete m_widget; } @@ -581,6 +582,9 @@ ViewManager::setPage( ViewPage* page, bool trackHistory ) if ( !page ) return; + // save the old playlist shuffle state in config before we change playlists + saveCurrentPlaylistSettings(); + unlinkPlaylist(); if ( !m_pageHistory.contains( page ) ) @@ -652,6 +656,24 @@ ViewManager::unlinkPlaylist() } } +void +ViewManager::saveCurrentPlaylistSettings() +{ + TomahawkSettings* s = TomahawkSettings::instance(); + Tomahawk::playlist_ptr pl = playlistForInterface( currentPlaylistInterface() ); + + if ( !pl.isNull() ) { + s->setShuffleState( pl->guid(), currentPlaylistInterface()->shuffled() ); + s->setRepeatMode( pl->guid(), currentPlaylistInterface()->repeatMode() ); + } else { + Tomahawk::dynplaylist_ptr dynPl = dynamicPlaylistForInterface( currentPlaylistInterface() ); + if ( !dynPl.isNull() ) { + s->setShuffleState( dynPl->guid(), currentPlaylistInterface()->shuffled() ); + s->setRepeatMode( dynPl->guid(), currentPlaylistInterface()->repeatMode() ); + } + } +} + void ViewManager::updateView() @@ -704,8 +726,26 @@ ViewManager::updateView() m_infobar->setCaption( currentPage()->title() ); m_infobar->setDescription( currentPage()->description() ); m_infobar->setPixmap( currentPage()->pixmap() ); + + // turn on shuffle/repeat mode for the new playlist view if specified in config + loadCurrentPlaylistSettings(); } +void +ViewManager::loadCurrentPlaylistSettings() +{ + TomahawkSettings* s = TomahawkSettings::instance(); + Tomahawk::playlist_ptr pl = playlistForInterface( currentPlaylistInterface() ); + if ( !pl.isNull() ) { + currentPlaylistInterface()->setShuffled( s->shuffleState( pl->guid() )); + currentPlaylistInterface()->setRepeatMode( s->repeatMode( pl->guid() )); + } else { + Tomahawk::dynplaylist_ptr dynPl = dynamicPlaylistForInterface( currentPlaylistInterface() ); + if ( !dynPl.isNull() ) { + currentPlaylistInterface()->setShuffled( s->shuffleState( dynPl->guid() )); + } + } +} void ViewManager::onWidgetDestroyed( QWidget* widget ) diff --git a/src/libtomahawk/viewmanager.h b/src/libtomahawk/viewmanager.h index 234e9c846..0dbd21e15 100644 --- a/src/libtomahawk/viewmanager.h +++ b/src/libtomahawk/viewmanager.h @@ -162,7 +162,9 @@ private: void setPage( Tomahawk::ViewPage* page, bool trackHistory = true ); void updateView(); void unlinkPlaylist(); - + void saveCurrentPlaylistSettings(); + void loadCurrentPlaylistSettings(); + Tomahawk::playlist_ptr playlistForInterface( PlaylistInterface* interface ) const; Tomahawk::dynplaylist_ptr dynamicPlaylistForInterface( PlaylistInterface* interface ) const; Tomahawk::collection_ptr collectionForInterface( PlaylistInterface* interface ) const; diff --git a/src/tomahawkwindow.cpp b/src/tomahawkwindow.cpp index 16d8fff53..13989b4d4 100644 --- a/src/tomahawkwindow.cpp +++ b/src/tomahawkwindow.cpp @@ -233,7 +233,6 @@ TomahawkWindow::loadSettings() restoreState( s->mainWindowState() ); if ( !s->mainWindowSplitterState().isEmpty() ) ui->splitter->restoreState( s->mainWindowSplitterState() ); - #ifdef QT_MAC_USE_COCOA if( workaround ) { // Make it visible again