mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-28 16:20:01 +02:00
Code Issues Releases Wiki Activity

* CreateIndex isn't the right place to connect signals.

Browse Source
This commit is contained in:
Christian Muehlhaeuser
2013-05-26 21:38:46 +02:00
committed by Michael Zanetti
parent 530d5402a1
commit 84faa1671c
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/libtomahawk/playlist/PlayableModel.cpp
View File

@@ -69,12 +69,6 @@ PlayableModel::~PlayableModel()
QModelIndex QModelIndex
PlayableModel::createIndex( int row, int column, PlayableItem* item ) const PlayableModel::createIndex( int row, int column, PlayableItem* item ) const
{ {
if ( item->query() )
{
connect( item->query().data(), SIGNAL( playableStateChanged( bool ) ), SLOT( onQueryBecamePlayable( bool ) ), Qt::UniqueConnection );
connect( item->query().data(), SIGNAL( resolvingFinished( bool ) ), SLOT( onQueryResolved( bool ) ), Qt::UniqueConnection );
}
return QAbstractItemModel::createIndex( row, column, item ); return QAbstractItemModel::createIndex( row, column, item );
} }
@@ -635,6 +629,11 @@ PlayableModel::insertInternal( const QList< T >& items, int row, const QList< To
{ {
plitem = new PlayableItem( item, m_rootItem, row + i ); plitem = new PlayableItem( item, m_rootItem, row + i );
plitem->index = createIndex( row + i, 0, plitem ); plitem->index = createIndex( row + i, 0, plitem );
if ( item->query() )
{
connect( item->query().data(), SIGNAL( playableStateChanged( bool ) ), SLOT( onQueryBecamePlayable( bool ) ), Qt::UniqueConnection );
connect( item->query().data(), SIGNAL( resolvingFinished( bool ) ), SLOT( onQueryResolved( bool ) ), Qt::UniqueConnection );
}
if ( logs.count() > i ) if ( logs.count() > i )
plitem->setPlaybackLog( logs.at( i ) ); plitem->setPlaybackLog( logs.at( i ) );