From 85ef6dfdb8d81a5efb571f9ea59a03ea36285a31 Mon Sep 17 00:00:00 2001 From: Dominik Schmidt Date: Sat, 3 Nov 2012 02:37:20 +0100 Subject: [PATCH] Reorder includes in the app --- src/AclRegistryImpl.cpp | 5 ++-- src/AclRegistryImpl.h | 12 ++++---- src/AudioControls.cpp | 10 +++---- src/AudioControls.h | 8 +++--- src/CMakeLists.txt | 2 +- src/DiagnosticsDialog.cpp | 16 +++++------ src/LoadXSPFDialog.cpp | 3 +- src/ResolverConfigDelegate.cpp | 5 ++-- src/Scrobbler.cpp | 21 +++++++------- src/SettingsDialog.cpp | 30 ++++++++++---------- src/SettingsDialog.h | 10 +++---- src/SocialWidget.cpp | 15 +++++----- src/SocialWidget.h | 6 ++-- src/TomahawkApp.cpp | 35 ++++++++++++----------- src/TomahawkApp.h | 24 ++++++++-------- src/TomahawkTrayIcon.cpp | 7 ++--- src/TomahawkTrayIcon.h | 8 +++--- src/TomahawkWindow.cpp | 39 +++++++++++++------------- src/TomahawkWindow.h | 11 ++++---- src/sourcetree/AnimationHelper.cpp | 2 +- src/sourcetree/SourceDelegate.cpp | 11 ++++---- src/sourcetree/SourceDelegate.h | 4 +-- src/sourcetree/SourceTreeView.cpp | 22 +++++++-------- src/sourcetree/SourceTreeView.h | 4 +-- src/sourcetree/SourcesModel.cpp | 10 +++---- src/sourcetree/SourcesModel.h | 5 ++-- src/sourcetree/SourcesProxyModel.cpp | 5 ++-- src/sourcetree/SourcesProxyModel.h | 2 +- src/sourcetree/items/CategoryItems.cpp | 5 ++-- src/sourcetree/items/LovedTracksItem.h | 4 +-- src/sourcetree/items/PlaylistItems.cpp | 6 ++-- src/sourcetree/items/SourceTreeItem.h | 4 +-- src/web/Api_v1.cpp | 6 ++-- src/widgets/AccountsPopupWidget.cpp | 8 +++--- src/widgets/ContainedMenuButton.cpp | 2 +- src/widgets/ContainedMenuButton.h | 4 +-- 36 files changed, 186 insertions(+), 185 deletions(-) diff --git a/src/AclRegistryImpl.cpp b/src/AclRegistryImpl.cpp index e20585930..3c2ba2f7b 100644 --- a/src/AclRegistryImpl.cpp +++ b/src/AclRegistryImpl.cpp @@ -19,8 +19,6 @@ #include "AclRegistryImpl.h" -#include -#include #include "TomahawkSettings.h" #include "TomahawkApp.h" @@ -36,6 +34,9 @@ #include "utils/Logger.h" +#include +#include + ACLRegistryImpl::ACLRegistryImpl( QObject* parent ) : ACLRegistry( parent ) diff --git a/src/AclRegistryImpl.h b/src/AclRegistryImpl.h index 3641fb8bc..85b617bac 100644 --- a/src/AclRegistryImpl.h +++ b/src/AclRegistryImpl.h @@ -20,6 +20,10 @@ #ifndef TOMAHAWK_ACLREGISTRYIMPL_H #define TOMAHAWK_ACLREGISTRYIMPL_H +#include "AclRegistry.h" +#include "HeadlessCheck.h" +#include "DllMacro.h" + #include #include #include @@ -30,10 +34,6 @@ #include #include -#include "AclRegistry.h" -#include "HeadlessCheck.h" -#include "DllMacro.h" - class ACLJobItem; class ACLRegistryImpl : public ACLRegistry @@ -59,11 +59,11 @@ public slots: **/ virtual ACLRegistry::ACL isAuthorizedUser( const QString &dbid, const QString &username, ACLRegistry::ACL globalType = ACLRegistry::NotFound, bool skipEmission = false ); virtual void wipeEntries(); - + protected: virtual void load(); virtual void save(); - + #ifndef ENABLE_HEADLESS void getUserDecision( ACLRegistry::User user, const QString &username ); diff --git a/src/AudioControls.cpp b/src/AudioControls.cpp index 275ed8bf6..e22017efe 100644 --- a/src/AudioControls.cpp +++ b/src/AudioControls.cpp @@ -20,11 +20,6 @@ #include "AudioControls.h" #include "ui_AudioControls.h" -#include -#include -#include -#include - #include "audio/AudioEngine.h" #include "playlist/PlaylistView.h" #include "database/Database.h" @@ -38,6 +33,11 @@ #include "ViewManager.h" #include "Source.h" +#include +#include +#include +#include + const static int ALLOWED_MAX_DIVERSION = 300; using namespace Tomahawk; diff --git a/src/AudioControls.h b/src/AudioControls.h index 35a0aa998..ba0207b88 100644 --- a/src/AudioControls.h +++ b/src/AudioControls.h @@ -20,14 +20,14 @@ #ifndef AUDIOCONTROLS_H #define AUDIOCONTROLS_H -#include -#include -#include - #include "Result.h" #include "PlaylistInterface.h" #include "Query.h" +#include +#include +#include + class QDropEvent; class QDragEnterEvent; class QDragMoveEvent; diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 88e83cc63..b5fb4554f 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -73,7 +73,7 @@ SET( tomahawkSourcesGui ${tomahawkSourcesGui} TomahawkWindow.cpp LoadXSPFDialog.cpp SocialWidget.cpp - + widgets/ContainedMenuButton.cpp widgets/AccountListWidget.cpp widgets/AccountModelFactoryProxy.cpp diff --git a/src/DiagnosticsDialog.cpp b/src/DiagnosticsDialog.cpp index 9e63ccce6..eedf4f191 100644 --- a/src/DiagnosticsDialog.cpp +++ b/src/DiagnosticsDialog.cpp @@ -23,6 +23,14 @@ #include "config.h" #include "TomahawkVersion.h" +#include "SourceList.h" + +#include "accounts/AccountManager.h" +#include "network/Servent.h" +#include "sip/SipHandler.h" +#include "utils/TomahawkUtilsGui.h" +#include "utils/Logger.h" + #include #include #include @@ -31,14 +39,6 @@ #include #include -#include "accounts/AccountManager.h" -#include "network/Servent.h" -#include "SourceList.h" - -#include "sip/SipHandler.h" -#include "utils/TomahawkUtilsGui.h" -#include "utils/Logger.h" - DiagnosticsDialog::DiagnosticsDialog( QWidget *parent ) : QDialog( parent ) diff --git a/src/LoadXSPFDialog.cpp b/src/LoadXSPFDialog.cpp index eaa2e16b1..dcac669db 100644 --- a/src/LoadXSPFDialog.cpp +++ b/src/LoadXSPFDialog.cpp @@ -17,10 +17,11 @@ */ #include "LoadXSPFDialog.h" +#include "ui_LoadXSPFDialog.h" + #include "TomahawkSettings.h" #include "Source.h" -#include "ui_LoadXSPFDialog.h" #include LoadXSPFDialog::LoadXSPFDialog( QWidget* parent, Qt::WindowFlags f ) diff --git a/src/ResolverConfigDelegate.cpp b/src/ResolverConfigDelegate.cpp index 70236cf02..a40a5812d 100644 --- a/src/ResolverConfigDelegate.cpp +++ b/src/ResolverConfigDelegate.cpp @@ -18,15 +18,14 @@ #include "ResolverConfigDelegate.h" -// #include "resolversmodel.h" #include "ExternalResolverGui.h" +#include "utils/Logger.h" + #include #include #include -#include "utils/Logger.h" - #define PADDING 4 #define ICONSIZE 24 diff --git a/src/Scrobbler.cpp b/src/Scrobbler.cpp index 6e1b77bc3..c119c89be 100644 --- a/src/Scrobbler.cpp +++ b/src/Scrobbler.cpp @@ -19,20 +19,21 @@ #include "Scrobbler.h" +#include "Artist.h" +#include "Album.h" +#include "Source.h" +#include "Typedefs.h" +#include "TomahawkSettings.h" + +#include "audio/AudioEngine.h" +#include "infosystem/InfoSystem.h" + +#include "utils/Logger.h" + #include #include #include -#include "Artist.h" -#include "Album.h" -#include "Typedefs.h" -#include "audio/AudioEngine.h" -#include "TomahawkSettings.h" -#include "infosystem/InfoSystem.h" -#include "Source.h" - -#include "utils/Logger.h" - static QString s_scInfoIdentifier = QString( "SCROBBLER" ); diff --git a/src/SettingsDialog.cpp b/src/SettingsDialog.cpp index a217da567..720b55cea 100644 --- a/src/SettingsDialog.cpp +++ b/src/SettingsDialog.cpp @@ -20,16 +20,12 @@ */ #include "SettingsDialog.h" -#include "config.h" +#include "ui_ProxyDialog.h" +#include "ui_Settings_Accounts.h" +#include "ui_Settings_Collection.h" +#include "ui_Settings_Advanced.h" -#include -#include -#include -#include -#include -#include -#include -#include +#include "config.h" #include "AtticaManager.h" #include "AclRegistry.h" @@ -48,18 +44,22 @@ #include "accounts/AccountModel.h" #include "accounts/Account.h" #include "accounts/AccountManager.h" -#include -#include +#include "accounts/AccountModelFilterProxy.h" +#include "accounts/ResolverAccount.h" #include "utils/Logger.h" #include "accounts/AccountFactoryWrapper.h" #include "accounts/spotify/SpotifyAccount.h" #include "thirdparty/Qocoa/qtoolbartabdialog.h" #include "thirdparty/Qocoa/qbutton.h" -#include "ui_ProxyDialog.h" -#include "ui_Settings_Accounts.h" -#include "ui_Settings_Collection.h" -#include "ui_Settings_Advanced.h" +#include +#include +#include +#include +#include +#include +#include +#include using namespace Tomahawk; using namespace Accounts; diff --git a/src/SettingsDialog.h b/src/SettingsDialog.h index 885997fde..8826af8e4 100644 --- a/src/SettingsDialog.h +++ b/src/SettingsDialog.h @@ -22,12 +22,10 @@ #ifndef SETTINGSDIALOG_H #define SETTINGSDIALOG_H -#include -#include -#include -#include - -#include "config.h" +#include +#include +#include +#include class AnimatedSpinner; class QListWidgetItem; diff --git a/src/SocialWidget.cpp b/src/SocialWidget.cpp index 39f73f938..fb1cc5ece 100644 --- a/src/SocialWidget.cpp +++ b/src/SocialWidget.cpp @@ -20,15 +20,16 @@ #include "SocialWidget.h" #include "ui_SocialWidget.h" +#include "GlobalActionManager.h" +#include "Source.h" + +#include "utils/TomahawkUtilsGui.h" +#include "utils/Logger.h" + #include #include #include -#include "GlobalActionManager.h" -#include "utils/TomahawkUtilsGui.h" -#include "utils/Logger.h" -#include "Source.h" - #define ARROW_HEIGHT 6 @@ -67,7 +68,7 @@ SocialWidget::SocialWidget( QWidget* parent ) ui->buttonBox->button( QDialogButtonBox::Cancel )->setIcon( QIcon( RESPATH "images/cancel.png" ) ); ui->textEdit->setStyleSheet( "border: 1px solid " + TomahawkUtils::Colors::BORDER_LINE.name() ); - + m_parent->installEventFilter( this ); connect( ui->buttonBox, SIGNAL( accepted() ), SLOT( accept() ) ); @@ -202,7 +203,7 @@ void SocialWidget::accept() { tDebug() << "Sharing social link!"; - + QVariantMap shareInfo; Tomahawk::InfoSystem::InfoStringHash trackInfo; diff --git a/src/SocialWidget.h b/src/SocialWidget.h index 63f5bef15..876ec3efc 100644 --- a/src/SocialWidget.h +++ b/src/SocialWidget.h @@ -20,12 +20,12 @@ #ifndef SOCIALWIDGET_H #define SOCIALWIDGET_H +#include "Query.h" + #include #include #include -#include "Query.h" - namespace Ui { class SocialWidget; @@ -64,7 +64,7 @@ private slots: void accept(); void onChanged(); void onShortLinkReady( const QUrl& longUrl, const QUrl& shortUrl, const QVariant& callbackObj ); - + void onGeometryUpdate(); private: diff --git a/src/TomahawkApp.cpp b/src/TomahawkApp.cpp index f55a13b98..474b5cdb1 100644 --- a/src/TomahawkApp.cpp +++ b/src/TomahawkApp.cpp @@ -21,18 +21,6 @@ #include "TomahawkApp.h" #include "TomahawkVersion.h" - -#include - -#include -#include -#include -#include -#include -#include -#include -#include - #include "AclRegistryImpl.h" #include "Album.h" #include "Artist.h" @@ -71,8 +59,6 @@ #include "accounts/spotify/SpotifyPlaylistUpdater.h" #include "utils/TomahawkCache.h" -#include "config.h" - #ifndef ENABLE_HEADLESS #include "resolvers/QtScriptResolver.h" #include "resolvers/ScriptResolver.h" @@ -81,9 +67,14 @@ #include "TomahawkWindow.h" #include "SettingsDialog.h" #include "ActionCollection.h" - #include #include "widgets/HeaderLabel.h" - #include + #include "TomahawkSettingsGui.h" +#endif + +#include "config.h" + +#ifndef ENABLE_HEADLESS + #include #endif #ifdef Q_WS_MAC @@ -93,6 +84,18 @@ #include #endif +#include +#include +#include +#include +#include +#include +#include +#include + +#include + + const char* enApiSecret = "BNvTzfthHr/d1eNhHLvL1Jo="; void diff --git a/src/TomahawkApp.h b/src/TomahawkApp.h index 74cfffc11..28247d79d 100644 --- a/src/TomahawkApp.h +++ b/src/TomahawkApp.h @@ -23,23 +23,23 @@ #define APP TomahawkApp::instance() -#include "HeadlessCheck.h" -#include "config.h" - -#include -#include -#include -#include -#include - -#include "QxtHttpServerConnector" -#include "QxtHttpSessionManager" - #include "mac/TomahawkApp_Mac.h" // for PlatforInterface #include "Typedefs.h" #include "utils/TomahawkUtils.h" #include "thirdparty/kdsingleapplicationguard/kdsingleapplicationguard.h" +#include "HeadlessCheck.h" +#include "config.h" + +#include "QxtHttpServerConnector" +#include "QxtHttpSessionManager" + +#include +#include +#include +#include +#include + class AudioEngine; class Database; class ScanManager; diff --git a/src/TomahawkTrayIcon.cpp b/src/TomahawkTrayIcon.cpp index edcf2483c..36a416187 100644 --- a/src/TomahawkTrayIcon.cpp +++ b/src/TomahawkTrayIcon.cpp @@ -19,21 +19,18 @@ #include "TomahawkTrayIcon.h" -#include - #include "Artist.h" - #include "audio/AudioEngine.h" #include "TomahawkApp.h" #include "TomahawkWindow.h" #include "Query.h" #include "Source.h" #include "Collection.h" - +#include "ActionCollection.h" #include "utils/Logger.h" #include "utils/TomahawkUtilsGui.h" -#include +#include TomahawkTrayIcon::TomahawkTrayIcon( QObject* parent ) : QSystemTrayIcon( parent ) diff --git a/src/TomahawkTrayIcon.h b/src/TomahawkTrayIcon.h index 31984492b..15aee17cd 100644 --- a/src/TomahawkTrayIcon.h +++ b/src/TomahawkTrayIcon.h @@ -20,9 +20,9 @@ #ifndef TOMAHAWK_TRAYICON_H #define TOMAHAWK_TRAYICON_H -#include -#include -#include +#include +#include +#include #include "Result.h" @@ -48,7 +48,7 @@ private slots: void onPlay(); void onStop(); void onResume(); - + void onSocialActionsLoaded(); void onStopContinueAfterTrackChanged(); void stopContinueAfterTrackActionTriggered(); diff --git a/src/TomahawkWindow.cpp b/src/TomahawkWindow.cpp index 6fa6dda60..a886eddfd 100644 --- a/src/TomahawkWindow.cpp +++ b/src/TomahawkWindow.cpp @@ -22,24 +22,6 @@ #include "TomahawkWindow.h" #include "ui_TomahawkWindow.h" -#include "config.h" - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - #include "accounts/AccountManager.h" #include "sourcetree/SourceTreeView.h" #include "network/Servent.h" @@ -77,6 +59,25 @@ #include "TomahawkApp.h" #include "LoadXSPFDialog.h" #include "widgets/ContainedMenuButton.h" +#include "utils/Logger.h" + +#include "config.h" + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #if defined( Q_WS_WIN ) && defined( WITH_QtSparkle ) #include @@ -85,8 +86,6 @@ #endif #endif -#include "utils/Logger.h" - using namespace Tomahawk; using namespace Accounts; diff --git a/src/TomahawkWindow.h b/src/TomahawkWindow.h index 9ffe83fd8..99969c30b 100644 --- a/src/TomahawkWindow.h +++ b/src/TomahawkWindow.h @@ -22,6 +22,12 @@ #ifndef TOMAHAWKWINDOW_H #define TOMAHAWKWINDOW_H +#include "Result.h" +#include "audio/AudioEngine.h" +#include "utils/XspfLoader.h" + +#include "config.h" + #include #include #include @@ -29,11 +35,6 @@ #include #include -#include "config.h" -#include "Result.h" -#include "audio/AudioEngine.h" -#include "utils/XspfLoader.h" - #ifdef Q_OS_WIN #include #endif diff --git a/src/sourcetree/AnimationHelper.cpp b/src/sourcetree/AnimationHelper.cpp index f84ad3998..b761580df 100644 --- a/src/sourcetree/AnimationHelper.cpp +++ b/src/sourcetree/AnimationHelper.cpp @@ -19,7 +19,7 @@ #include "AnimationHelper.h" -#include "QDebug" +#include AnimationHelper::AnimationHelper( const QModelIndex& index, QObject *parent ) :QObject( parent ) diff --git a/src/sourcetree/SourceDelegate.cpp b/src/sourcetree/SourceDelegate.cpp index 198f65de1..3569c0582 100644 --- a/src/sourcetree/SourceDelegate.cpp +++ b/src/sourcetree/SourceDelegate.cpp @@ -31,12 +31,13 @@ #include "AnimationHelper.h" #include "Source.h" #include "TomahawkSettings.h" +#include "audio/AudioEngine.h" +#include "ActionCollection.h" + +#include +#include +#include -#include -#include -#include -#include