Use direct implementation and do not call virtuals in the constructor

src/libtomahawk/playlist/ColumnViewPreviewWidget.cpp

@@ -38,7 +38,7 @@ using namespace Tomahawk;
 ColumnViewPreviewWidget::ColumnViewPreviewWidget( ColumnView* parent )
     : QWidget( parent )
 {
-    setVisible( false );
+    QWidget::setVisible( false );
 
     QBoxLayout* mainLayout = new QVBoxLayout;
     setLayout( mainLayout );

src/libtomahawk/playlist/InboxView.cpp

@@ -32,7 +32,7 @@ InboxView::InboxView( QWidget* parent ) :
     proxyModel()->setStyle( PlayableProxyModel::Large );
     setEmptyTip( tr( "No listening suggestions here." ) );
 
-    setGuid( "inbox" );
+    TrackView::setGuid( "inbox" );
     setHeaderHidden( true );
     setUniformRowHeights( false );
     setIndentation( 0 );

src/libtomahawk/playlist/PlayableProxyModel.cpp

@@ -46,7 +46,7 @@ PlayableProxyModel::PlayableProxyModel( QObject* parent )
     setSortCaseSensitivity( Qt::CaseInsensitive );
     setDynamicSortFilter( true );
 
-    setSourcePlayableModel( 0 );
+    PlayableProxyModel::setSourcePlayableModel( NULL );
 
     m_headerStyle[ Large ]      << PlayableModel::Name;
     m_headerStyle[ Detailed ]   << PlayableModel::Artist << PlayableModel::Track << PlayableModel::Composer << PlayableModel::Album << PlayableModel::AlbumPos << PlayableModel::Duration << PlayableModel::Bitrate << PlayableModel::Age << PlayableModel::Year << PlayableModel::Filesize << PlayableModel::Origin << PlayableModel::Score;

src/libtomahawk/playlist/TreeModel.cpp

@@ -42,8 +42,11 @@ TreeModel::TreeModel( QObject* parent )
     : PlayableModel( parent )
     , m_mode( DatabaseMode )
 {
-    setIcon( TomahawkUtils::tinted( TomahawkUtils::defaultPixmap( TomahawkUtils::DefaultCollection, TomahawkUtils::Original,
+    PlayableModel::setIcon( TomahawkUtils::tinted( TomahawkUtils::defaultPixmap(
-                                           /*big enough for the ViewPage header on retina*/ QSize( 256, 256 ) ), Qt::white ) );
+                                                       TomahawkUtils::DefaultCollection,
+                                                       TomahawkUtils::Original,
+                                                       // big enough for the ViewPage header on retina
+                                                       QSize( 256, 256 ) ), Qt::white ) );
 
     connect( AudioEngine::instance(), SIGNAL( started( Tomahawk::result_ptr ) ), SLOT( onPlaybackStarted( Tomahawk::result_ptr ) ), Qt::DirectConnection );
     connect( AudioEngine::instance(), SIGNAL( stopped() ), SLOT( onPlaybackStopped() ), Qt::DirectConnection );

src/libtomahawk/resolvers/ScriptCollection.cpp

@@ -39,7 +39,7 @@ ScriptCollection::ScriptCollection( const source_ptr& source,
     , m_trackCount( -1 ) //null value
 {
     Q_ASSERT( resolver );
-    qDebug() << Q_FUNC_INFO << resolver->name() << name();
+    qDebug() << Q_FUNC_INFO << resolver->name() << Collection::name();
 
     m_resolver = resolver;
 

src/libtomahawk/widgets/BackgroundWidget.cpp

@@ -33,7 +33,7 @@ BackgroundWidget::BackgroundWidget( QWidget* parent )
     : QWidget( parent )
 {
     setAutoFillBackground( false );
-    setBackgroundColor( QColor( "#333333" ) );
+    BackgroundWidget::setBackgroundColor( QColor( "#333333" ) );
 }
 
 

src/libtomahawk/widgets/ToggleButton.cpp

@@ -36,7 +36,7 @@ ToggleButton::ToggleButton( QWidget* parent )
     f.setPointSize( TomahawkUtils::defaultFontSize() + 1 );
 
     setFont( f );
-    setFixedHeight( sizeHint().height() + 8 );
+    setFixedHeight( QLabel::sizeHint().height() + 8 );
 
     setCursor( Qt::PointingHandCursor );
 }

src/libtomahawk/widgets/searchlineedit/ClearButton.cpp

@@ -37,7 +37,7 @@ ClearButton::ClearButton(QWidget *parent)
     setFocusPolicy(Qt::NoFocus);
     setToolTip(tr("Clear"));
     setMinimumSize(22, 22);
-    setVisible(false);
+    QWidget::setVisible(false);
 
 #if QT_VERSION >= 0x040600
     // First check for a style icon, current KDE provides one

src/libtomahawk/widgets/searchlineedit/SearchButton.cpp

@@ -30,7 +30,7 @@ SearchButton::SearchButton(QWidget *parent)
 {
     setFocusPolicy(Qt::NoFocus);
     setCursor(Qt::ArrowCursor);
-    setMinimumSize(sizeHint());
+    setMinimumSize(SearchButton::sizeHint());
 }
 
 QSize SearchButton::sizeHint() const

src/tomahawk/AclRegistryImpl.cpp

@@ -40,13 +40,13 @@ ACLRegistryImpl::ACLRegistryImpl( QObject* parent )
     , m_jobCount( 0 )
 {
     ACLRegistry::setInstance( this );
-    load();
+    ACLRegistryImpl::load();
 }
 
 
 ACLRegistryImpl::~ACLRegistryImpl()
 {
-    save();
+    ACLRegistryImpl::save();
 }