From 9505e433bc901b4e466792518ddf28010e3fb7f1 Mon Sep 17 00:00:00 2001
From: Leo Franchi <lfranchi@kde.org>
Date: Tue, 26 Jun 2012 18:21:46 -0400
Subject: [PATCH] Looks like paths with spaces need to be esaped everywhere
 with QProcess...

---
 src/libtomahawk/resolvers/ScriptResolver.cpp | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/libtomahawk/resolvers/ScriptResolver.cpp b/src/libtomahawk/resolvers/ScriptResolver.cpp
index 130ac24b2..8b82cf437 100644
--- a/src/libtomahawk/resolvers/ScriptResolver.cpp
+++ b/src/libtomahawk/resolvers/ScriptResolver.cpp
@@ -423,10 +423,11 @@ ScriptResolver::startProcess()
         m_error = Tomahawk::ExternalResolver::NoError;
     }
 
-    QFileInfo fi( filePath() );
+    const QFileInfo fi( filePath() );
 
     QString interpreter;
-    QString runPath = filePath();
+    // have to enclose in quotes if path contains spaces...
+    const QString runPath = QString( "\"%1\"" ).arg( filePath() );
 
     QFile file( filePath() );
     file.setPermissions( file.permissions() | QFile::ExeOwner | QFile::ExeGroup | QFile::ExeOther );
@@ -453,11 +454,6 @@ ScriptResolver::startProcess()
             interpreter = QString( "\"%1\"" ).arg(QString::fromUtf16((const ushort *) path));
         }
     }
-    else
-    {
-        // have to enclose in quotes if path contains spaces on windows...
-        runPath = QString( "\"%1\"" ).arg( filePath() );
-    }
 #endif // Q_OS_WIN
 
     if ( interpreter.isEmpty() )