From 99a298edb5e864f8eca6b651900499e57602333d Mon Sep 17 00:00:00 2001 From: Leo Franchi Date: Sun, 14 Aug 2011 14:17:06 -0400 Subject: [PATCH] Manually encode "'" as %27 for QUrls which is legal and makes more apps happy --- src/libtomahawk/globalactionmanager.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/libtomahawk/globalactionmanager.cpp b/src/libtomahawk/globalactionmanager.cpp index 1a797ee3a..c4abcaa99 100644 --- a/src/libtomahawk/globalactionmanager.cpp +++ b/src/libtomahawk/globalactionmanager.cpp @@ -142,7 +142,9 @@ GlobalActionManager::copyPlaylistToClipboard( const dynplaylist_ptr& playlist ) } QClipboard* cb = QApplication::clipboard(); - cb->setText( link.toEncoded() ); + QByteArray data = link.toEncoded(); + data.replace( "'", "%27" ); // QUrl doesn't encode ', which it doesn't have to. Some apps don't like ' though, and want %27. Both are valid. + cb->setText( data ); return link.toString(); } @@ -178,7 +180,9 @@ void GlobalActionManager::copyToClipboard( const query_ptr& query ) const { QClipboard* cb = QApplication::clipboard(); - cb->setText( openLinkFromQuery( query ).toEncoded() ); + QByteArray data = openLinkFromQuery( query ).toEncoded(); + data.replace( "'", "%27" ); // QUrl doesn't encode ', which it doesn't have to. Some apps don't like ' though, and want %27. Both are valid. + cb->setText( data ); }