From f198cf51cc1ebaa33477d5bbe1b012d195a22f76 Mon Sep 17 00:00:00 2001
From: Jeff Mitchell <tomahawk@jefferai.org>
Date: Mon, 28 Mar 2011 11:12:28 -0400
Subject: [PATCH] Properly use the configured port number

---
 ChangeLog                         | 4 ++++
 src/libtomahawk/network/servent.h | 4 +---
 src/tomahawkapp.cpp               | 5 +++--
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 45f0b1d5c..89a441c90 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+Version 0.0.3:
+    * Properly honor the chosen port number if a static host and port are
+      marked as preferred.
+
 Version 0.0.2:
     * Don't reconnect to Jabber if the settings dialog is closed successfully
       but the Jabber settings haven't changed.
diff --git a/src/libtomahawk/network/servent.h b/src/libtomahawk/network/servent.h
index f88581445..21ef28d27 100644
--- a/src/libtomahawk/network/servent.h
+++ b/src/libtomahawk/network/servent.h
@@ -19,8 +19,6 @@
 #ifndef SERVENT_H
 #define SERVENT_H
 
-// port for servent to listen on
-#define DEFAULT_LISTEN_PORT 50210
 // time before new connection terminates if no auth received
 #define AUTH_TIMEOUT 180000
 
@@ -91,7 +89,7 @@ public:
     explicit Servent( QObject* parent = 0 );
     virtual ~Servent();
 
-    bool startListening( QHostAddress ha, bool upnp = false, int port = DEFAULT_LISTEN_PORT );
+    bool startListening( QHostAddress ha, bool upnp, int port );
 
     int port() const { return m_port; }
 
diff --git a/src/tomahawkapp.cpp b/src/tomahawkapp.cpp
index eb178ede0..7a94f11a0 100644
--- a/src/tomahawkapp.cpp
+++ b/src/tomahawkapp.cpp
@@ -463,8 +463,9 @@ TomahawkApp::initLocalCollection()
 void
 TomahawkApp::startServent()
 {
-    bool upnp = !arguments().contains( "--noupnp" ) && TomahawkSettings::instance()->value( "network/upnp", true ).toBool();
-    if ( !Servent::instance()->startListening( QHostAddress( QHostAddress::Any ), upnp ) )
+    bool upnp = !arguments().contains( "--noupnp" ) && TomahawkSettings::instance()->value( "network/upnp", true ).toBool() && !TomahawkSettings::instance()->preferStaticHostPort();
+    int port = TomahawkSettings::instance()->externalPort();
+    if ( !Servent::instance()->startListening( QHostAddress( QHostAddress::Any ), upnp, port ) )
     {
         qDebug() << "Failed to start listening with servent";
         exit( 1 );