From a31f4c770adf5e6b764061c643bbf34d0ceb8418 Mon Sep 17 00:00:00 2001 From: Christian Muehlhaeuser Date: Sat, 8 Jun 2013 14:24:37 +0200 Subject: [PATCH] * Moved artist / track labels out of the PlayableCover. --- .../widgets/infowidgets/ArtistInfoWidget.cpp | 6 +- .../widgets/infowidgets/ArtistInfoWidget.ui | 70 ++++++++++++--- .../widgets/infowidgets/TrackInfoWidget.cpp | 12 ++- .../widgets/infowidgets/TrackInfoWidget.ui | 87 ++++++++++++++++--- 4 files changed, 146 insertions(+), 29 deletions(-) diff --git a/src/libtomahawk/widgets/infowidgets/ArtistInfoWidget.cpp b/src/libtomahawk/widgets/infowidgets/ArtistInfoWidget.cpp index ec90ea859..953cf2515 100644 --- a/src/libtomahawk/widgets/infowidgets/ArtistInfoWidget.cpp +++ b/src/libtomahawk/widgets/infowidgets/ArtistInfoWidget.cpp @@ -111,7 +111,7 @@ ArtistInfoWidget::ArtistInfoWidget( const Tomahawk::artist_ptr& artist, QWidget* m_pixmap = TomahawkUtils::defaultPixmap( TomahawkUtils::DefaultArtistImage, TomahawkUtils::Original, QSize( 48, 48 ) ); ui->cover->setPixmap( TomahawkUtils::defaultPixmap( TomahawkUtils::DefaultArtistImage, TomahawkUtils::Grid, ui->cover->size() ) ); - ui->cover->setShowText( true ); + ui->cover->setShowText( false ); QFont f = font(); f.setPointSize( f.pointSize() + 3 ); @@ -127,6 +127,7 @@ ArtistInfoWidget::ArtistInfoWidget( const Tomahawk::artist_ptr& artist, QWidget* p.setColor( QPalette::Text, Qt::gray ); ui->biography->setPalette( p ); + ui->artistLabel->setPalette( p ); ui->label->setPalette( p ); ui->label_2->setPalette( p ); ui->label_3->setPalette( p ); @@ -245,7 +246,7 @@ ArtistInfoWidget::jumpToCurrentTrack() void ArtistInfoWidget::load( const artist_ptr& artist ) { - if ( !m_artist.isNull() ) + if ( m_artist ) { disconnect( m_artist.data(), SIGNAL( updated() ), this, SLOT( onArtistImageUpdated() ) ); disconnect( m_artist.data(), SIGNAL( similarArtistsLoaded() ), this, SLOT( onSimilarArtistsLoaded() ) ); @@ -258,6 +259,7 @@ ArtistInfoWidget::load( const artist_ptr& artist ) m_artist = artist; m_title = artist->name(); + ui->artistLabel->setText( artist->name() ); connect( m_artist.data(), SIGNAL( biographyLoaded() ), SLOT( onBiographyLoaded() ) ); connect( m_artist.data(), SIGNAL( similarArtistsLoaded() ), SLOT( onSimilarArtistsLoaded() ) ); diff --git a/src/libtomahawk/widgets/infowidgets/ArtistInfoWidget.ui b/src/libtomahawk/widgets/infowidgets/ArtistInfoWidget.ui index fa6e23199..829ca723e 100644 --- a/src/libtomahawk/widgets/infowidgets/ArtistInfoWidget.ui +++ b/src/libtomahawk/widgets/infowidgets/ArtistInfoWidget.ui @@ -51,23 +51,65 @@ - - - - 0 - 0 - + + + 8 - - - 0 - 240 - + + 0 - - Qt::ScrollBarAlwaysOff + + 8 - + + 0 + + + 0 + + + + + + 0 + 0 + + + + + 18 + 75 + true + + + + ArtistName + + + 2 + + + + + + + + 0 + 0 + + + + + 0 + 220 + + + + Qt::ScrollBarAlwaysOff + + + + diff --git a/src/libtomahawk/widgets/infowidgets/TrackInfoWidget.cpp b/src/libtomahawk/widgets/infowidgets/TrackInfoWidget.cpp index affd54f7d..1edad069e 100644 --- a/src/libtomahawk/widgets/infowidgets/TrackInfoWidget.cpp +++ b/src/libtomahawk/widgets/infowidgets/TrackInfoWidget.cpp @@ -44,6 +44,11 @@ TrackInfoWidget::TrackInfoWidget( const Tomahawk::query_ptr& query, QWidget* par QWidget* widget = new QWidget; ui->setupUi( widget ); + ui->artistLabel->setContentsMargins( 6, 2, 6, 2 ); + ui->artistLabel->setElideMode( Qt::ElideMiddle ); + ui->artistLabel->setType( QueryLabel::Artist ); + connect( ui->artistLabel, SIGNAL( clickedArtist() ), SLOT( onArtistClicked() ) ); + ui->statsLabel->setStyleSheet( "QLabel { background-image:url(); border: 2px solid #dddddd; background-color: #faf9f9; border-radius: 4px; padding: 12px; }" ); ui->lyricsView->setStyleSheet( "QTextBrowser#lyricsView { background-color: transparent; }" ); @@ -69,7 +74,8 @@ TrackInfoWidget::TrackInfoWidget( const Tomahawk::query_ptr& query, QWidget* par ui->lyricsView->setPalette( p ); ui->label->setPalette( p ); -// ui->similarTracksLabel->setPalette( p ); + ui->artistLabel->setPalette( p ); + ui->trackLabel->setPalette( p ); m_relatedTracksModel = new PlayableModel( ui->similarTracksView ); ui->similarTracksView->setPlayableModel( m_relatedTracksModel ); @@ -78,7 +84,7 @@ TrackInfoWidget::TrackInfoWidget( const Tomahawk::query_ptr& query, QWidget* par m_pixmap = TomahawkUtils::defaultPixmap( TomahawkUtils::DefaultTrackImage, TomahawkUtils::Original, QSize( 48, 48 ) ); ui->cover->setPixmap( TomahawkUtils::defaultPixmap( TomahawkUtils::DefaultTrackImage, TomahawkUtils::Grid, ui->cover->size() ) ); - ui->cover->setShowText( true ); + ui->cover->setShowText( false ); m_scrollArea = new QScrollArea(); m_scrollArea->setWidgetResizable( true ); @@ -171,6 +177,8 @@ TrackInfoWidget::load( const query_ptr& query ) m_query = query; m_artist = Artist::get( m_query->track()->artist() ); m_title = QString( "%1 - %2" ).arg( query->track()->artist() ).arg( query->track()->track() ); + ui->trackLabel->setText( m_query->track()->track() ); + ui->artistLabel->setArtist( m_query->track()->artistPtr() ); if ( !m_query.isNull() ) { diff --git a/src/libtomahawk/widgets/infowidgets/TrackInfoWidget.ui b/src/libtomahawk/widgets/infowidgets/TrackInfoWidget.ui index 41582ffda..7305c7b23 100644 --- a/src/libtomahawk/widgets/infowidgets/TrackInfoWidget.ui +++ b/src/libtomahawk/widgets/infowidgets/TrackInfoWidget.ui @@ -6,7 +6,7 @@ 0 0 - 951 + 965 771 @@ -21,7 +21,7 @@ 12 - + 16 @@ -51,17 +51,77 @@ - - - Qt::Horizontal + + + 8 - - - 40 - 20 - + + 0 - + + 8 + + + 0 + + + 0 + + + + + + 0 + 0 + + + + + 18 + 75 + true + + + + TrackName + + + 4 + + + + + + + + 0 + 0 + + + + + 14 + + + + ArtistName + + + + + + + Qt::Vertical + + + + 20 + 40 + + + + + @@ -196,6 +256,11 @@ QLabel
widgets/PlayableCover.h
+ + QueryLabel + QLabel +
widgets/QueryLabel.h
+