1
0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-05 21:57:41 +02:00

Implement request / script uuids

This commit is contained in:
Dominik Schmidt
2014-12-01 23:27:19 +01:00
parent ec3f40718e
commit a59cdbe19f
7 changed files with 16 additions and 14 deletions

View File

@@ -595,8 +595,7 @@ Tomahawk.PluginManager = {
objects: {}, objects: {},
identifyObject: function (object) { identifyObject: function (object) {
if( object.id === undefined ) { if( object.id === undefined ) {
// FIXME: get a proper unique id object.id = Tomahawk.uuid();
object.id = "foobar";
} }
return object.id; return object.id;

View File

@@ -272,6 +272,13 @@ JSResolverHelper::instanceUUID()
} }
QString
JSResolverHelper::uuid() const
{
return ::uuid();
}
void void
JSResolverHelper::addUrlResult( const QString& url, const QVariantMap& result ) JSResolverHelper::addUrlResult( const QString& url, const QVariantMap& result )
{ {

View File

@@ -126,7 +126,7 @@ public slots:
QString readBase64( const QString& fileName ); QString readBase64( const QString& fileName );
QString readCompressed( const QString& fileName ); QString readCompressed( const QString& fileName );
QString instanceUUID(); QString instanceUUID();
QString uuid() const;
QString compress( const QString& data ); QString compress( const QString& data );
QVariantMap resolverData(); QVariantMap resolverData();

View File

@@ -22,14 +22,10 @@
using namespace Tomahawk; using namespace Tomahawk;
ScriptObject::ScriptObject( ScriptPlugin* parent ) ScriptObject::ScriptObject( const QString& id, ScriptPlugin* parent )
: QObject( parent ) : QObject( parent )
, d_ptr( new ScriptObjectPrivate( this, parent )) , d_ptr( new ScriptObjectPrivate( this, id, parent ))
{ {
Q_D( ScriptObject );
// TODO:retrieve id from ScriptPlugin
d->id = "foobar";
} }

View File

@@ -37,7 +37,7 @@ friend class JSPlugin;
friend class ScriptJob; friend class ScriptJob;
public: public:
ScriptObject( ScriptPlugin* parent ); ScriptObject( const QString& id, ScriptPlugin* parent );
virtual ~ScriptObject(); virtual ~ScriptObject();
ScriptJob* invoke( const QString& methodName, const QVariantMap& arguments ); ScriptJob* invoke( const QString& methodName, const QVariantMap& arguments );

View File

@@ -28,8 +28,9 @@ class ScriptObjectPrivate
{ {
friend class ScriptObject; friend class ScriptObject;
public: public:
ScriptObjectPrivate( ScriptObject* q, ScriptPlugin* scriptPlugin ) ScriptObjectPrivate( ScriptObject* q, const QString& id, ScriptPlugin* scriptPlugin )
: q_ptr ( q ) : q_ptr ( q )
, id( id )
, scriptPlugin( scriptPlugin ) , scriptPlugin( scriptPlugin )
{ {
} }

View File

@@ -31,8 +31,7 @@ using namespace Tomahawk;
static QString static QString
requestIdGenerator() requestIdGenerator()
{ {
//FIXME: create a proper requestId return uuid();
return "somerequestId";
} }
@@ -85,7 +84,7 @@ ScriptPlugin::registerScriptPlugin( const QString& type, const QString& objectId
ScriptObject* object = m_objects.value( objectId ); ScriptObject* object = m_objects.value( objectId );
if( !object ) if( !object )
{ {
object = new ScriptObject( this ); object = new ScriptObject( objectId, this );
m_objects.insert( objectId, object ); m_objects.insert( objectId, object );
} }