mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-02 04:10:20 +02:00
Code Issues Releases Wiki Activity

don't compare any user visible strings

Browse Source
This commit is contained in:
Stefan Derkits
2013-01-09 16:23:41 +01:00
parent 41c688aa68
commit a8010e2bb4
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libtomahawk/playlist/dynamic/echonest/EchonestControl.cpp
View File

@@ -551,8 +551,8 @@ Tomahawk::EchonestControl::updateData()
m_matchString = match->currentText(); m_matchString = match->currentText();
m_matchData = match->itemData( match->currentIndex() ).toString(); m_matchData = match->itemData( match->currentIndex() ).toString();
QString songType = combo->currentText().toLower(); QString songType = combo->itemData( combo->currentIndex() ).toString();
if ( match->currentText() == "is not" ) if ( match->currentIndex() == 1 )
songType.append( ":false" ); songType.append( ":false" );
m_data.first = Echonest::DynamicPlaylist::SongType; m_data.first = Echonest::DynamicPlaylist::SongType;
@@ -904,8 +904,8 @@ Tomahawk::EchonestControl::calculateSummary()
Q_ASSERT( !m_match.isNull() ); Q_ASSERT( !m_match.isNull() );
Q_ASSERT( qobject_cast< QComboBox* >( m_match.data() ) ); Q_ASSERT( qobject_cast< QComboBox* >( m_match.data() ) );
QString isOrIsNot = qobject_cast< QComboBox* >( m_match.data() )->currentText().toLower(); QComboBox* combo = qobject_cast< QComboBox* >( m_match.data() );
if ( isOrIsNot == "is" ) if ( combo->currentIndex() == 0 )
summary = tr( "where song type is %1" ).arg( text ); summary = tr( "where song type is %1" ).arg( text );
else else
summary = tr( "where song type is not %1" ).arg( text ); summary = tr( "where song type is not %1" ).arg( text );