mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-15 10:33:59 +02:00
Code Issues Releases Wiki Activity

* Don't re-write id3 tags to a file if none of them were changed.

Browse Source
This commit is contained in:
Christian Muehlhaeuser
2012-11-16 08:36:53 +01:00
parent 8960ec9690
commit adec0b4657
1 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/libtomahawk/filemetadata/MetadataEditor.cpp
View File

@@ -65,6 +65,7 @@ MetadataEditor::writeMetadata( bool closeDlg )
{ {
QFileInfo fi( QUrl( m_result->url() ).toLocalFile() ); QFileInfo fi( QUrl( m_result->url() ).toLocalFile() );
bool changed = false;
QByteArray fileName = QFile::encodeName( fi.canonicalFilePath() ); QByteArray fileName = QFile::encodeName( fi.canonicalFilePath() );
const char *encodedName = fileName.constData(); const char *encodedName = fileName.constData();
@@ -75,6 +76,8 @@ MetadataEditor::writeMetadata( bool closeDlg )
{ {
tag->setTitle( title() ); tag->setTitle( title() );
m_result->setTrack( title() ); m_result->setTrack( title() );
changed = true;
} }
Tomahawk::artist_ptr newArtist = Tomahawk::Artist::get( artist(), true ); Tomahawk::artist_ptr newArtist = Tomahawk::Artist::get( artist(), true );
@@ -82,6 +85,9 @@ MetadataEditor::writeMetadata( bool closeDlg )
{ {
tag->setArtist( artist() ); tag->setArtist( artist() );
m_result->setArtist( newArtist ); m_result->setArtist( newArtist );
changed = true;
} }
Tomahawk::album_ptr newAlbum = Tomahawk::Album::get( newArtist, album(), true ); Tomahawk::album_ptr newAlbum = Tomahawk::Album::get( newArtist, album(), true );
@@ -89,23 +95,36 @@ MetadataEditor::writeMetadata( bool closeDlg )
{ {
tag->setAlbum( album() ); tag->setAlbum( album() );
m_result->setAlbum( newAlbum ); m_result->setAlbum( newAlbum );
changed = true;
} }
tag->setTrack( albumPos() ); if ( albumPos() != (int)m_result->albumpos() )
m_result->setAlbumPos( albumPos() ); {
tag->setTrack( albumPos() );
m_result->setAlbumPos( albumPos() );
changed = true;
}
if ( year() != m_result->year() ) if ( year() != m_result->year() )
{ {
tag->setYear( year() ); tag->setYear( year() );
m_result->setYear( year() ); m_result->setYear( year() );
changed = true;
} }
f.save(); if ( changed )
{
f.save();
m_editFiles.append( fileName ); m_editFiles.append( fileName );
m_result->doneEditing(); m_result->doneEditing();
tDebug() << Q_FUNC_INFO << m_result->toString();
tDebug() << Q_FUNC_INFO << m_result->toQuery()->toString(); tDebug() << Q_FUNC_INFO << m_result->toString();
tDebug() << Q_FUNC_INFO << m_result->toQuery()->toString();
}
if ( closeDlg ) if ( closeDlg )
{ {