From b26bd5e2960dd9d9d338b478e43b4e6ff1d7d00e Mon Sep 17 00:00:00 2001
From: Leo Franchi <lfranchi@kde.org>
Date: Thu, 3 Nov 2011 21:07:43 -0400
Subject: [PATCH] Don't assert on script output in debug mode, just show the
error
---
src/libtomahawk/resolvers/qtscriptresolver.cpp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/libtomahawk/resolvers/qtscriptresolver.cpp b/src/libtomahawk/resolvers/qtscriptresolver.cpp
index f0b760d82..0d4bd5978 100644
--- a/src/libtomahawk/resolvers/qtscriptresolver.cpp
+++ b/src/libtomahawk/resolvers/qtscriptresolver.cpp
@@ -31,6 +31,7 @@
#include <network/servent.h>
#include <QNetworkRequest>
#include <QNetworkReply>
+#include <QMessageBox>
// FIXME: bloody hack, remove this for 0.3
// this one adds new functionality to old resolvers
@@ -186,9 +187,9 @@ ScriptEngine::javaScriptConsoleMessage( const QString& message, int lineNumber,
tLog() << "JAVASCRIPT:" << m_scriptPath << message << lineNumber << sourceID;
/// I guess there is somereason for a assert in here, maybe fatal js errors, but
/// undefined is not so fatal
- if(sourceID != "undefined")
- Q_ASSERT( false );
-
+#ifdef QT_DEBUG
+ QMessageBox::critical( 0, "Script Resolver Error", QString( "%1 %2 %3 %4" ).arg( m_scriptPath ).arg( message ).arg( lineNumber ).arg( sourceID ) );
+#endif
}