Fight all compiler warnings in libtomahawk

src/libtomahawk/ActionCollection.cpp

@@ -30,6 +30,12 @@
 
 #include <QCoreApplication>
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Query.h"
+#endif
+
+
 ActionCollection* ActionCollection::s_instance = 0;
 ActionCollection* ActionCollection::instance()
 {

src/libtomahawk/AlbumPlaylistInterface.cpp

@@ -20,17 +20,23 @@
 
 #include "AlbumPlaylistInterface.h"
 
-#include "Artist.h"
+#include "utils/Logger.h"
 #include "collection/TracksRequest.h"
 #include "database/Database.h"
 #include "database/DatabaseImpl.h"
 #include "database/DatabaseCommand_AllTracks.h"
+
+#include "Artist.h"
 #include "Pipeline.h"
 #include "Query.h"
 #include "Source.h"
 #include "SourceList.h"
 
-#include "utils/Logger.h"
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Result.h"
+#endif
+
 
 using namespace Tomahawk;
 

src/libtomahawk/ArtistPlaylistInterface.cpp

@@ -19,14 +19,19 @@
 
 #include "ArtistPlaylistInterface.h"
 
-#include "Artist.h"
 #include "collection/Collection.h"
-#include "Query.h"
 #include "database/Database.h"
 #include "database/DatabaseCommand_AllTracks.h"
+#include "utils/Logger.h"
+
+#include "Artist.h"
+#include "Query.h"
 #include "Source.h"
 
-#include "utils/Logger.h"
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Result.h"
+#endif
 
 using namespace Tomahawk;
 

src/libtomahawk/LatchManager.cpp

@@ -29,6 +29,12 @@
 
 #include <QAction>
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Result.h"
+#endif
+
+
 using namespace Tomahawk;
 
 LatchManager::LatchManager( QObject* parent )

src/libtomahawk/context/ContextPage.cpp

@@ -24,6 +24,13 @@
 #include "utils/TomahawkStyle.h"
 #include "utils/TomahawkUtilsGui.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "collection/Collection.h"
+    #include "Source.h"
+#endif
+
+
 using namespace Tomahawk;
 
 

src/libtomahawk/database/DatabaseCommand.cpp

@@ -18,6 +18,8 @@
 
 #include "DatabaseCommand.h"
 
+#include "utils/Logger.h"
+
 #include "DatabaseCommand_AddFiles.h"
 #include "DatabaseCommand_CreatePlaylist.h"
 #include "DatabaseCommand_DeleteFiles.h"
@@ -30,11 +32,14 @@
 #include "DatabaseCommand_SetDynamicPlaylistRevision.h"
 #include "DatabaseCommand_SocialAction.h"
 #include "DatabaseCommand_ShareTrack.h"
-
-#include "utils/Logger.h"
 #include "DatabaseCommand_SetCollectionAttributes.h"
 #include "DatabaseCommand_SetTrackAttributes.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "collection/Collection.h"
+#endif
+
 
 DatabaseCommand::DatabaseCommand( QObject* parent )
     : QObject( parent )

src/libtomahawk/database/DatabaseCommand_ArtistStats.cpp

@@ -23,6 +23,12 @@
 #include "SourceList.h"
 #include "utils/Logger.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "collection/Collection.h"
+#endif
+
+
 using namespace Tomahawk;
 
 

src/libtomahawk/database/DatabaseCommand_DeleteDynamicPlaylist.cpp

@@ -24,6 +24,11 @@
 
 #include <QSqlQuery>
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "collection/Collection.h"
+#endif
+
 using namespace Tomahawk;
 
 

src/libtomahawk/database/DatabaseCommand_DeleteInboxEntry.cpp

@@ -21,6 +21,11 @@
 #include "Query.h"
 #include "Track.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Source.h"
+#endif
+
 
 DatabaseCommand_DeleteInboxEntry::DatabaseCommand_DeleteInboxEntry( const Tomahawk::query_ptr& query,
                                                                     QObject* parent )

src/libtomahawk/database/DatabaseCommand_ModifyInboxEntry.cpp

@@ -21,6 +21,11 @@
 #include "Query.h"
 #include "Track.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Source.h"
+#endif
+
 
 DatabaseCommand_ModifyInboxEntry::DatabaseCommand_ModifyInboxEntry( const Tomahawk::query_ptr& query,
                                                                     bool newValue,

src/libtomahawk/database/DatabaseCommand_NetworkCharts.cpp

@@ -22,6 +22,12 @@
 #include "DatabaseImpl.h"
 #include "TomahawkSqlQuery.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Source.h"
+#endif
+
+
 DatabaseCommand_NetworkCharts::DatabaseCommand_NetworkCharts( const QDateTime &from, const QDateTime &to, QObject *parent )
     : DatabaseCommand( parent )
     , m_amount( 0 )

src/libtomahawk/database/DatabaseCommand_TrackStats.cpp

@@ -23,6 +23,11 @@
 #include "SourceList.h"
 #include "utils/Logger.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "collection/Collection.h"
+#endif
+
 using namespace Tomahawk;
 
 

src/libtomahawk/jobview/InboxJobItem.cpp

@@ -29,6 +29,12 @@
 
 #include <QTimer>
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Source.h"
+#endif
+
+
 
 InboxJobItem::InboxJobItem( Side side,
                             const QString& prettyName,

src/libtomahawk/jobview/TransferStatusItem.cpp

@@ -33,6 +33,12 @@
     #include "JobStatusView.h"
 #endif
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "collection/Collection.h"
+#endif
+
+
 TransferStatusItem::TransferStatusItem( TransferStatusManager* p, StreamConnection* sc )
     : m_parent( p )
     , m_stream( QPointer< StreamConnection >( sc ) )

src/libtomahawk/playlist/PlaylistLargeItemDelegate.cpp

@@ -39,6 +39,12 @@
 #include "utils/TomahawkUtilsGui.h"
 #include "utils/Logger.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "utils/PixmapDelegateFader.h"
+#endif
+
+
 using namespace Tomahawk;
 
 

src/libtomahawk/playlist/TrackView.cpp

@@ -36,6 +36,12 @@
 #include "utils/Logger.h"
 #include "InboxModel.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "collection/Collection.h"
+    #include "utils/PixmapDelegateFader.h"
+#endif
+
 
 #include <QKeyEvent>
 #include <QPainter>

src/libtomahawk/utils/ItunesParser.cpp

@@ -34,6 +34,12 @@
 #include "utils/TomahawkUtils.h"
 #include "utils/Logger.h"
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Playlist.h"
+#endif
+
+
 using namespace Tomahawk;
 
 QPixmap* ItunesParser::s_pixmap = 0;

src/libtomahawk/widgets/OverlayWidget.cpp

@@ -26,6 +26,11 @@
 #include <QPainter>
 #include <QPropertyAnimation>
 
+// Forward Declarations breaking QSharedPointer
+#if QT_VERSION < QT_VERSION_CHECK( 5, 0, 0 )
+    #include "Source.h"
+#endif
+
 
 #define CORNER_ROUNDNESS 8.0
 #define FADING_DURATION 500