From 298d0a08a039b2a149b71dbfde412c21f684c1b5 Mon Sep 17 00:00:00 2001
From: Leo Franchi <lfranchi@kde.org>
Date: Sun, 12 Jun 2011 11:05:13 -0400
Subject: [PATCH 1/2] Try harder to fix audiocontrol flickering

---
 src/audiocontrols.cpp | 28 ++++++++++------------------
 src/audiocontrols.ui  | 35 +++++++++++++++++++++--------------
 2 files changed, 31 insertions(+), 32 deletions(-)

diff --git a/src/audiocontrols.cpp b/src/audiocontrols.cpp
index 7b060b327..56b9d2f7a 100644
--- a/src/audiocontrols.cpp
+++ b/src/audiocontrols.cpp
@@ -39,7 +39,12 @@ AudioControls::AudioControls( QWidget* parent )
 {
     ui->setupUi( this );
 
-    ui->buttonAreaLayout->setSpacing( 2 );
+    ui->buttonAreaLayout->setSpacing( 0 );
+    ui->stackedLayout->setSpacing( 0 );
+    ui->stackedLayout->setContentsMargins( 0, 0, 0, 0 );
+    ui->stackedLayout->setMargin( 0 );
+    ui->playPauseButton->setContentsMargins( 0, 0, 0, 0 );
+    ui->pauseButton->setContentsMargins( 0, 0, 0, 0 );
 
     QFont font( ui->artistTrackLabel->font() );
     font.setPixelSize( 12 );
@@ -288,10 +293,7 @@ AudioControls::onPlaybackLoading( const Tomahawk::result_ptr& result )
 /*    m_playAction->setEnabled( false );
     m_pauseAction->setEnabled( true ); */
 
-    ui->pauseButton->setEnabled( true );
-    ui->pauseButton->setVisible( true );
-    ui->playPauseButton->setVisible( false );
-    ui->playPauseButton->setEnabled( false );
+    ui->stackedLayout->setCurrentWidget( ui->pauseButton );
 }
 
 
@@ -301,23 +303,16 @@ AudioControls::onPlaybackPaused()
 /*    m_pauseAction->setEnabled( false );
     m_playAction->setEnabled( true ); */
 
-    ui->pauseButton->setVisible( false );
-    ui->pauseButton->setEnabled( false );
-    ui->playPauseButton->setEnabled( true );
-    ui->playPauseButton->setVisible( true );
+    ui->stackedLayout->setCurrentWidget( ui->playPauseButton );
 }
 
-
 void
 AudioControls::onPlaybackResumed()
 {
 /*    m_playAction->setEnabled( false );
     m_pauseAction->setEnabled( true ); */
 
-    ui->playPauseButton->setVisible( false );
-    ui->playPauseButton->setEnabled( false );
-    ui->pauseButton->setVisible( true );
-    ui->pauseButton->setEnabled( true );
+    ui->stackedLayout->setCurrentWidget( ui->pauseButton );
 }
 
 
@@ -334,10 +329,7 @@ AudioControls::onPlaybackStopped()
     ui->coverImage->setPixmap( QPixmap() );
     ui->seekSlider->setVisible( false );
 
-    ui->pauseButton->setVisible( false );
-    ui->pauseButton->setEnabled( false );
-    ui->playPauseButton->setEnabled( true );
-    ui->playPauseButton->setVisible( true );
+    ui->stackedLayout->setCurrentWidget( ui->playPauseButton );
 
 /*    m_pauseAction->setEnabled( false );
     m_playAction->setEnabled( true ); */
diff --git a/src/audiocontrols.ui b/src/audiocontrols.ui
index 31ac8f656..4ad1d807d 100644
--- a/src/audiocontrols.ui
+++ b/src/audiocontrols.ui
@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>939</width>
+    <width>929</width>
     <height>80</height>
    </rect>
   </property>
@@ -60,7 +60,7 @@
      </property>
      <layout class="QHBoxLayout" name="buttonAreaLayout">
       <item>
-       <spacer name="horizontalSpacer">
+       <spacer name="horizontalSpacer_2">
         <property name="orientation">
          <enum>Qt::Horizontal</enum>
         </property>
@@ -80,18 +80,25 @@
        </widget>
       </item>
       <item>
-       <widget class="ImageButton" name="playPauseButton">
-        <property name="text">
-         <string>Play</string>
+       <layout class="QStackedLayout" name="stackedLayout">
+        <property name="spacing">
+         <number>2</number>
         </property>
-       </widget>
-      </item>
-      <item>
-       <widget class="ImageButton" name="pauseButton">
-        <property name="text">
-         <string>Pause</string>
-        </property>
-       </widget>
+        <item>
+         <widget class="ImageButton" name="playPauseButton">
+          <property name="text">
+           <string>Play</string>
+          </property>
+         </widget>
+        </item>
+        <item>
+         <widget class="ImageButton" name="pauseButton">
+          <property name="text">
+           <string>Pause</string>
+          </property>
+         </widget>
+        </item>
+       </layout>
       </item>
       <item>
        <widget class="ImageButton" name="nextButton">
@@ -101,7 +108,7 @@
        </widget>
       </item>
       <item>
-       <spacer name="horizontalSpacer_2">
+       <spacer name="horizontalSpacer">
         <property name="orientation">
          <enum>Qt::Horizontal</enum>
         </property>

From 09be5a1a600306aeb2eba709f607359be5a6a0fb Mon Sep 17 00:00:00 2001
From: Leo Franchi <lfranchi@kde.org>
Date: Sun, 12 Jun 2011 12:13:27 -0400
Subject: [PATCH 2/2] pita wip

---
 src/audiocontrols.cpp                | 16 +++++++++-------
 src/audiocontrols.ui                 |  2 +-
 src/libtomahawk/playlist/albumview.h |  2 +-
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/audiocontrols.cpp b/src/audiocontrols.cpp
index 56b9d2f7a..0169d7d54 100644
--- a/src/audiocontrols.cpp
+++ b/src/audiocontrols.cpp
@@ -39,13 +39,6 @@ AudioControls::AudioControls( QWidget* parent )
 {
     ui->setupUi( this );
 
-    ui->buttonAreaLayout->setSpacing( 0 );
-    ui->stackedLayout->setSpacing( 0 );
-    ui->stackedLayout->setContentsMargins( 0, 0, 0, 0 );
-    ui->stackedLayout->setMargin( 0 );
-    ui->playPauseButton->setContentsMargins( 0, 0, 0, 0 );
-    ui->pauseButton->setContentsMargins( 0, 0, 0, 0 );
-
     QFont font( ui->artistTrackLabel->font() );
     font.setPixelSize( 12 );
 
@@ -171,6 +164,15 @@ AudioControls::AudioControls( QWidget* parent )
 
     connect( Tomahawk::InfoSystem::InfoSystem::instance(), SIGNAL( finished( QString ) ), SLOT( infoSystemFinished( QString ) ) );
 
+
+    ui->buttonAreaLayout->setSpacing( 0 );
+    ui->stackedLayout->setSpacing( 0 );
+    ui->stackedLayout->setContentsMargins( 0, 0, 0, 0 );
+    ui->stackedLayout->setMargin( 0 );
+    ui->playPauseButton->setContentsMargins( 0, 0, 0, 0 );
+    ui->pauseButton->setContentsMargins( 0, 0, 0, 0 );
+    ui->stackedLayout->setSizeConstraint( QLayout::SetFixedSize );
+
     onPlaybackStopped(); // initial state
 }
 
diff --git a/src/audiocontrols.ui b/src/audiocontrols.ui
index 4ad1d807d..d97d9e7f4 100644
--- a/src/audiocontrols.ui
+++ b/src/audiocontrols.ui
@@ -82,7 +82,7 @@
       <item>
        <layout class="QStackedLayout" name="stackedLayout">
         <property name="spacing">
-         <number>2</number>
+         <number>0</number>
         </property>
         <item>
          <widget class="ImageButton" name="playPauseButton">
diff --git a/src/libtomahawk/playlist/albumview.h b/src/libtomahawk/playlist/albumview.h
index 194eab8d7..98e41101c 100644
--- a/src/libtomahawk/playlist/albumview.h
+++ b/src/libtomahawk/playlist/albumview.h
@@ -1,5 +1,5 @@
 /* === This file is part of Tomahawk Player - <http://tomahawk-player.org> ===
- * 
+ *
  *   Copyright 2010-2011, Christian Muehlhaeuser <muesli@tomahawk-player.org>
  *
  *   Tomahawk is free software: you can redistribute it and/or modify