mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-05 05:37:29 +02:00
Code Issues Releases Wiki Activity

* Fixed memleak in drag & drop operations.

Browse Source
This commit is contained in:
Christian Muehlhaeuser
2013-01-15 09:55:39 +01:00
parent 2d94ece5c2
commit dffd614c38
2 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/libtomahawk/playlist/TrackView.cpp
View File

@@ -449,6 +449,7 @@ TrackView::dragEnterEvent( QDragEnterEvent* event )
void void
TrackView::dragMoveEvent( QDragMoveEvent* event ) TrackView::dragMoveEvent( QDragMoveEvent* event )
{ {
tDebug() << Q_FUNC_INFO;
QTreeView::dragMoveEvent( event ); QTreeView::dragMoveEvent( event );
if ( model()->isReadOnly() ) if ( model()->isReadOnly() )
@@ -488,9 +489,21 @@ TrackView::dragMoveEvent( QDragMoveEvent* event )
} }
void
TrackView::dragLeaveEvent( QDragLeaveEvent* event )
{
tDebug() << Q_FUNC_INFO;
QTreeView::dragLeaveEvent( event );
m_dragging = false;
setDirtyRegion( m_dropRect );
}
void void
TrackView::dropEvent( QDropEvent* event ) TrackView::dropEvent( QDropEvent* event )
{ {
tDebug() << Q_FUNC_INFO;
QTreeView::dropEvent( event ); QTreeView::dropEvent( event );
if ( event->isAccepted() ) if ( event->isAccepted() )
@@ -609,6 +622,8 @@ TrackView::startDrag( Qt::DropActions supportedActions )
{ {
m_proxyModel->removeIndexes( pindexes ); m_proxyModel->removeIndexes( pindexes );
} }
delete drag;
} }

14
src/libtomahawk/playlist/TrackView.h
View File

@@ -108,16 +108,16 @@ protected:
virtual void startDrag( Qt::DropActions supportedActions ); virtual void startDrag( Qt::DropActions supportedActions );
virtual void dragEnterEvent( QDragEnterEvent* event ); virtual void dragEnterEvent( QDragEnterEvent* event );
virtual void dragLeaveEvent( QDragLeaveEvent* /*event*/ ) { m_dragging = false; setDirtyRegion( m_dropRect ); } virtual void dragLeaveEvent( QDragLeaveEvent* event );
virtual void dragMoveEvent( QDragMoveEvent* event ); virtual void dragMoveEvent( QDragMoveEvent* event );
virtual void dropEvent( QDropEvent* event ); virtual void dropEvent( QDropEvent* event );
void wheelEvent( QWheelEvent* event ); virtual void wheelEvent( QWheelEvent* event );
void mouseMoveEvent( QMouseEvent* event ); virtual void mouseMoveEvent( QMouseEvent* event );
void mousePressEvent( QMouseEvent* event ); virtual void mousePressEvent( QMouseEvent* event );
void leaveEvent( QEvent* event ); virtual void leaveEvent( QEvent* event );
void paintEvent( QPaintEvent* event ); virtual void paintEvent( QPaintEvent* event );
void keyPressEvent( QKeyEvent* event ); virtual void keyPressEvent( QKeyEvent* event );
protected slots: protected slots:
virtual void currentChanged( const QModelIndex& current, const QModelIndex& previous ); virtual void currentChanged( const QModelIndex& current, const QModelIndex& previous );