From fc413ac1036e1956dde2475e135c3685d8825789 Mon Sep 17 00:00:00 2001 From: Dominik Schmidt Date: Fri, 15 Jan 2016 04:07:06 +0100 Subject: [PATCH] Fix download all assert/crash --- src/libtomahawk/viewpages/CollectionViewPage.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libtomahawk/viewpages/CollectionViewPage.cpp b/src/libtomahawk/viewpages/CollectionViewPage.cpp index c388c7362..af343281f 100644 --- a/src/libtomahawk/viewpages/CollectionViewPage.cpp +++ b/src/libtomahawk/viewpages/CollectionViewPage.cpp @@ -462,7 +462,9 @@ CollectionViewPage::onDownloadAll() PlayableItem* item = m_trackView->proxyModel()->itemFromIndex( m_trackView->proxyModel()->mapToSource( m_trackView->proxyModel()->index( i, 0, QModelIndex() ) ) ); if ( !item ) continue; - if ( !DownloadManager::instance()->localFileForDownload( item->query()->results().first()->downloadFormats().first().url.toString() ).isEmpty() ) + + QList< DownloadFormat > formats = item->query()->results().first()->downloadFormats(); + if ( formats.isEmpty() || !DownloadManager::instance()->localFileForDownload( formats.first().url.toString() ).isEmpty() ) continue; if ( !item->result()->downloadFormats().isEmpty() )