mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-03-20 15:59:42 +01:00
Code Issues Releases Wiki Activity
10,444 Commits 73 Branches 35 Tags
Commit Graph

10444 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Uwe L. Korn
c1d99b4868 Merge pull request #268 from lorenzhs/misc-fixes 
Miscellaneous cppcheck fixes
 2014-10-20 17:48:06 +02:00
Lorenz Hübschle-Schneider
8bb14cc26c Unsigned comparison <= 0 is identical to check for 0 2014-10-20 17:41:55 +02:00
Lorenz Hübschle-Schneider
d74c465e58 Remove break after return, it is redundant 2014-10-20 17:41:55 +02:00
Lorenz Hübschle-Schneider
69653c4934 Reduce variable scopes 2014-10-20 17:41:55 +02:00
Lorenz Hübschle-Schneider
46239947f5 Servent: Fix IP protocol version distinction 
Uwe failed at C&P!
 2014-10-20 17:41:55 +02:00
Lorenz Hübschle-Schneider
eee50b2f93 Remove dead code 
Q_ASSERT(Compiler isn't a total moron);
 2014-10-20 17:41:55 +02:00
Lorenz Hübschle-Schneider
655edf3e98 Catch exception by reference 2014-10-20 17:41:55 +02:00
Uwe L. Korn
718337ce26 PlayableItem: Set parent in initialiser list 2014-10-20 17:32:21 +02:00
Lorenz Hübschle-Schneider
45e6d52db7 DropJob: don't touch iterator after erasing element 
Also drops a redundant condition
 2014-10-20 17:05:17 +02:00
Uwe L. Korn
7423d56a9c Remove dead assignment 2014-10-20 17:03:06 +02:00
Uwe L. Korn
3db2db5dd2 Access protected member directly instead of using virtual function 2014-10-20 16:52:07 +02:00
Uwe L. Korn
71c91ba04b Call direct implementation instead of virtual in constructor 2014-10-20 16:49:57 +02:00
Uwe L. Korn
5511e34cb6 Call direct implementation instead of virtual in constructor 2014-10-20 16:33:25 +02:00
Jason Herskowitz
9c0c01962e Add white icon for use with dark menu option in Yosemite 2014-10-20 04:52:40 +02:00
Christian Muehlhaeuser
484cdaf47d Don't create (multiple) layouts with same parent in AccountWidget. 2014-10-20 04:48:06 +02:00
Jason Herskowitz
b6dd736fea Add white icon for use with dark menu option in Yosemite 2014-10-19 22:46:05 -04:00
Christian Muehlhaeuser
0229746f8b Don't create (multiple) layouts with same parent in AccountWidget. 2014-10-20 04:47:39 +02:00
Christian Muehlhaeuser
a3fc65f0a6 Don't pass parent widget in constructor. We call setLayout later. 2014-10-20 04:43:42 +02:00
Christian Muehlhaeuser
ea18ab891f Don't pass parent widget in constructor. We call setLayout later. 2014-10-20 04:43:18 +02:00
Christian Muehlhaeuser
906285e442 pngcrush images. 2014-10-20 04:23:01 +02:00
Christian Muehlhaeuser
72dae5d614 pngcrush images. 2014-10-20 04:22:25 +02:00
Christian Muehlhaeuser
a95112c5b6 Store model pointers in a QPointer for safety. 2014-10-20 04:01:37 +02:00
Christian Muehlhaeuser
4af5b6a76d Correct warning message in ColumnView. 2014-10-20 04:01:37 +02:00
Christian Muehlhaeuser
5e0b232503 Reload Collection-related models when it changed. 2014-10-20 04:01:37 +02:00
Christian Muehlhaeuser
55488cf0e4 Removed old SuperCollection related methods in TreeModel. 2014-10-20 04:01:37 +02:00
Christian Muehlhaeuser
924ff97294 Cleaned up CollectionViewPage ctor and removed obsoleted code. 2014-10-20 04:01:37 +02:00
Christian Muehlhaeuser
dc2c4bf168 Removed a bunch of unneeded code from CollectionViewPage. 2014-10-20 04:01:37 +02:00
Christian Muehlhaeuser
bb32b0c44a CollectionViewPage should do all the grunt work. Pass the collection_ptr to its ctor. 2014-10-20 04:01:37 +02:00
Christian Muehlhaeuser
78e153983f Hide composer column per default and removed obsoleted code from CollectionViewPage. 2014-10-20 04:01:37 +02:00
Christian Muehlhaeuser
dadba16e21 Removed obsolete extraHeader from CollectionViewPage. 2014-10-20 04:01:36 +02:00
Christian Muehlhaeuser
7d864468f9 Remove redundant boost include. 2014-10-20 04:01:08 +02:00
Christian Muehlhaeuser
784b15eb43 Renamed and moved FlexibleTreeView to CollectionViewPage. 2014-10-20 03:59:38 +02:00
Christian Muehlhaeuser
0812855b60 Store model pointers in a QPointer for safety. 2014-10-20 03:51:38 +02:00
Christian Muehlhaeuser
5e2253881f Correct warning message in ColumnView. 2014-10-20 03:49:56 +02:00
Christian Muehlhaeuser
e9c7fd7a16 Reload Collection-related models when it changed. 2014-10-20 03:49:23 +02:00
Christian Muehlhaeuser
1a6a15844b Removed old SuperCollection related methods in TreeModel. 2014-10-20 03:47:59 +02:00
Christian Muehlhaeuser
8dd8c77610 Cleaned up CollectionViewPage ctor and removed obsoleted code. 2014-10-20 03:11:58 +02:00
Christian Muehlhaeuser
16a3e9eccb Removed a bunch of unneeded code from CollectionViewPage. 2014-10-20 02:56:17 +02:00
Christian Muehlhaeuser
225d5764e7 CollectionViewPage should do all the grunt work. Pass the collection_ptr to its ctor. 2014-10-20 02:49:11 +02:00
Christian Muehlhaeuser
44ffefb1fb Hide composer column per default and removed obsoleted code from CollectionViewPage. 2014-10-20 02:35:34 +02:00
Christian Muehlhaeuser
1d3d8001a4 Removed obsolete extraHeader from CollectionViewPage. 2014-10-20 02:34:46 +02:00
Christian Muehlhaeuser
29ba03444b Remove redundant boost include. 2014-10-20 02:34:00 +02:00
Christian Muehlhaeuser
51fe1aa0df Renamed and moved FlexibleTreeView to CollectionViewPage. 2014-10-20 02:20:52 +02:00
Tomahawk CI
84b0d8228d Automatic merge of Transifex translations 2014-10-20 02:18:03 +02:00
Jason Herskowitz
530f0ff8c5 Make progress bar match the red of the Tomahawk logo - #ff004c 2014-10-19 13:21:04 -04:00
Jason Herskowitz
5d9b42182b Make progress bar match the red of the Tomahawk logo - #ff004c 2014-10-19 13:19:16 -04:00
Uwe L. Korn
b7cee78106 Prefer libc++ on Apple if available 2014-10-19 12:23:07 +02:00
Christian Muehlhaeuser
69ead151ba Drop the multiple versions of the empty-collection hint. 2014-10-19 10:40:48 +02:00
Christian Muehlhaeuser
01534d222f Drop the multiple versions of the empty-collection hint. 2014-10-19 10:40:22 +02:00
Christian Muehlhaeuser
bac9931372 Create IndexStatusManager in JobStatusView. 2014-10-19 10:24:48 +02:00