mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-07 22:26:57 +02:00
Code Issues Releases Wiki Activity

Fix event handler removal in dropdown/carousel dispose (#33000)

Browse Source 
* Fix event handler removal in carousel dispose

* Fix event handler removal in dropdown dispose

* Test event handlers in scrollspy dispose

* Test event handlers in toast dispose

* Test event handlers in tooltip dispose

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
This commit is contained in:
Kyle Tsang
2021-02-11 21:51:34 -08:00
committed by GitHub
parent 0a9d392975
commit 02dbd87ffa
8 changed files with 56 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
js/src/carousel.js
View File

@@ -216,7 +216,6 @@ class Carousel extends BaseComponent {
}
dispose() {
super.dispose()
EventHandler.off(this._element, EVENT_KEY)
this._items = null
@@ -226,6 +225,8 @@ class Carousel extends BaseComponent {
this._isSliding = null
this._activeElement = null
this._indicatorsElement = null
super.dispose()
}
// Private

3
js/src/dropdown.js
View File

@@ -232,7 +232,6 @@ class Dropdown extends BaseComponent {
}
dispose() {
super.dispose()
EventHandler.off(this._element, EVENT_KEY)
this._menu = null
@@ -240,6 +239,8 @@ class Dropdown extends BaseComponent {
this._popper.destroy()
this._popper = null
}
super.dispose()
}
update() {