mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-16 18:44:01 +02:00
Code Issues Releases Wiki Activity

Remove potential false positive assertions (#33288)

Browse Source 
* Remove potential false positive assertions

querySelector() returns null but

expect(document.querySelector('...')).toBeDefined()

tests that the value is not undefined

* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests

* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call

* convert more cases to not.toBeNull assertions

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This commit is contained in:
Ben Lertlumprasertkul
2021-05-11 06:45:57 +01:00
committed by GitHub
parent 9c3ab6557e
commit 052def4568
13 changed files with 67 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
js/tests/README.md
View File

@@ -61,7 +61,7 @@ it('should show a tooltip without the animation', done => {
tooltipEl.addEventListener('shown.bs.tooltip', () => {
const tip = document.querySelector('.tooltip')
expect(tip).toBeDefined()
expect(tip).not.toBeNull()
expect(tip.classList.contains('fade')).toEqual(false)
done()
})