mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-09-25 21:09:06 +02:00
Code Issues Releases Wiki Activity

Remove potential false positive assertions (#33288)

Browse Source 
* Remove potential false positive assertions

querySelector() returns null but

expect(document.querySelector('...')).toBeDefined()

tests that the value is not undefined

* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests

* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call

* convert more cases to not.toBeNull assertions

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This commit is contained in:
Ben Lertlumprasertkul
2021-05-11 06:45:57 +01:00
committed by GitHub
parent 9c3ab6557e
commit 052def4568
13 changed files with 67 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
js/tests/unit/offcanvas.spec.js
View File

@@ -560,7 +560,7 @@ describe('Offcanvas', () => {
jQueryMock.fn.offcanvas.call(jQueryMock)
expect(Offcanvas.getInstance(div)).toBeDefined()
expect(Offcanvas.getInstance(div)).not.toBeNull()
})
it('should not re create an offcanvas', () => {
@@ -678,7 +678,7 @@ describe('Offcanvas', () => {
expect(Offcanvas.prototype.constructor).not.toHaveBeenCalledWith(div, { scroll: true })
const offcanvas = Offcanvas.getInstance(div)
expect(offcanvas).toBeDefined()
expect(offcanvas).not.toBeNull()
expect(offcanvas._config.scroll).toBe(true)
})
})
@@ -699,7 +699,7 @@ describe('Offcanvas', () => {
const div = fixtureEl.querySelector('div')
expect(Offcanvas.getInstance(div)).toEqual(null)
expect(Offcanvas.getInstance(div)).toBeNull()
})
})
})