mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-18 03:11:19 +02:00
Code Issues Releases Wiki Activity

Remove potential false positive assertions (#33288)

Browse Source 
* Remove potential false positive assertions

querySelector() returns null but

expect(document.querySelector('...')).toBeDefined()

tests that the value is not undefined

* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests

* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call

* convert more cases to not.toBeNull assertions

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This commit is contained in:
Ben Lertlumprasertkul
2021-05-11 06:45:57 +01:00
committed by GitHub
parent 9c3ab6557e
commit 052def4568
13 changed files with 67 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
js/tests/unit/popover.spec.js
View File

@@ -70,7 +70,7 @@ describe('Popover', () => {
const popover = new Popover(popoverEl)
popoverEl.addEventListener('shown.bs.popover', () => {
expect(document.querySelector('.popover')).toBeDefined()
expect(document.querySelector('.popover')).not.toBeNull()
done()
})
@@ -89,7 +89,7 @@ describe('Popover', () => {
popoverEl.addEventListener('shown.bs.popover', () => {
const popoverDisplayed = document.querySelector('.popover')
expect(popoverDisplayed).toBeDefined()
expect(popoverDisplayed).not.toBeNull()
expect(popoverDisplayed.querySelector('.popover-header').textContent).toEqual('Bootstrap')
expect(popoverDisplayed.querySelector('.popover-body').textContent).toEqual('loves writing tests （╯°□°）╯︵ ┻━┻')
done()
@@ -109,7 +109,7 @@ describe('Popover', () => {
popoverEl.addEventListener('shown.bs.popover', () => {
const popoverDisplayed = document.querySelector('.popover')
expect(popoverDisplayed).toBeDefined()
expect(popoverDisplayed).not.toBeNull()
expect(popoverDisplayed.querySelector('.popover-body').textContent).toEqual('Popover content')
done()
})
@@ -125,7 +125,7 @@ describe('Popover', () => {
popoverEl.addEventListener('shown.bs.popover', () => {
const tip = document.querySelector('.popover')
expect(tip).toBeDefined()
expect(tip).not.toBeNull()
expect(tip.classList.contains('custom-class')).toBeTrue()
done()
})
@@ -165,7 +165,7 @@ describe('Popover', () => {
jQueryMock.fn.popover.call(jQueryMock)
expect(Popover.getInstance(popoverEl)).toBeDefined()
expect(Popover.getInstance(popoverEl)).not.toBeNull()
})
it('should create a popover with a config object', () => {
@@ -180,7 +180,7 @@ describe('Popover', () => {
content: 'Popover content'
})
expect(Popover.getInstance(popoverEl)).toBeDefined()
expect(Popover.getInstance(popoverEl)).not.toBeNull()
})
it('should not re create a popover', () => {