From 09aca3fb9a398273d8442d660bb6a29b42f231aa Mon Sep 17 00:00:00 2001 From: Johan Beckers <33622049+johanlef@users.noreply.github.com> Date: Fri, 7 Sep 2018 13:12:04 +0200 Subject: [PATCH] Unitless breakpoints If I want to customise the breakpoints using `em`, I get compatibility errors. It is good practice to set breakpoints in `em` instead of `px` when users use browser scaling. See https://zellwk.com/blog/media-query-units/#concluding-the-experiments for more information why someone would like to do this. Only Safari users can get annoyed: https://adamwathan.me/dont-use-em-for-media-queries/ In any case, using a unitless number at line 42 would be very convenient. --- scss/mixins/_breakpoints.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/mixins/_breakpoints.scss b/scss/mixins/_breakpoints.scss index 59f25a27e6..cfdb1976b3 100644 --- a/scss/mixins/_breakpoints.scss +++ b/scss/mixins/_breakpoints.scss @@ -39,7 +39,7 @@ // 767.98px @function breakpoint-max($name, $breakpoints: $grid-breakpoints) { $next: breakpoint-next($name, $breakpoints); - @return if($next, breakpoint-min($next, $breakpoints) - .02px, null); + @return if($next, breakpoint-min($next, $breakpoints) - .02, null); } // Returns a blank string if smallest breakpoint, otherwise returns the name with a dash in front.