mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-18 19:31:35 +02:00
Code Issues Releases Wiki Activity

Changing Backdrop rootElement to default to a string (#34092)

Browse Source 
The current config can cause the "body" to become stale. Specifically,
if the entire body element is swapped out for a new body element, then
the backdrop will continue to append itself to the original body element,
since it's stored in memory as a reference on this object.

This also no longer allows an explicit null to be passed to Backdrop's rootElement

This still accomplishes the laziness of "not finding the rootElement
until the Backdrop is created" to avoid problems of the JavaScript
being included inside <head> (so, before body is available).
This commit is contained in:
Ryan Weaver
2021-05-31 05:35:59 -04:00
committed by GitHub
parent e818c7cd5d
commit 0cb70e214f
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
js/tests/unit/util/backdrop.spec.js
View File

@@ -243,10 +243,10 @@ describe('Backdrop', () => {
})
})
it('Should default parent element to "document.body" when config value is null', done => {
it('Should find the rootElement if passed as a string', done => {
const instance = new Backdrop({
isVisible: true,
rootElement: null
rootElement: 'body'
})
const getElement = () => document.querySelector(CLASS_BACKDROP)
instance.show(() => {