mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-07 22:26:57 +02:00
Code Issues Releases Wiki Activity

Don't add empty content holder when there is no content available (#33982)

Browse Source 
* Remove content holder when there is no content

* Add tests to check the removal of header/content

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This commit is contained in:
Rohit Sharma
2021-05-18 11:32:39 +05:30
committed by GitHub
parent 0b2d20b975
commit 153cf3a235
2 changed files with 59 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
js/src/popover.js
View File

@@ -30,7 +30,7 @@ const Default = {
content: '',
template: '<div class="popover" role="tooltip">' +
'<div class="popover-arrow"></div>' +
'<h3 class="popover-header"></h3>' +
'<h3 class="popover-header"></h3>' +
'<div class="popover-body"></div>' +
'</div>'
}
@@ -90,6 +90,24 @@ class Popover extends Tooltip {
return this.getTitle() || this._getContent()
}
getTipElement() {
if (this.tip) {
return this.tip
}
this.tip = super.getTipElement()
if (!this.getTitle()) {
this.tip.removeChild(SelectorEngine.findOne(SELECTOR_TITLE, this.tip))
}
if (!this._getContent()) {
this.tip.removeChild(SelectorEngine.findOne(SELECTOR_CONTENT, this.tip))
}
return this.tip
}
setContent() {
const tip = this.getTipElement()