mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-12 00:24:03 +02:00
Code Issues Releases Wiki Activity

Refactor isVisible helper, fixing false positives from deep nesting or alternate means (#33960)

Browse Source
This commit is contained in:
Ryan Berliner
2021-05-20 09:50:53 -04:00
committed by GitHub
parent 79c3bf47bc
commit 4ac711b5b4
2 changed files with 52 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
js/tests/unit/util/index.spec.js
View File

@@ -326,10 +326,14 @@ describe('Util', () => {
expect(Util.isVisible(div)).toEqual(false)
})
it('should return false if the parent element is not visible', () => {
it('should return false if an ancestor element is display none', () => {
fixtureEl.innerHTML = [
'<div style="display: none;">',
' <div class="content"></div>',
' <div>',
' <div>',
' <div class="content"></div>',
' </div>',
' </div>',
'</div>'
].join('')
@@ -338,6 +342,38 @@ describe('Util', () => {
expect(Util.isVisible(div)).toEqual(false)
})
it('should return false if an ancestor element is visibility hidden', () => {
fixtureEl.innerHTML = [
'<div style="visibility: hidden;">',
' <div>',
' <div>',
' <div class="content"></div>',
' </div>',
' </div>',
'</div>'
].join('')
const div = fixtureEl.querySelector('.content')
expect(Util.isVisible(div)).toEqual(false)
})
it('should return true if an ancestor element is visibility hidden, but reverted', () => {
fixtureEl.innerHTML = [
'<div style="visibility: hidden;">',
' <div style="visibility: visible;">',
' <div>',
' <div class="content"></div>',
' </div>',
' </div>',
'</div>'
].join('')
const div = fixtureEl.querySelector('.content')
expect(Util.isVisible(div)).toEqual(true)
})
it('should return true if the element is visible', () => {
fixtureEl.innerHTML = [
'<div>',
@@ -349,6 +385,18 @@ describe('Util', () => {
expect(Util.isVisible(div)).toEqual(true)
})
it('should return false if the element is hidden, but not via display or visibility', () => {
fixtureEl.innerHTML = [
'<details>',
' <div id="element"></div>',
'</details>'
].join('')
const div = fixtureEl.querySelector('#element')
expect(Util.isVisible(div)).toEqual(false)
})
})
describe('isDisabled', () => {