diff --git a/js/tests/unit/popover.js b/js/tests/unit/popover.js index 16f94e1438..5cb4cafddc 100644 --- a/js/tests/unit/popover.js +++ b/js/tests/unit/popover.js @@ -4,8 +4,7 @@ $(function () { module('popover plugin') test('should be defined on jquery object', function () { - var div = $('
') - ok(div.popover, 'popover method is defined') + ok($(document.body).popover, 'popover method is defined') }) module('popover', { @@ -20,46 +19,44 @@ $(function () { }) test('should provide no conflict', function () { - ok(!$.fn.popover, 'popover was set back to undefined (org value)') + strictEqual($.fn.popover, undefined, 'popover was set back to undefined (org value)') }) - test('should return element', function () { - var div = $('') - ok(div.bootstrapPopover() == div, 'document.body returned') + test('should return jquery collection containing the element', function () { + var $el = $('') + var $popover = $el.bootstrapPopover() + ok($popover instanceof $, 'returns jquery collection') + strictEqual($popover[0], $el[0], 'collection contains element') }) test('should render popover element', function () { - $.support.transition = false - var popover = $('@mdo') + var $popover = $('@mdo') .appendTo('#qunit-fixture') .bootstrapPopover('show') - ok($('.popover').length, 'popover was inserted') - popover.bootstrapPopover('hide') - ok(!$('.popover').length, 'popover removed') + notEqual($('.popover').length, 0, 'popover was inserted') + $popover.bootstrapPopover('hide') + equal($('.popover').length, 0, 'popover removed') }) test('should store popover instance in popover data object', function () { - $.support.transition = false - var popover = $('@mdo') - .bootstrapPopover() + var $popover = $('@mdo').bootstrapPopover() - ok(!!popover.data('bs.popover'), 'popover instance exists') + ok($popover.data('bs.popover'), 'popover instance exists') }) test('should store popover trigger in popover instance data object', function () { - $.support.transition = false - var popover = $('@ResentedHook') + var $popover = $('@ResentedHook') .appendTo('#qunit-fixture') .bootstrapPopover() - popover.bootstrapPopover('show') - ok(!!$('.popover').data('bs.popover'), 'popover trigger stored in instance data') - $('#qunit-fixture').empty() + + $popover.bootstrapPopover('show') + + ok($('.popover').data('bs.popover'), 'popover trigger stored in instance data') }) test('should get title and content from options', function () { - $.support.transition = false - var popover = $('@fat') + var $popover = $('@fat') .appendTo('#qunit-fixture') .bootstrapPopover({ title: function () { @@ -70,23 +67,20 @@ $(function () { } }) - popover.bootstrapPopover('show') + $popover.bootstrapPopover('show') - ok($('.popover').length, 'popover was inserted') + notEqual($('.popover').length, 0, 'popover was inserted') equal($('.popover .popover-title').text(), '@fat', 'title correctly inserted') equal($('.popover .popover-content').text(), 'loves writing tests (╯°□°)╯︵ ┻━┻', 'content correctly inserted') - popover.bootstrapPopover('hide') - ok(!$('.popover').length, 'popover was removed') - $('#qunit-fixture').empty() + $popover.bootstrapPopover('hide') + equal($('.popover').length, 0, 'popover was removed') }) test('should not duplicate HTML object', function () { - $.support.transition = false + var $div = $('').html('loves writing tests (╯°□°)╯︵ ┻━┻') - var $div = $('