Remove DOMContentLoaded. (#28337)

There's no reason for us to wait here.

js/tests/visual/carousel.html

@@ -54,19 +54,18 @@
     <script src="../../dist/util.js"></script>
     <script src="../../dist/carousel.js"></script>
     <script>
-      document.addEventListener('DOMContentLoaded', function () {
-        var t0, t1;
-        var carousel = document.getElementById('carousel-example-generic')
+      var t0
+      var t1
+      var carousel = document.getElementById('carousel-example-generic')
 
-        // Test to show that the carousel doesn't slide when the current tab isn't visible
-        // Test to show that transition-duration can be changed with css
-        carousel.addEventListener('slid.bs.carousel', function (event) {
-          t1 = performance.now()
-          console.log('transition-duration took ' + (t1 - t0) + 'ms, slid at ', event.timeStamp)
-        })
-        carousel.addEventListener('slide.bs.carousel', function () {
-          t0 = performance.now()
-        })
+      // Test to show that the carousel doesn't slide when the current tab isn't visible
+      // Test to show that transition-duration can be changed with css
+      carousel.addEventListener('slid.bs.carousel', function (event) {
+        t1 = performance.now()
+        console.log('transition-duration took ' + (t1 - t0) + 'ms, slid at ', event.timeStamp)
+      })
+      carousel.addEventListener('slide.bs.carousel', function () {
+        t0 = performance.now()
       })
     </script>
   </body>

js/tests/visual/modal.html

@@ -217,86 +217,83 @@
     <script src="../../dist/tooltip.js"></script>
     <script src="../../dist/popover.js"></script>
     <script>
+      var ffBugTestResult = document.getElementById('ff-bug-test-result')
       var firefoxTestDone = false
-      document.addEventListener('DOMContentLoaded', function () {
-        var ffBugTestResult = document.getElementById('ff-bug-test-result')
 
-        function reportFirefoxTestResult(result) {
-          if (!firefoxTestDone) {
-            ffBugTestResult.classList
-              .add(result ? 'text-success' : 'text-danger')
+      function reportFirefoxTestResult(result) {
+        if (!firefoxTestDone) {
+          ffBugTestResult.classList.add(result ? 'text-success' : 'text-danger')
+          ffBugTestResult.innerHTML = result ? 'PASS' : 'FAIL'
+        }
+      }
 
-            ffBugTestResult.innerHTML = result ? 'PASS' : 'FAIL'
-          }
+      [].slice.call(document.querySelectorAll('[data-toggle="popover"]'))
+        .forEach(function (popover) {
+          new Popover(popover)
+        })
+
+      var tooltipList = [].slice.call(document.querySelectorAll('[data-toggle="tooltip"]'))
+      tooltipList.forEach(function (tooltip) {
+        new Tooltip(tooltip)
+      })
+
+      var tallToggle = document.getElementById('tall-toggle')
+      var tall = document.getElementById('tall')
+      tallToggle.addEventListener('click', function () {
+        if (tall.style.display === 'none') {
+          tall.style.display = 'block'
+        } else {
+          tall.style.display = 'none'
+        }
+      })
+
+      var ffBugInput = document.getElementById('ff-bug-input')
+      var firefoxModal = document.getElementById('firefoxModal')
+      function handlerClickFfBugInput() {
+        firefoxModal.addEventListener('focus', reportFirefoxTestResult.bind(false))
+        ffBugInput.addEventListener('focus', reportFirefoxTestResult.bind(true))
+        ffBugInput.removeEventListener('focus', handlerClickFfBugInput)
+      }
+      ffBugInput.addEventListener('focus', handlerClickFfBugInput)
+
+      var btnPreventModal = document.getElementById('btnPreventModal')
+      var modalFf = new Modal(firefoxModal)
+
+      btnPreventModal.addEventListener('click', function () {
+        function shownFirefoxModal() {
+          modalFf.hide()
+          firefoxModal.removeEventListener('shown.bs.modal', hideFirefoxModal)
         }
 
-        [].slice.call(document.querySelectorAll('[data-toggle="popover"]'))
-          .forEach(function (popover) {
-            new Popover(popover)
-          })
+        function hideFirefoxModal(event) {
+          event.preventDefault()
+          firefoxModal.removeEventListener('hide.bs.modal', hideFirefoxModal)
 
-        var tooltipList = [].slice.call(document.querySelectorAll('[data-toggle="tooltip"]'))
-        tooltipList.forEach(function (tooltip) {
-            new Tooltip(tooltip)
-          })
-
-        var tallToggle = document.getElementById('tall-toggle')
-        var tall = document.getElementById('tall')
-        tallToggle.addEventListener('click', function () {
-          if (tall.style.display === 'none') {
-            tall.style.display = 'block'
+          if (modalFf._isTransitioning) {
+            console.error('Modal plugin should not set _isTransitioning when hide event is prevented')
           } else {
-            tall.style.display = 'none'
+            console.log('Test passed')
+            modalFf.hide() // work as expected
           }
-        })
-
-        var ffBugInput = document.getElementById('ff-bug-input')
-        var firefoxModal = document.getElementById('firefoxModal')
-        function handlerClickFfBugInput() {
-          firefoxModal.addEventListener('focus', reportFirefoxTestResult.bind(false))
-          ffBugInput.addEventListener('focus', reportFirefoxTestResult.bind(true))
-          ffBugInput.removeEventListener('focus', handlerClickFfBugInput)
         }
-        ffBugInput.addEventListener('focus', handlerClickFfBugInput)
 
-        var btnPreventModal = document.getElementById('btnPreventModal')
-        var modalFf = new Modal(firefoxModal)
+        firefoxModal.addEventListener('shown.bs.modal', shownFirefoxModal)
+        firefoxModal.addEventListener('hide.bs.modal', hideFirefoxModal)
+        modalFf.show()
+      })
 
-        btnPreventModal.addEventListener('click', function () {
-          function shownFirefoxModal() {
-            modalFf.hide()
-            firefoxModal.removeEventListener('shown.bs.modal', hideFirefoxModal)
-          }
+      // Test transition duration
+      var t0
+      var t1
+      var slowModal = document.getElementById('slowModal')
 
-          function hideFirefoxModal(event) {
-            event.preventDefault()
-            firefoxModal.removeEventListener('hide.bs.modal', hideFirefoxModal)
+      slowModal.addEventListener('shown.bs.modal', function () {
+        t1 = performance.now()
+        console.log('transition-duration took ' + (t1 - t0) + 'ms.')
+      })
 
-            if (modalFf._isTransitioning) {
-              console.error('Modal plugin should not set _isTransitioning when hide event is prevented')
-            } else {
-              console.log('Test passed')
-              modalFf.hide() // work as expected
-            }
-          }
-
-          firefoxModal.addEventListener('shown.bs.modal', shownFirefoxModal)
-          firefoxModal.addEventListener('hide.bs.modal', hideFirefoxModal)
-          modalFf.show()
-        })
-
-        // Test transition duration
-        var t0, t1;
-        var slowModal = document.getElementById('slowModal')
-
-        slowModal.addEventListener('shown.bs.modal', function () {
-          t1 = performance.now()
-          console.log('transition-duration took ' + (t1 - t0) + 'ms.')
-        })
-
-        slowModal.addEventListener('show.bs.modal', function () {
-          t0 = performance.now()
-        })
+      slowModal.addEventListener('show.bs.modal', function () {
+        t0 = performance.now()
       })
     </script>
   </body>

js/tests/visual/popover.html

@@ -41,12 +41,10 @@
     <script src="../../dist/tooltip.js"></script>
     <script src="../../dist/popover.js"></script>
     <script>
-      document.addEventListener('DOMContentLoaded', function () {
-        [].slice.call(document.querySelectorAll('[data-toggle="popover"]'))
-          .forEach(function (popover) {
-            new Popover(popover)
-          })
-      })
+      [].slice.call(document.querySelectorAll('[data-toggle="popover"]'))
+        .forEach(function (popover) {
+          new Popover(popover)
+        })
     </script>
   </body>
 </html>

js/tests/visual/tooltip.html

@@ -80,40 +80,38 @@
     <script src="../../dist/dom/selectorEngine.js"></script>
     <script src="../../dist/tooltip.js"></script>
     <script>
-      document.addEventListener('DOMContentLoaded', function () {
-        if (typeof document.body.attachShadow === 'function') {
-          var shadowRoot = document.getElementById('shadow').attachShadow({ mode: 'open' })
-          shadowRoot.innerHTML =
-            '<button type="button" class="btn btn-secondary" data-toggle="tooltip" data-placement="top" title="Tooltip on top in a shadow dom">' +
-            '  Tooltip on top in a shadow dom' +
-            '</button>' +
-            '<button id="secondTooltip" type="button" class="btn btn-secondary" data-toggle="tooltip" data-placement="top" title="Tooltip on top in a shadow dom with container option">' +
-            '  Tooltip on top in a shadow dom' +
-            '</button>'
+      if (typeof document.body.attachShadow === 'function') {
+        var shadowRoot = document.getElementById('shadow').attachShadow({ mode: 'open' })
+        shadowRoot.innerHTML =
+          '<button type="button" class="btn btn-secondary" data-toggle="tooltip" data-placement="top" title="Tooltip on top in a shadow dom">' +
+          '  Tooltip on top in a shadow dom' +
+          '</button>' +
+          '<button id="secondTooltip" type="button" class="btn btn-secondary" data-toggle="tooltip" data-placement="top" title="Tooltip on top in a shadow dom with container option">' +
+          '  Tooltip on top in a shadow dom' +
+          '</button>'
 
-          var firstChildTooltip = new Tooltip(shadowRoot.firstChild)
-          var secondChildTooltip = new Tooltip(shadowRoot.getElementById('secondTooltip'), {
-            container: shadowRoot
-          })
-        }
+        var firstChildTooltip = new Tooltip(shadowRoot.firstChild)
+        var secondChildTooltip = new Tooltip(shadowRoot.getElementById('secondTooltip'), {
+          container: shadowRoot
+        })
+      }
 
-        [].slice.call(document.querySelectorAll('[data-toggle="tooltip"]'))
-          .forEach(function (tooltip) {
-            new Tooltip(tooltip)
-          })
-
-        var tooltipElement = document.getElementById('tooltipElement')
-        var tooltipElementInstance = new Tooltip(tooltipElement, {
-          container: document.getElementById('customContainer')
+      [].slice.call(document.querySelectorAll('[data-toggle="tooltip"]'))
+        .forEach(function (tooltip) {
+          new Tooltip(tooltip)
         })
 
-        var target = document.getElementById('target')
-        var targetTooltip = new Tooltip(target, {
-          placement : 'top',
-          trigger : 'manual'
-        })
-        targetTooltip.show()
+      var tooltipElement = document.getElementById('tooltipElement')
+      var tooltipElementInstance = new Tooltip(tooltipElement, {
+        container: document.getElementById('customContainer')
       })
+
+      var target = document.getElementById('target')
+      var targetTooltip = new Tooltip(target, {
+        placement : 'top',
+        trigger : 'manual'
+      })
+      targetTooltip.show()
     </script>
   </body>
 </html>