mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-07 14:16:47 +02:00
Code Issues Releases Wiki Activity

Tab: minor refactoring (#35511)

Browse Source 
* remove unneeded parentheses
* move variable
This commit is contained in:
XhmikosR
2021-12-10 07:51:57 +02:00
committed by GitHub
parent 871c8bdd3f
commit 63d38b1974
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
js/src/tab.js
View File

@@ -5,12 +5,7 @@
* -------------------------------------------------------------------------- * --------------------------------------------------------------------------
*/ */
import { import { defineJQueryPlugin, getElementFromSelector, isDisabled, reflow } from './util/index'
defineJQueryPlugin,
getElementFromSelector,
isDisabled,
reflow
} from './util/index'
import EventHandler from './dom/event-handler' import EventHandler from './dom/event-handler'
import SelectorEngine from './dom/selector-engine' import SelectorEngine from './dom/selector-engine'
import BaseComponent from './base-component' import BaseComponent from './base-component'
@@ -55,15 +50,15 @@ class Tab extends BaseComponent {
// Public // Public
show() { show() {
if ((this._element.parentNode && if (this._element.parentNode &&
this._element.parentNode.nodeType === Node.ELEMENT_NODE && this._element.parentNode.nodeType === Node.ELEMENT_NODE &&
this._element.classList.contains(CLASS_NAME_ACTIVE))) { this._element.classList.contains(CLASS_NAME_ACTIVE)) {
return return
} }
let previous
const target = getElementFromSelector(this._element) const target = getElementFromSelector(this._element)
const listElement = this._element.closest(SELECTOR_NAV_LIST_GROUP) const listElement = this._element.closest(SELECTOR_NAV_LIST_GROUP)
let previous
if (listElement) { if (listElement) {
const itemSelector = listElement.nodeName === 'UL' || listElement.nodeName === 'OL' ? SELECTOR_ACTIVE_UL : SELECTOR_ACTIVE const itemSelector = listElement.nodeName === 'UL' || listElement.nodeName === 'OL' ? SELECTOR_ACTIVE_UL : SELECTOR_ACTIVE
@@ -75,9 +70,7 @@ class Tab extends BaseComponent {
EventHandler.trigger(previous, EVENT_HIDE, { relatedTarget: this._element }) : EventHandler.trigger(previous, EVENT_HIDE, { relatedTarget: this._element }) :
null null
const showEvent = EventHandler.trigger(this._element, EVENT_SHOW, { const showEvent = EventHandler.trigger(this._element, EVENT_SHOW, { relatedTarget: previous })
relatedTarget: previous
})
if (showEvent.defaultPrevented || (hideEvent !== null && hideEvent.defaultPrevented)) { if (showEvent.defaultPrevented || (hideEvent !== null && hideEvent.defaultPrevented)) {
return return