fix(manipulator): increase coverage for manipulator

js/tests/index.html

@@ -97,10 +97,11 @@
     </script>
 
     <!-- Transpiled Plugins -->
+    <script src="../dist/dom/polyfill.js"></script>
+    <script src="../dist/dom/manipulator.js"></script>
     <script src="../dist/dom/eventHandler.js"></script>
     <script src="../dist/dom/selectorEngine.js"></script>
     <script src="../dist/dom/data.js"></script>
-    <script src="../dist/dom/manipulator.js"></script>
     <script src="../dist/util.js"></script>
     <script src="../dist/alert.js"></script>
     <script src="../dist/button.js"></script>
@@ -116,6 +117,8 @@
 
     <!-- Unit Tests -->
     <script src="unit/dom/eventHandler.js"></script>
+    <script src="unit/dom/manipulator.js"></script>
+    <script src="unit/dom/data.js"></script>
     <script src="unit/alert.js"></script>
     <script src="unit/button.js"></script>
     <script src="unit/carousel.js"></script>

js/tests/karma.conf.js

@@ -140,6 +140,16 @@ if (bundle) {
         branches: 86,
         functions: 89,
         lines: 90
+      },
+      each: {
+        overrides: {
+          'js/src/dom/polyfill.js': {
+            statements: 39,
+            lines: 37,
+            branches: 19,
+            functions: 50
+          }
+        }
       }
     }
   }

js/tests/unit/dom/manipulator.js

@@ -0,0 +1,179 @@
+$(function () {
+  'use strict'
+
+  QUnit.module('manipulator')
+
+  QUnit.test('should be defined', function (assert) {
+    assert.expect(1)
+    assert.ok(Manipulator, 'Manipulator is defined')
+  })
+
+  QUnit.test('should set checked for input', function (assert) {
+    assert.expect(2)
+
+    var $input = $('<input type="checkbox" />').appendTo('#qunit-fixture')
+    Manipulator.setChecked($input[0], true)
+
+    assert.ok($input[0].checked)
+
+    Manipulator.setChecked($input[0], false)
+
+    assert.ok(!$input[0].checked)
+  })
+
+  QUnit.test('should not set checked for non input element', function (assert) {
+    assert.expect(1)
+
+    var $div = $('<div />').appendTo('#qunit-fixture')
+    Manipulator.setChecked($div[0], true)
+
+    assert.ok(typeof $div[0].checked === 'undefined')
+  })
+
+  QUnit.test('should verify if an element is checked', function (assert) {
+    assert.expect(2)
+
+    var $input = $('<input type="checkbox" />').appendTo('#qunit-fixture')
+    Manipulator.setChecked($input[0], true)
+
+    assert.ok(Manipulator.isChecked($input[0]))
+
+    Manipulator.setChecked($input[0], false)
+
+    assert.ok(!Manipulator.isChecked($input[0]))
+  })
+
+  QUnit.test('should throw an error when the element is not an input', function (assert) {
+    assert.expect(1)
+
+    var $div = $('<div />').appendTo('#qunit-fixture')
+    try {
+      Manipulator.isChecked($div[0])
+    } catch (e) {
+      assert.strictEqual(e.message, 'INPUT parameter is not an HTMLInputElement')
+    }
+  })
+
+  QUnit.test('should set data attribute', function (assert) {
+    assert.expect(1)
+
+    var $div = $('<div />').appendTo('#qunit-fixture')
+
+    Manipulator.setDataAttribute($div[0], 'test', 'test')
+
+    assert.strictEqual($div[0].getAttribute('data-test'), 'test')
+  })
+
+  QUnit.test('should set data attribute in lower case', function (assert) {
+    assert.expect(1)
+
+    var $div = $('<div />').appendTo('#qunit-fixture')
+
+    Manipulator.setDataAttribute($div[0], 'tEsT', 'test')
+
+    assert.strictEqual($div[0].getAttribute('data-test'), 'test')
+  })
+
+  QUnit.test('should get data attribute', function (assert) {
+    assert.expect(2)
+
+    var $div = $('<div data-test="null" />').appendTo('#qunit-fixture')
+
+    assert.strictEqual(Manipulator.getDataAttribute($div[0], 'test'), null)
+
+    var $div2 = $('<div data-test2="js" />').appendTo('#qunit-fixture')
+
+    assert.strictEqual(Manipulator.getDataAttribute($div2[0], 'tEst2'), 'js')
+  })
+
+  QUnit.test('should get data attributes', function (assert) {
+    assert.expect(2)
+
+    var $div = $('<div data-test="js" data-test2="js2" />').appendTo('#qunit-fixture')
+    var $div2 = $('<div data-test3="js" data-test4="js2" />').appendTo('#qunit-fixture')
+
+    assert.propEqual(Manipulator.getDataAttributes($div[0]), {
+      test: 'js',
+      test2: 'js2'
+    })
+
+    var stub = sinon
+      .stub(Object, 'getOwnPropertyDescriptor')
+      .callsFake(function () {
+        return false
+      })
+
+    assert.propEqual(Manipulator.getDataAttributes($div2[0]), {
+      test3: 'js',
+      test4: 'js2'
+    })
+
+    stub.restore()
+  })
+
+  QUnit.test('should remove data attribute', function (assert) {
+    assert.expect(2)
+
+    var $div = $('<div />').appendTo('#qunit-fixture')
+
+    Manipulator.setDataAttribute($div[0], 'test', 'test')
+
+    assert.strictEqual($div[0].getAttribute('data-test'), 'test')
+
+    Manipulator.removeDataAttribute($div[0], 'test')
+
+    assert.strictEqual($div[0].getAttribute('data-test'), null)
+  })
+
+  QUnit.test('should remove data attribute in lower case', function (assert) {
+    assert.expect(2)
+
+    var $div = $('<div />').appendTo('#qunit-fixture')
+
+    Manipulator.setDataAttribute($div[0], 'test', 'test')
+
+    assert.strictEqual($div[0].getAttribute('data-test'), 'test')
+
+    Manipulator.removeDataAttribute($div[0], 'tESt')
+
+    assert.strictEqual($div[0].getAttribute('data-test'), null)
+  })
+
+  QUnit.test('should return element offsets', function (assert) {
+    assert.expect(2)
+
+    var $div = $('<div />').appendTo('#qunit-fixture')
+
+    var offset = Manipulator.offset($div[0])
+
+    assert.ok(typeof offset.top === 'number')
+    assert.ok(typeof offset.left === 'number')
+  })
+
+  QUnit.test('should return element position', function (assert) {
+    assert.expect(2)
+
+    var $div = $('<div />').appendTo('#qunit-fixture')
+
+    var offset = Manipulator.position($div[0])
+
+    assert.ok(typeof offset.top === 'number')
+    assert.ok(typeof offset.left === 'number')
+  })
+
+  QUnit.test('should toggle class', function (assert) {
+    assert.expect(2)
+
+    var $div = $('<div class="test" />').appendTo('#qunit-fixture')
+
+    Manipulator.toggleClass($div[0], 'test')
+
+    assert.ok(!$div.hasClass('test'))
+
+    Manipulator.toggleClass($div[0], 'test')
+
+    assert.ok($div.hasClass('test'))
+
+    Manipulator.toggleClass(null)
+  })
+})

js/tests/unit/modal.js

@@ -422,7 +422,7 @@ $(function () {
 
     $('<div id="modal-test"/>')
       .on('hidden.bs.modal', function () {
-        assert.strictEqual(typeof $body.data('padding-right'), 'undefined', 'data-padding-right should be cleared after closing')
+        assert.strictEqual(document.body.getAttribute('data-padding-right'), null, 'data-padding-right should be cleared after closing')
         $body.removeAttr('style')
         done()
       })
@@ -488,7 +488,7 @@ $(function () {
 
     $('<div id="modal-test"/>')
       .on('hidden.bs.modal', function () {
-        assert.strictEqual(typeof $element.data('padding-right'), 'undefined', 'data-padding-right should be cleared after closing')
+        assert.strictEqual($element[0].getAttribute('data-padding-right'), null, 'data-padding-right should be cleared after closing')
         $element.remove()
         done()
       })
@@ -530,7 +530,7 @@ $(function () {
 
     $('<div id="modal-test"/>')
       .on('hidden.bs.modal', function () {
-        assert.strictEqual(typeof $element.data('margin-right'), 'undefined', 'data-margin-right should be cleared after closing')
+        assert.strictEqual($element[0].getAttribute('data-margin-right'), null, 'data-margin-right should be cleared after closing')
         $element.remove()
         done()
       })