mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-12 08:34:08 +02:00
Code Issues Releases Wiki Activity

rm redundant aria-hidden usage from Modals; fixes #16020

Browse Source
This commit is contained in:
Chris Rebert
2015-03-25 18:06:47 -07:00
parent 2f3076f20a
commit 6c5e7dfce1
4 changed files with 14 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
js/tests/unit/modal.js
View File

@@ -49,18 +49,6 @@ $(function () {
.bootstrapModal('show')
})
QUnit.test('should set aria-hidden to false when show method is called', function (assert) {
assert.expect(1)
var done = assert.async()
$('<div id="modal-test"/>')
.on('shown.bs.modal', function () {
assert.strictEqual($('#modal-test').attr('aria-hidden'), 'false', 'aria-hidden is set to string "false" when modal shown')
done()
})
.bootstrapModal('show')
})
QUnit.test('should fire show event', function (assert) {
assert.expect(1)
var done = assert.async()
@@ -106,22 +94,6 @@ $(function () {
.bootstrapModal('show')
})
QUnit.test('should set aria-hidden to true when hide is called', function (assert) {
assert.expect(2)
var done = assert.async()
$('<div id="modal-test"/>')
.on('shown.bs.modal', function () {
assert.strictEqual($('#modal-test').length, 1, 'modal has been inserted into the dom')
$(this).bootstrapModal('hide')
})
.on('hidden.bs.modal', function () {
assert.strictEqual($('#modal-test').attr('aria-hidden'), 'true', 'aria-hidden is set to string "true" when modal shown')
done()
})
.bootstrapModal('show')
})
QUnit.test('should toggle when toggle is called', function (assert) {
assert.expect(3)
var done = assert.async()

2
js/tests/visual/modal.html
View File

@@ -54,7 +54,7 @@
<h1>Modal <small>Bootstrap Visual Test</small></h1>
</div>
<div id="myModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true">
<div id="myModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel">
<div class="modal-dialog">
<div class="modal-content">