mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-17 19:06:40 +02:00
Code Issues Releases Wiki Activity

Dropdown: use only one check for shown state

Browse Source
This commit is contained in:
GeoSot
2021-12-13 02:17:03 +02:00
committed by XhmikosR
parent 5f1c542d67
commit 7f04f84bf8
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
js/src/dropdown.js
View File

@@ -114,7 +114,7 @@ class Dropdown extends BaseComponent {
} }
show() { show() {
if (isDisabled(this._element) || this._isShown(this._menu)) { if (isDisabled(this._element) || this._isShown()) {
return return
} }
@@ -149,7 +149,7 @@ class Dropdown extends BaseComponent {
} }
hide() { hide() {
if (isDisabled(this._element) || !this._isShown(this._menu)) { if (isDisabled(this._element) || !this._isShown()) {
return return
} }
@@ -233,8 +233,8 @@ class Dropdown extends BaseComponent {
this._popper = Popper.createPopper(referenceElement, this._menu, popperConfig) this._popper = Popper.createPopper(referenceElement, this._menu, popperConfig)
} }
_isShown(element = this._element) { _isShown() {
return element.classList.contains(CLASS_NAME_SHOW) return this._menu.classList.contains(CLASS_NAME_SHOW)
} }
_getPlacement() { _getPlacement() {