From 56aa2af6e1eb10d1e7873393e46537e20ff4f43b Mon Sep 17 00:00:00 2001 From: maxwellium Date: Fri, 1 Nov 2013 22:51:11 +0100 Subject: [PATCH 1/6] otherwise content scrolls on chrome without change, body scrolls on chrome Version 30.0.1599.101 (OSX 10.9) --- examples/offcanvas/offcanvas.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/offcanvas/offcanvas.css b/examples/offcanvas/offcanvas.css index 71ad2ac2c4..ef632dc00b 100644 --- a/examples/offcanvas/offcanvas.css +++ b/examples/offcanvas/offcanvas.css @@ -2,7 +2,8 @@ * Style tweaks * -------------------------------------------------- */ -html { +html, +body { overflow-x: hidden; /* Prevent scroll on narrow devices */ } body { From 38d689491033cc3a95b7ac74999f34428a837895 Mon Sep 17 00:00:00 2001 From: Ross Allen Date: Mon, 4 Nov 2013 22:11:57 -1000 Subject: [PATCH 2/6] Serve jQuery from cookie-free Google APIs jQuery.com uses Google Analytics and so sets a cookie when you visit the site. When you request jquery.js from its CDN, code.jquery.com, you take a hit from sending your previous GA cookie in the request. Google Hosted Libraries[1] and googleapis.com never set cookies. [1] https://developers.google.com/speed/libraries/devguide --- _includes/footer.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_includes/footer.html b/_includes/footer.html index 7f9f8f103b..6deb13192b 100644 --- a/_includes/footer.html +++ b/_includes/footer.html @@ -1,7 +1,7 @@ - + From 4f5a865684db1ade9185a6b4823a8e249fd616d3 Mon Sep 17 00:00:00 2001 From: Ross Allen Date: Mon, 4 Nov 2013 22:17:05 -1000 Subject: [PATCH 3/6] Load Twitter widget async, prevent SPOF Twitter's widget library[1] provides an async snippet to inject the script tag later. Since widgets.js came before the local JS, if twitter.com took long to respond it would prevent subsequent synchronous script tags. [1] https://dev.twitter.com/docs/tfw-javascript --- _includes/footer.html | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/_includes/footer.html b/_includes/footer.html index 6deb13192b..8927c9048b 100644 --- a/_includes/footer.html +++ b/_includes/footer.html @@ -4,7 +4,6 @@ - @@ -18,6 +17,19 @@ {% endif %} +{% comment %} + Inject Twitter widgets asynchronously. Snippet snipped from Twitter's + JS interface site: https://dev.twitter.com/docs/tfw-javascript +{% endcomment %} + + + From 18318b81b080de83567488031f13d9394ae21c16 Mon Sep 17 00:00:00 2001 From: Ross Allen Date: Tue, 5 Nov 2013 07:39:50 -1000 Subject: [PATCH 5/6] Add async attribute to Twitter widget script --- _includes/footer.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/_includes/footer.html b/_includes/footer.html index 14f6db9a10..56518ac49f 100644 --- a/_includes/footer.html +++ b/_includes/footer.html @@ -20,11 +20,13 @@ {% comment %} Inject Twitter widgets asynchronously. Snippet snipped from Twitter's JS interface site: https://dev.twitter.com/docs/tfw-javascript + + * "js.async=1;" added to add async attribute to the generated script tag. {% endcomment %}