mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-21 12:51:52 +02:00
Code Issues Releases Wiki Activity

Remove redundant visually hidden "(current)" from pagination controls (#31892)

Browse Source 
* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
This commit is contained in:
Patrick H. Lauke
2020-10-14 11:59:43 +01:00
committed by GitHub
parent 0205a016b1
commit 836a4c0bd6
3 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
js/tests/visual/dropdown.html
View File

@@ -19,7 +19,7 @@
<div class="collapse navbar-collapse" id="navbarResponsive"> <div class="collapse navbar-collapse" id="navbarResponsive">
<ul class="navbar-nav"> <ul class="navbar-nav">
<li class="nav-item active"> <li class="nav-item active">
<a class="nav-link" href="#">Home <span class="visually-hidden">(current)</span></a> <a class="nav-link" href="#" aria-current="page">Home</a>
</li> </li>
<li class="nav-item"> <li class="nav-item">
<a class="nav-link" href="#">Link</a> <a class="nav-link" href="#">Link</a>

2
js/tests/visual/modal.html
View File

@@ -19,7 +19,7 @@
<a class="navbar-brand" href="#">This shouldn't jump!</a> <a class="navbar-brand" href="#">This shouldn't jump!</a>
<ul class="navbar-nav"> <ul class="navbar-nav">
<li class="nav-item active"> <li class="nav-item active">
<a class="nav-link" href="#">Home <span class="visually-hidden">(current)</span></a> <a class="nav-link" href="#" aria-current="page">Home</a>
</li> </li>
<li class="nav-item"> <li class="nav-item">
<a class="nav-link" href="#">Link</a> <a class="nav-link" href="#">Link</a>

17
site/content/docs/5.0/components/pagination.md
View File

@@ -62,7 +62,7 @@ While the `.disabled` class uses `pointer-events: none` to _try_ to disable the
</li> </li>
<li class="page-item"><a class="page-link" href="#">1</a></li> <li class="page-item"><a class="page-link" href="#">1</a></li>
<li class="page-item active" aria-current="page"> <li class="page-item active" aria-current="page">
<a class="page-link" href="#">2 <span class="visually-hidden">(current)</span></a> <a class="page-link" href="#">2</a>
</li> </li>
<li class="page-item"><a class="page-link" href="#">3</a></li> <li class="page-item"><a class="page-link" href="#">3</a></li>
<li class="page-item"> <li class="page-item">
@@ -82,10 +82,7 @@ You can optionally swap out active or disabled anchors for `<span>`, or omit the
</li> </li>
<li class="page-item"><a class="page-link" href="#">1</a></li> <li class="page-item"><a class="page-link" href="#">1</a></li>
<li class="page-item active" aria-current="page"> <li class="page-item active" aria-current="page">
<span class="page-link"> <span class="page-link">2</span>
2
<span class="visually-hidden">(current)</span>
</span>
</li> </li>
<li class="page-item"><a class="page-link" href="#">3</a></li> <li class="page-item"><a class="page-link" href="#">3</a></li>
<li class="page-item"> <li class="page-item">
@@ -103,10 +100,7 @@ Fancy larger or smaller pagination? Add `.pagination-lg` or `.pagination-sm` for
<nav aria-label="..."> <nav aria-label="...">
<ul class="pagination pagination-lg"> <ul class="pagination pagination-lg">
<li class="page-item active" aria-current="page"> <li class="page-item active" aria-current="page">
<span class="page-link"> <span class="page-link">1</span>
1
<span class="visually-hidden">(current)</span>
</span>
</li> </li>
<li class="page-item"><a class="page-link" href="#">2</a></li> <li class="page-item"><a class="page-link" href="#">2</a></li>
<li class="page-item"><a class="page-link" href="#">3</a></li> <li class="page-item"><a class="page-link" href="#">3</a></li>
@@ -118,10 +112,7 @@ Fancy larger or smaller pagination? Add `.pagination-lg` or `.pagination-sm` for
<nav aria-label="..."> <nav aria-label="...">
<ul class="pagination pagination-sm"> <ul class="pagination pagination-sm">
<li class="page-item active" aria-current="page"> <li class="page-item active" aria-current="page">
<span class="page-link"> <span class="page-link">1</span>
1
<span class="visually-hidden">(current)</span>
</span>
</li> </li>
<li class="page-item"><a class="page-link" href="#">2</a></li> <li class="page-item"><a class="page-link" href="#">2</a></li>
<li class="page-item"><a class="page-link" href="#">3</a></li> <li class="page-item"><a class="page-link" href="#">3</a></li>