From 8e59752ee1f815bbc30a06465b8d19de35a76c9d Mon Sep 17 00:00:00 2001 From: Rohit Sharma Date: Wed, 25 Nov 2020 13:05:36 +0530 Subject: [PATCH] Partially backport #32217 (#32225) Remove unnecessary `_getCustomClass` method. `customClass` will be in the configuration already, even if it is provided in the data attributes, and jQuery's [`addClass()`](https://api.jquery.com/addclass/) method will handle it, either `this.config.customClass` is a function or a class name (even if it is a blank string). Co-authored-by: XhmikosR --- js/src/tooltip.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/js/src/tooltip.js b/js/src/tooltip.js index 0b74eb800d..9a37e73d12 100644 --- a/js/src/tooltip.js +++ b/js/src/tooltip.js @@ -286,7 +286,7 @@ class Tooltip { this._popper = new Popper(this.element, tip, this._getPopperConfig(attachment)) $(tip).addClass(CLASS_NAME_SHOW) - $(tip).addClass(this._getCustomClass()) + $(tip).addClass(this.config.customClass) // If this is a touch-enabled device we add extra // empty mouseover listeners to the body's immediate children; @@ -734,10 +734,6 @@ class Tooltip { this.config.animation = initConfigAnimation } - _getCustomClass() { - return this.element.getAttribute('data-custom-class') || this.config.customClass - } - // Static static _jQueryInterface(config) {