mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-12 16:44:17 +02:00
Code Issues Releases Wiki Activity

util: change isRTL to a function (#32446)

Browse Source 
This allows the bundler to tree-shake the function.
This commit is contained in:
XhmikosR
2021-02-16 10:14:05 +02:00
committed by GitHub
parent 3602828a90
commit 92434fa30f
5 changed files with 17 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
js/src/carousel.js
View File

@@ -253,7 +253,7 @@ class Carousel extends BaseComponent {
// swipe left // swipe left
if (direction > 0) { if (direction > 0) {
if (isRTL) { if (isRTL()) {
this.next() this.next()
} else { } else {
this.prev() this.prev()
@@ -262,7 +262,7 @@ class Carousel extends BaseComponent {
// swipe right // swipe right
if (direction < 0) { if (direction < 0) {
if (isRTL) { if (isRTL()) {
this.prev() this.prev()
} else { } else {
this.next() this.next()
@@ -350,14 +350,14 @@ class Carousel extends BaseComponent {
if (event.key === ARROW_LEFT_KEY) { if (event.key === ARROW_LEFT_KEY) {
event.preventDefault() event.preventDefault()
if (isRTL) { if (isRTL()) {
this.next() this.next()
} else { } else {
this.prev() this.prev()
} }
} else if (event.key === ARROW_RIGHT_KEY) { } else if (event.key === ARROW_RIGHT_KEY) {
event.preventDefault() event.preventDefault()
if (isRTL) { if (isRTL()) {
this.prev() this.prev()
} else { } else {
this.next() this.next()

12
js/src/dropdown.js
View File

@@ -64,12 +64,12 @@ const SELECTOR_MENU = '.dropdown-menu'
const SELECTOR_NAVBAR_NAV = '.navbar-nav' const SELECTOR_NAVBAR_NAV = '.navbar-nav'
const SELECTOR_VISIBLE_ITEMS = '.dropdown-menu .dropdown-item:not(.disabled):not(:disabled)' const SELECTOR_VISIBLE_ITEMS = '.dropdown-menu .dropdown-item:not(.disabled):not(:disabled)'
const PLACEMENT_TOP = isRTL ? 'top-end' : 'top-start' const PLACEMENT_TOP = isRTL() ? 'top-end' : 'top-start'
const PLACEMENT_TOPEND = isRTL ? 'top-start' : 'top-end' const PLACEMENT_TOPEND = isRTL() ? 'top-start' : 'top-end'
const PLACEMENT_BOTTOM = isRTL ? 'bottom-end' : 'bottom-start' const PLACEMENT_BOTTOM = isRTL() ? 'bottom-end' : 'bottom-start'
const PLACEMENT_BOTTOMEND = isRTL ? 'bottom-start' : 'bottom-end' const PLACEMENT_BOTTOMEND = isRTL() ? 'bottom-start' : 'bottom-end'
const PLACEMENT_RIGHT = isRTL ? 'left-start' : 'right-start' const PLACEMENT_RIGHT = isRTL() ? 'left-start' : 'right-start'
const PLACEMENT_LEFT = isRTL ? 'right-start' : 'left-start' const PLACEMENT_LEFT = isRTL() ? 'right-start' : 'left-start'
const Default = { const Default = {
offset: [0, 2], offset: [0, 2],

7
js/src/modal.js
View File

@@ -431,14 +431,13 @@ class Modal extends BaseComponent {
// ---------------------------------------------------------------------- // ----------------------------------------------------------------------
_adjustDialog() { _adjustDialog() {
const isModalOverflowing = const isModalOverflowing = this._element.scrollHeight > document.documentElement.clientHeight
this._element.scrollHeight > document.documentElement.clientHeight
if ((!this._isBodyOverflowing && isModalOverflowing && !isRTL) || (this._isBodyOverflowing && !isModalOverflowing && isRTL)) { if ((!this._isBodyOverflowing && isModalOverflowing && !isRTL()) || (this._isBodyOverflowing && !isModalOverflowing && isRTL())) {
this._element.style.paddingLeft = `${this._scrollbarWidth}px` this._element.style.paddingLeft = `${this._scrollbarWidth}px`
} }
if ((this._isBodyOverflowing && !isModalOverflowing && !isRTL) || (!this._isBodyOverflowing && isModalOverflowing && isRTL)) { if ((this._isBodyOverflowing && !isModalOverflowing && !isRTL()) || (!this._isBodyOverflowing && isModalOverflowing && isRTL())) {
this._element.style.paddingRight = `${this._scrollbarWidth}px` this._element.style.paddingRight = `${this._scrollbarWidth}px`
} }
} }

7
js/src/tooltip.js
View File

@@ -64,9 +64,9 @@ const DefaultType = {
const AttachmentMap = { const AttachmentMap = {
AUTO: 'auto', AUTO: 'auto',
TOP: 'top', TOP: 'top',
RIGHT: isRTL ? 'left' : 'right', RIGHT: isRTL() ? 'left' : 'right',
BOTTOM: 'bottom', BOTTOM: 'bottom',
LEFT: isRTL ? 'right' : 'left' LEFT: isRTL() ? 'right' : 'left'
} }
const Default = { const Default = {
@@ -563,8 +563,7 @@ class Tooltip extends BaseComponent {
triggers.forEach(trigger => { triggers.forEach(trigger => {
if (trigger === 'click') { if (trigger === 'click') {
EventHandler.on(this._element, this.constructor.Event.CLICK, this.config.selector, event => this.toggle(event) EventHandler.on(this._element, this.constructor.Event.CLICK, this.config.selector, event => this.toggle(event))
)
} else if (trigger !== TRIGGER_MANUAL) { } else if (trigger !== TRIGGER_MANUAL) {
const eventIn = trigger === TRIGGER_HOVER ? const eventIn = trigger === TRIGGER_HOVER ?
this.constructor.Event.MOUSEENTER : this.constructor.Event.MOUSEENTER :

2
js/src/util/index.js
View File

@@ -198,7 +198,7 @@ const onDOMContentLoaded = callback => {
} }
} }
const isRTL = document.documentElement.dir === 'rtl' const isRTL = () => document.documentElement.dir === 'rtl'
const defineJQueryPlugin = (name, plugin) => { const defineJQueryPlugin = (name, plugin) => {
onDOMContentLoaded(() => { onDOMContentLoaded(() => {