From 8a430b36987c98433fd8d9a8035df0d9ec73cb87 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Sat, 27 Jul 2013 21:33:11 -0700 Subject: [PATCH 1/5] workaround possible bug in grunt-contrib-jshint --- Gruntfile.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Gruntfile.js b/Gruntfile.js index 0e4fc244b6..0da0e834f6 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -26,6 +26,7 @@ module.exports = function(grunt) { }, jshint: { options: { + ignores: [],// HACK: workaround https://github.com/gruntjs/grunt-contrib-jshint/issues/86 jshintrc: 'js/.jshintrc' }, gruntfile: { From 880f43221d0f0820d208afcb05f295c6a0afa27a Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Sat, 27 Jul 2013 21:33:41 -0700 Subject: [PATCH 2/5] tweak Gruntfile.js so it passes jshint --- Gruntfile.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Gruntfile.js b/Gruntfile.js index 0da0e834f6..dd0cc96009 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -1,4 +1,6 @@ +/* jshint node: true */ module.exports = function(grunt) { + "use strict"; // Project configuration. grunt.initConfig({ From ba62cfeffebb3be25241f430d63b2e229a1294d4 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Sat, 27 Jul 2013 21:33:11 -0700 Subject: [PATCH 3/5] workaround possible bug in grunt-contrib-jshint --- Gruntfile.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Gruntfile.js b/Gruntfile.js index 0e4fc244b6..0da0e834f6 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -26,6 +26,7 @@ module.exports = function(grunt) { }, jshint: { options: { + ignores: [],// HACK: workaround https://github.com/gruntjs/grunt-contrib-jshint/issues/86 jshintrc: 'js/.jshintrc' }, gruntfile: { From 03b2866b9e83d328d2199c3b44caa31ca4d3c41d Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Sat, 27 Jul 2013 21:33:41 -0700 Subject: [PATCH 4/5] tweak Gruntfile.js so it passes jshint --- Gruntfile.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Gruntfile.js b/Gruntfile.js index 0da0e834f6..dd0cc96009 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -1,4 +1,6 @@ +/* jshint node: true */ module.exports = function(grunt) { + "use strict"; // Project configuration. grunt.initConfig({ From 9c672c6b20f0eee1133f572468f1bbe8ab724c4d Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Sat, 27 Jul 2013 21:56:44 -0700 Subject: [PATCH 5/5] get jshint close to passing by updating .jshintrc settings I don't agree with these personally, but they jive with BS/@fat's JS code style. The remaining jshint complaints are things that really actually should get fixed. --- js/.jshintrc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/js/.jshintrc b/js/.jshintrc index 70e6c57923..94c520d5cf 100644 --- a/js/.jshintrc +++ b/js/.jshintrc @@ -3,9 +3,11 @@ "laxcomma" : true, "laxbreak" : true, "browser" : true, + "eqeqeq" : false, "eqnull" : true, "debug" : true, "devel" : true, + "curly" : false, "boss" : true, "expr" : true, "asi" : true