mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-10 07:37:27 +02:00
Code Issues Releases Wiki Activity

Use cached noop function everywhere

Browse Source
This commit is contained in:
Rohit Sharma
2021-03-27 21:38:45 +05:30
committed by XhmikosR
parent 7b7f4a5ced
commit b2bc159d72
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
js/src/dropdown.js
View File

@@ -192,7 +192,7 @@ class Dropdown extends BaseComponent {
if ('ontouchstart' in document.documentElement && if ('ontouchstart' in document.documentElement &&
!parent.closest(SELECTOR_NAVBAR_NAV)) { !parent.closest(SELECTOR_NAVBAR_NAV)) {
[].concat(...document.body.children) [].concat(...document.body.children)
.forEach(elem => EventHandler.on(elem, 'mouseover', null, noop())) .forEach(elem => EventHandler.on(elem, 'mouseover', null, noop))
} }
this._element.focus() this._element.focus()
@@ -222,7 +222,7 @@ class Dropdown extends BaseComponent {
// empty mouseover listeners we added for iOS support // empty mouseover listeners we added for iOS support
if ('ontouchstart' in document.documentElement) { if ('ontouchstart' in document.documentElement) {
[].concat(...document.body.children) [].concat(...document.body.children)
.forEach(elem => EventHandler.off(elem, 'mouseover', null, noop())) .forEach(elem => EventHandler.off(elem, 'mouseover', null, noop))
} }
if (this._popper) { if (this._popper) {
@@ -435,7 +435,7 @@ class Dropdown extends BaseComponent {
// empty mouseover listeners we added for iOS support // empty mouseover listeners we added for iOS support
if ('ontouchstart' in document.documentElement) { if ('ontouchstart' in document.documentElement) {
[].concat(...document.body.children) [].concat(...document.body.children)
.forEach(elem => EventHandler.off(elem, 'mouseover', null, noop())) .forEach(elem => EventHandler.off(elem, 'mouseover', null, noop))
} }
if (context._popper) { if (context._popper) {

2
js/src/tooltip.js
View File

@@ -301,7 +301,7 @@ class Tooltip extends BaseComponent {
// https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html // https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html
if ('ontouchstart' in document.documentElement) { if ('ontouchstart' in document.documentElement) {
[].concat(...document.body.children).forEach(element => { [].concat(...document.body.children).forEach(element => {
EventHandler.on(element, 'mouseover', noop()) EventHandler.on(element, 'mouseover', noop)
}) })
} }

2
js/src/util/index.js
View File

@@ -190,7 +190,7 @@ const findShadowRoot = element => {
return findShadowRoot(element.parentNode) return findShadowRoot(element.parentNode)
} }
const noop = () => function () {} const noop = () => {}
const reflow = element => element.offsetHeight const reflow = element => element.offsetHeight

4
js/tests/unit/util/index.spec.js
View File

@@ -477,8 +477,8 @@ describe('Util', () => {
}) })
describe('noop', () => { describe('noop', () => {
it('should return a function', () => { it('should be a function', () => {
expect(typeof Util.noop()).toEqual('function') expect(typeof Util.noop).toEqual('function')
}) })
}) })