diff --git a/js/tests/unit/modal.js b/js/tests/unit/modal.js index 9b7fb0aa66..f14ef3290a 100644 --- a/js/tests/unit/modal.js +++ b/js/tests/unit/modal.js @@ -804,7 +804,7 @@ $(function () { var $modalBody = $('.modal-body') $modalBody.scrollTop(100) - assert.strictEqual($modalBody.scrollTop(), 100) + assert.ok($modalBody.scrollTop() > 95 && $modalBody.scrollTop() <= 100) $modal.on('shown.bs.modal', function () { assert.strictEqual($modalBody.scrollTop(), 0, 'modal body scrollTop should be 0 when opened') diff --git a/js/tests/unit/scrollspy.js b/js/tests/unit/scrollspy.js index 1337e585d4..dc55af6863 100644 --- a/js/tests/unit/scrollspy.js +++ b/js/tests/unit/scrollspy.js @@ -201,7 +201,9 @@ $(function () { var done = assert.async() var testElementIsActiveAfterScroll = function (element, target) { var deferred = $.Deferred() - var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top) + // add top padding to fix Chrome on Android failures + var paddingTop = 5 + var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top) + paddingTop $content.one('scroll', function () { assert.ok($(element).hasClass('active'), 'target:' + target + ', element' + element) deferred.resolve() @@ -245,7 +247,9 @@ $(function () { var done = assert.async() var testElementIsActiveAfterScroll = function (element, target) { var deferred = $.Deferred() - var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top) + // add top padding to fix Chrome on Android failures + var paddingTop = 5 + var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top) + paddingTop $content.one('scroll', function () { assert.ok($(element).hasClass('active'), 'target:' + target + ', element' + element) deferred.resolve() @@ -289,7 +293,9 @@ $(function () { var done = assert.async() var testElementIsActiveAfterScroll = function (element, target) { var deferred = $.Deferred() - var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top) + // add top padding to fix Chrome on Android failures + var paddingTop = 5 + var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top) + paddingTop $content.one('scroll', function () { assert.ok($(element).hasClass('active'), 'target:' + target + ', element' + element) deferred.resolve() @@ -604,7 +610,9 @@ $(function () { var testElementIsActiveAfterScroll = function (element, target) { var deferred = $.Deferred() - var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top) + // add top padding to fix Chrome on Android failures + var paddingTop = 5 + var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top) + paddingTop $content.one('scroll', function () { assert.ok($(element).hasClass('active'), 'target:' + target + ', element: ' + element) deferred.resolve()