mirror_css/bootstrap
1
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-08-22 05:03:16 +02:00
Code Issues Releases Wiki Activity

Streamline application.js exampleModal code (#30819)

Browse Source 
* use `textContent` since we only need to add text
* move comments
This commit is contained in:
XhmikosR
2020-05-19 08:33:12 +03:00
committed by GitHub
parent 62626db320
commit e271d01606
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
site/assets/js/application.js
View File

@@ -66,14 +66,16 @@
var exampleModal = document.getElementById('exampleModal') var exampleModal = document.getElementById('exampleModal')
if (exampleModal) { if (exampleModal) {
exampleModal.addEventListener('show.bs.modal', function (event) { exampleModal.addEventListener('show.bs.modal', function (event) {
var button = event.relatedTarget // Button that triggered the modal // Button that triggered the modal
var recipient = button.getAttribute('data-whatever') // Extract info from data-* attributes var button = event.relatedTarget
// Extract info from data-* attributes
var recipient = button.getAttribute('data-whatever')
// Update the modal's content. // Update the modal's content.
var modalTitle = exampleModal.querySelector('.modal-title') var modalTitle = exampleModal.querySelector('.modal-title')
var modalBodyInput = exampleModal.querySelector('.modal-body input') var modalBodyInput = exampleModal.querySelector('.modal-body input')
modalTitle.innerHTML = 'New message to ' + recipient modalTitle.textContent = 'New message to ' + recipient
modalBodyInput.value = recipient modalBodyInput.value = recipient
}) })
} }

7
site/content/docs/5.0/components/modal.md
View File

@@ -547,8 +547,11 @@ exampleModal.addEventListener('show.bs.modal', function (event) {
// and then do the updating in a callback. // and then do the updating in a callback.
// //
// Update the modal's content. // Update the modal's content.
exampleModal.querySelector('.modal-title').textContent = 'New message to ' + recipient var modalTitle = exampleModal.querySelector('.modal-title')
exampleModal.querySelector('.modal-body input').value = recipient var modalBodyInput = exampleModal.querySelector('.modal-body input')
modalTitle.textContent = 'New message to ' + recipient
modalBodyInput.value = recipient
}) })
{{< /highlight >}} {{< /highlight >}}