mirror_css/css-water.css
1
0
Fork 0
mirror of https://github.com/kognise/water.css.git synced 2025-08-08 14:16:58 +02:00
Code Issues Releases Wiki Activity

docs: mention not to use class/id

Browse Source
This commit is contained in:
Jonas Kuske
2020-05-31 07:31:23 +02:00
parent 79c163655e
commit 03c7eb5faa
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
.github/CONTRIBUTING.md vendored
View File

@@ -58,7 +58,9 @@ Also, everyone is welcome to contribute on issues [tagged with **`help wanted`**
There are a few rules for working in the Water.css source code: There are a few rules for working in the Water.css source code:
1. Don't specify colors directly in the source files (`src/parts/*`). Only use named variables there, which are declared in `src/variables-*.css`. 1. The styles must not use any classes or IDs. Water.css is made entirely of basic style rules that only target HTML elements.
2. Don't specify colors directly in the source files (`src/parts/*`). Only use named variables there, which are declared in `src/variables-*.css`.
❌ Bad: ❌ Bad:
```css ```css
@@ -70,9 +72,9 @@ There are a few rules for working in the Water.css source code:
color: var(--text-bright); color: var(--text-bright);
``` ```
2. Reuse existing colors where possible. Before introducing a new color to our palette, check if one of the existing colors fits your needs. 3. Reuse existing colors where possible. Before introducing a new color to our palette, check if one of the existing colors fits your needs.
3. If you introduce a new variable, make sure to declare it both in `variables-dark.css` and `variables-light.css` so it's available in both themes. 4. If you introduce a new variable, make sure to declare it both in `variables-dark.css` and `variables-light.css` so it's available in both themes.
## Make your pull request ## Make your pull request