From 713bfc731b345a46e480ce851cd56c952dd65ddc Mon Sep 17 00:00:00 2001 From: Pete Colapietro Date: Wed, 3 Jun 2020 09:07:46 -0400 Subject: [PATCH 1/6] build(circleci): clean up config See also: https://discuss.circleci.com/t/new-node-js-convenience-image-public-beta/33130 --- .circleci/config.yml | 70 ++++++++++++++++++++++++++------------------ 1 file changed, 41 insertions(+), 29 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7514b0b..4e1ce58 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -7,7 +7,7 @@ defaults: &defaults working_directory: ~/app supported-node-versions: &supported-node-versions - node-version: ["10.20.1", "12.16.3", "13.14.0", "14.2.0"] + node-version: ["10.21.0", "12.18.0", "13.14.0", "14.4.0"] @@ -29,7 +29,7 @@ jobs: <<: *defaults docker: - - image: circleci/node:lts + - image: cimg/node:lts steps: - restore_cache: @@ -61,7 +61,7 @@ jobs: type: string docker: - - image: "circleci/node:<< parameters.node-version >>" + - image: "cimg/node:<< parameters.node-version >>" steps: @@ -100,36 +100,19 @@ jobs: <<: *defaults docker: - - image: "circleci/node:lts" + - image: "cimg/node:lts" steps: - checkout - build-in-all-supported-versions-of-node: - <<: *defaults - - parameters: - node-version: - type: string - - docker: - - image: "circleci/node:<< parameters.node-version >>" - - steps: - - attach_workspace: - at: . + - restore_cache: + name: Restore npm Package Cache + keys: + - "npm-{{ checksum \"package-lock.json\" }}" - run: - name: Move node_modules to correct location for build - command: "[ ! -d \"node_modules_<< parameters.node-version >>\" ] || mv \"node_modules_<< parameters.node-version >>\" node_modules" - - - restore_cache: - name: Restore Build Cache - keys: - - build-{{ .Branch }}-{{ .Environment.CIRCLE_SHA1 }} - - build-{{ .Branch }} - - build-master - - build- + name: Install Dependencies + command: npm install - run: name: Build the Framework @@ -140,17 +123,45 @@ jobs: key: build-{{ .Branch }}-{{ .Environment.CIRCLE_SHA1 }} paths: - css + + - save_cache: + name: Save npm Package Cache + key: "npm-{{ checksum \"package-lock.json\" }}" + paths: + - "node_modules" - persist_to_workspace: root: . paths: - css + build-in-all-supported-versions-of-node: + <<: *defaults + + parameters: + node-version: + type: string + + docker: + - image: "cimg/node:<< parameters.node-version >>" + + steps: + - attach_workspace: + at: . + + - run: + name: Move node_modules to correct location for build + command: "[ ! -d \"node_modules_<< parameters.node-version >>\" ] || mv \"node_modules_<< parameters.node-version >>\" node_modules" + + - run: + name: Build the Framework + command: npm run build + lint: <<: *defaults docker: - - image: "circleci/node:lts" + - image: "cimg/node:lts" steps: - attach_workspace: @@ -196,7 +207,7 @@ jobs: <<: *defaults docker: - - image: circleci/node:lts + - image: cimg/node:lts steps: - attach_workspace: @@ -245,6 +256,7 @@ workflows: - release: requires: - commitlint + - build - build-in-all-supported-versions-of-node - lint # - test From 84d6a95711fe0b5ecfa24ddfd3e69e983f3fce51 Mon Sep 17 00:00:00 2001 From: Pete Colapietro Date: Wed, 3 Jun 2020 14:03:30 -0400 Subject: [PATCH 2/6] build(circleci): store build artifacts --- .circleci/config.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4e1ce58..155f84b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -135,6 +135,9 @@ jobs: paths: - css + - store_artifacts: + path: css + build-in-all-supported-versions-of-node: <<: *defaults @@ -157,6 +160,9 @@ jobs: name: Build the Framework command: npm run build + - store_artifacts: + path: css + lint: <<: *defaults From 74dc822fb1ddce8865456bff032dd273b99ba63c Mon Sep 17 00:00:00 2001 From: Pete Colapietro Date: Sun, 7 Jun 2020 18:24:36 -0400 Subject: [PATCH 3/6] build(circleci): bump node orb version --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 155f84b..25ec292 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,5 +1,5 @@ orbs: - node: circleci/node@2.1.0 + node: circleci/node@3.0.0 version: 2.1 defaults: &defaults From cad24d03f25b7a749c29fdffcf4adf3a08b43e08 Mon Sep 17 00:00:00 2001 From: Peter Colapietro Date: Fri, 2 Oct 2020 06:09:01 -0400 Subject: [PATCH 4/6] build(circleci): bump supported node versions https://nodejs.org/en/about/releases/ https://nodejs.org/download/release/latest-v10.x/ https://nodejs.org/download/release/latest-v12.x/ https://nodejs.org/download/release/latest-v13.x/ https://nodejs.org/download/release/latest-v14.x/ --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 25ec292..911fe3e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -7,7 +7,7 @@ defaults: &defaults working_directory: ~/app supported-node-versions: &supported-node-versions - node-version: ["10.21.0", "12.18.0", "13.14.0", "14.4.0"] + node-version: ["10.22.1", "12.18.4", "13.14.0", "14.13.0"] From 6f8bbc17d8717703fe753269a3d560593fc7f47e Mon Sep 17 00:00:00 2001 From: Peter Colapietro Date: Fri, 2 Oct 2020 06:11:19 -0400 Subject: [PATCH 5/6] build(circleci): remove end of lifed node version > Ended 4 months ago (01 Jun 2020) https://endoflife.date/nodejs --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 911fe3e..3303120 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -7,7 +7,7 @@ defaults: &defaults working_directory: ~/app supported-node-versions: &supported-node-versions - node-version: ["10.22.1", "12.18.4", "13.14.0", "14.13.0"] + node-version: ["10.22.1", "12.18.4", "14.13.0"] From afc910b78050341ba8a471c639a3878c00827d38 Mon Sep 17 00:00:00 2001 From: Peter Colapietro Date: Fri, 2 Oct 2020 06:19:10 -0400 Subject: [PATCH 6/6] build(circleci): bump node orb version https://circleci.com/developer/orbs/orb/circleci/node --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3303120..791dfc8 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,5 +1,5 @@ orbs: - node: circleci/node@3.0.0 + node: circleci/node@4.0.1 version: 2.1 defaults: &defaults