mirror_css/nes.css
1
0
Fork 0
mirror of https://github.com/nostalgic-css/NES.css.git synced 2025-08-30 17:30:23 +02:00
Code Issues Releases Wiki Activity

Move from box-shadow to border-image for pixelated borders (#234)

Browse Source 
* refactor: Convert pixelated borders from box-shadows to border-images

Our previous usage of `box-shadows` and pseudo elements proved to be pretty buggy. Converting to
`border-image`s seems to have fixed a lot of the issues that `box-shadows` caused, such as
`background-color`s appering over top of our borders.

BREAKING CHANGE: This change both eliminates pseudo elements from several components, and adds
pseudo elements to components that did not have them before. This could cause compatibility issues
for users that relied on the existence of those pseudo elements for various styling techniques.

* style(buttons): Remove superfluous commented code
This commit is contained in:
Trezy
2018-12-29 13:24:06 -06:00
committed by Abdullah Samman
parent 5c4f46ec70
commit 44a1fb2fea
11 changed files with 166 additions and 240 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
scss/base/variables.scss
View File

@@ -7,6 +7,7 @@ $background-color: $color-white;
$cursor-url: url(https://unpkg.com/nes.css/assets/cursor.png);
$cursor-click-url: url(https://unpkg.com/nes.css/assets/cursor-click.png);
$border-size: 0.25em;
$default-colors: (
normal: $background-color,